From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B28D0D7BB for ; Fri, 11 Oct 2024 15:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:To:CC:From:Message-ID:Date:Content-Type:Content-Transfer-Encoding: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bx074e4HGLmDJv06LML79379zBigZVqcIwirOD1IXIg=; b=s6NE5vgkwOsJdn+dpA5eHDhfTx k3Czs/GZi9vxt+u5/xWxyUZpS3snYr24Jml5WCYhIA0hNy6wbs2qYS/lg/KgFSEg0KoHL311ejHao RuhqVca1/RGhn+3TeCB2IdUSBIuTiqGbMeuSYwClIUkTM7MrKsIkIOKJjjlEK1PcvArcowV1U7jQ9 igIqBBxuqO9Y/pi+d33s0Oy8s2yrzxakJDLlPX+68Cm0KKCzvjCx8XuR5kabSxYRzHRrMH3C8BFUz foNhQ4SvhsrpA6DFu0TopFPgTveogME/FqslRwVwa58ZyVWDqhqqC8g8wPbJCNNwBNpYQ/5osbRuz gem0fLvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szHbv-0000000Go5I-0bJ1; Fri, 11 Oct 2024 15:31:23 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szHZX-0000000GnL5-0hqI for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2024 15:28:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1728660535; x=1760196535; h=mime-version:content-transfer-encoding:date:message-id: from:cc:to:subject:references:in-reply-to; bh=bx074e4HGLmDJv06LML79379zBigZVqcIwirOD1IXIg=; b=xTh0sIrUooNkk2i1j/n7sYCrfA7Tn+Fjj+S4okCeB5V9DQS/xsN9CdS9 6nkZHB+94C0MzDvLGfKaqbvB4BDtkPWiNItYlL767tVXTlKSD/XfJaSP1 8No6VV0S+9OHxfCZ0wWEvBweepAOBUPv+iOeJV4mi7eCR9EVeVk54cGbl hYXp+AirwOlPuNih0cJby0Ku8wlBtEWjdQcYTXPTT1XamkR2NoE+spNOx ZARbVQve4BnpYBCIEjDpIAY62vd60zH5Al4Y8gDjo27lAPzkVyRY45n61 wpupbrSCAh++v1SkhRJO5Erua7ZDcqJ6yfisIDoVuQJ212sRwxwv9vOfb Q==; X-CSE-ConnectionGUID: Y93VkM+wSkyKET2ip2ekUg== X-CSE-MsgGUID: QMsnCg/IQOazEdV6BmBZTw== X-IronPort-AV: E=Sophos;i="6.11,196,1725346800"; d="scan'208";a="32715362" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Oct 2024 08:28:52 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 11 Oct 2024 08:28:27 -0700 Received: from localhost (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Fri, 11 Oct 2024 08:28:25 -0700 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Date: Fri, 11 Oct 2024 17:28:25 +0200 Message-ID: From: =?utf-8?q?Jens_Emil_Schulz_=C3=98stergaard?= CC: , , , , , , , , , , To: Jinjie Ruan Subject: Re: [PATCH] net: microchip: vcap api: Fix memory leaks in vcap_api_encode_rule_test() X-Mailer: aerc 0.17.0-0-g6ea74eb30457 References: <20241010130231.3151896-1-ruanjinjie@huawei.com> In-Reply-To: <20241010130231.3151896-1-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_082855_792432_521F6BFF X-CRM114-Status: UNSURE ( 5.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu Oct 10, 2024 at 3:02 PM CEST, Jinjie Ruan wrote: > Commit a3c1e45156ad ("net: microchip: vcap: Fix use-after-free error in > kunit test") fixed the use-after-free error, but introduced below > memory leaks by removing necessary vcap_free_rule(), add it to fix it. Thank you for the fix. I reproduced the bug and confirmed the fix. ... > Cc: stable@vger.kernel.org > Fixes: a3c1e45156ad ("net: microchip: vcap: Fix use-after-free error in k= unit test") > Signed-off-by: Jinjie Ruan Reviewed-by: Jens Emil Schulz =C3=98stergaard