From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8745AE7717F for ; Tue, 10 Dec 2024 14:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:Cc:To:From:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U+lr9Xj8fasPSLICMtvgJpje7wSb8uDowE1UhnFV4lk=; b=Y2Yt0TgSdcSZF2BkO7zWj4j5Rz NgzmfTxKRAOtdIQbLd4U93p5PGjKrNhA8drQLOFaPtRtCjZcuDOf+obaILVJQu14ueBab6DTrWTmw GsfEn3Tc3e58Oe22ITqBETSJuIYFrEbM4JSlhmbiA4bGVZEwu1YxzzSReM6t3l1sgl0qw2KPXW7R3 8kRhNkxrpu0nDWpVaH31yNhLHMojec6NnDqcjY0qcwcWfNOpCehXf2V/8UgqVon19tj51R54CHoA8 f04ItnexJATfiR9k6RPSDXnoUxv4I+Orv/qaeB9YiZnP7F1Aeq6LdlYxwotjlOxxOadTeG70gbuEB 5cmh8yuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tL0w3-0000000Bh7a-2xtA; Tue, 10 Dec 2024 14:09:59 +0000 Received: from out-170.mta1.migadu.com ([2001:41d0:203:375::aa]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tL0uq-0000000Bgoe-0d5M for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2024 14:08:45 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1733839721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U+lr9Xj8fasPSLICMtvgJpje7wSb8uDowE1UhnFV4lk=; b=i7TT7o4mPAPdG7vU6a/kLsvJUfv7u5Ia+z4a/tIAc7XkC2g9FKzSWyiwE5Wdp7yAWWpJ9C xJOYKvJzZSyKUE/7akX3awuNlhZSOt26uORS2E82RRA/KJf8Lv0MwMzM/UpcYb1srG0AUu 9p3ubdqlEmmnBeH6ehTpnobyxRW9jzVw+OX2jt+kc0BDJyhMPzGux6HZNt9NHjFQsAku6A O8k2LDTbSFS9HnW+H1WNT6rFVDJPdagI6NAOpxryFERH+3iD90F89TtgdS7oGJbJdTKSJH usN8MLZVd/hFVQs/r9zToDJ6rNE7CbjrZXOeTSgQ2wgMSefQWk4mI+K3+wZEYA== Content-Type: multipart/signed; boundary=71c82bf461fdb53d31fda9f19110d3c968b0d155862851919717d99cc7ad; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Tue, 10 Dec 2024 15:08:29 +0100 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Peter Geis" Cc: "Heiko Stuebner" , "Conor Dooley" , "Dragan Simic" , "Johan Jonker" , "Krzysztof Kozlowski" , "Levin Du" , "Rob Herring" , , , , Subject: Re: [PATCH 5/6] arm64: dts: rockchip: correct rk3328-roc regulator map References: <20241210013010.81257-1-pgwipeout@gmail.com> <20241210013010.81257-6-pgwipeout@gmail.com> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241210_060844_756042_101C1BFA X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --71c82bf461fdb53d31fda9f19110d3c968b0d155862851919717d99cc7ad Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Dec 10, 2024 at 2:04 PM CET, Peter Geis wrote: > On Tue, Dec 10, 2024 at 6:31=E2=80=AFAM Diederik de Haas wrote: > > On Tue Dec 10, 2024 at 2:30 AM CET, Peter Geis wrote: > > > voltages to vcc_host1_5v, and standardize the order of regulator > > > properties among the fixed regulators. > > > > Big fan of standardization :-) ... > > > > > > > > Fixes: 2171f4fdac06 ("arm64: dts: rockchip: add roc-rk3328-cc board") > > > Signed-off-by: Peter Geis > > > --- > > > > > > arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 23 +++++++++++++-----= -- > > > 1 file changed, 15 insertions(+), 8 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm6= 4/boot/dts/rockchip/rk3328-roc.dtsi > > > index f782c8220dd3..6984387ff8b3 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi > > > +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi > > > @@ -24,22 +24,23 @@ gmac_clkin: external-gmac-clock { > > > #clock-cells =3D <0>; > > > }; > > > > > > - dc_12v: regulator-dc-12v { > > > + /* fed from passive usb input connector */ > > > + dc_5v: regulator-dc-5v { > > > compatible =3D "regulator-fixed"; > > > - regulator-name =3D "dc_12v"; > > > + regulator-name =3D "dc_5v"; > > > regulator-always-on; > > > regulator-boot-on; > > > - regulator-min-microvolt =3D <12000000>; > > > - regulator-max-microvolt =3D <12000000>; > > > + regulator-min-microvolt =3D <5000000>; > > > + regulator-max-microvolt =3D <5000000>; > > > }; > > > > > > vcc_sd: regulator-sdmmc { > > > compatible =3D "regulator-fixed"; > > > + regulator-name =3D "vcc_sd"; > > > gpio =3D <&gpio0 RK_PD6 GPIO_ACTIVE_LOW>; > > > pinctrl-names =3D "default"; > > > pinctrl-0 =3D <&sdmmc0m1_pin>; > > > regulator-boot-on; > > > - regulator-name =3D "vcc_sd"; > > > regulator-min-microvolt =3D <3300000>; > > > regulator-max-microvolt =3D <3300000>; > > > vin-supply =3D <&vcc_io>; > > > > ... but why not put regulator-name as the first of the regulator > > properties as is done in the rk3328-rock64.dts ... > > > > > @@ -50,22 +51,25 @@ vcc_sdio: regulator-sdmmcio { > > > states =3D <1800000 0x1>, <3300000 0x0>; > > > regulator-name =3D "vcc_sdio"; > > > regulator-type =3D "voltage"; > > > + regulator-always-on; > > > regulator-min-microvolt =3D <1800000>; > > > regulator-max-microvolt =3D <3300000>; > > > - regulator-always-on; > > > vin-supply =3D <&vcc_sys>; > > > }; > > > > > > vcc_host1_5v: vcc_otg_5v: regulator-vcc-host1-5v { > > > compatible =3D "regulator-fixed"; > > > + regulator-name =3D "vcc_host1_5v"; > > > enable-active-high; > > > pinctrl-names =3D "default"; > > > pinctrl-0 =3D <&usb20_host_drv>; > > > - regulator-name =3D "vcc_host1_5v"; > > > regulator-always-on; > > > + regulator-min-microvolt =3D <5000000>; > > > + regulator-max-microvolt =3D <5000000>; > > > vin-supply =3D <&vcc_sys>; > > > }; > > > > ... and was the case here? > > That's fair, thank you. I like the alphabetical approach, I'll go that > way when I split this out. FWIW, I'm fine when regulator-name and regulator-type would be put on the top of the regulator-* properties, also because that's currently the case for the rk3328-rock64.dts. And a strict alphabetical order would look weird anyway as then -max-microvolt should be ordered above -min-microvolt. Cheers, Diederik --71c82bf461fdb53d31fda9f19110d3c968b0d155862851919717d99cc7ad Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ1hLYgAKCRDXblvOeH7b bsqGAP0ausb4UuEsVs1vJjp21RP5uSetGtXSYkjqDm5Iwx0S+QEAhXy7tQEG2SpU vxYM7GPJ6U1VLvsRMAenXCAd0jGDOwc= =Xo59 -----END PGP SIGNATURE----- --71c82bf461fdb53d31fda9f19110d3c968b0d155862851919717d99cc7ad--