From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC4B1C282D0 for ; Mon, 3 Mar 2025 21:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KL0RgwYMwPDxX5LpzzMcHu60ayt30SuNBgN28Dcp7Hw=; b=YdYo5VCXnWya1mbCWb0B7fsu6R IN2fuSu/JDMUBUb9v/t37MSyNQOXYuhQLNUuzwnCyTcq7wh7EZb6jwEE47eFj7B7Q0y/2Z7am4p7K paKa36mQMjtIuLEf7gJQhP0cgShtKLXOonbLWEV2N3x7FrH0+fpNE4Tz30eDR8i1HGO0J69W8GCrv dSGU4Cs9rW5KbMkxAZofvd2BV0OphW/CmTH92/b53Jn1DcBclQRFLoC49rYKINjtlTTTbNG0WX9AU vt9Qu53cO4dzFbPOKANZgliCx1fQr35R31ufccODIn6WeQwyIlTAH1DQqpfaQ0dcMfFf7RXSSK/fF Eg1yuJBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpD3s-00000002KyQ-3BWD; Mon, 03 Mar 2025 21:10:52 +0000 Received: from out-179.mta0.migadu.com ([91.218.175.179]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpCzi-00000002KKO-0HFc for linux-arm-kernel@lists.infradead.org; Mon, 03 Mar 2025 21:06:35 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1741035981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KL0RgwYMwPDxX5LpzzMcHu60ayt30SuNBgN28Dcp7Hw=; b=hhAMS7MQqfegpHYoQsM7IHG8RpfHLNLMhR4NpVcSml6EfVHIhEBd4qnqJaEA+NcyD5UEXv /GZ+dPQlEnhRCREQPzmIhrhEwVWUhHTiHGUpktS++q2XO3w3N63tqaCybc5PSZoH6g/al5 VHMtOXuLLRyk8cqN94xKgPB8c32YHT8VXhDkz0e0NEf1S06OOlTY5PoN7ijS99Zsd3wfS7 5ntajLM2A3m523uU0iOKB9DUghxdu15t7m2J9qSWkRx+xTdtD6yfy+v4wL91Sih30/LZiM Xu48SnixKJi453V9kWQfHc39ouhljwhKPql4fRyG1l6Q9ccBKYfysSlsedZjzQ== Content-Type: multipart/signed; boundary=3e1d67d79bc1372e9f689bf3a32389e21547715a78ffa78981b7ded1a50b; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Mon, 03 Mar 2025 22:06:04 +0100 Message-Id: To: "Dragan Simic" , Cc: , , , , , , , , , "Vincenzo Palazzo" , "Peter Geis" , "Bjorn Helgaas" , "Marek Kraus" Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add missing PCIe supplies to RockPro64 board dtsi X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250303_130634_246725_B5798897 X-CRM114-Status: GOOD ( 30.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --3e1d67d79bc1372e9f689bf3a32389e21547715a78ffa78981b7ded1a50b Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Dragan, On Sun Mar 2, 2025 at 7:48 PM CET, Dragan Simic wrote: > Add missing "vpcie0v9-supply" and "vpcie1v8-supply" properties to the "pc= ie0" > node in the Pine64 RockPro64 board dtsi file. This eliminates the follow= ing > warnings from the kernel log: > > rockchip-pcie f8000000.pcie: supply vpcie1v8 not found, using dummy reg= ulator > rockchip-pcie f8000000.pcie: supply vpcie0v9 not found, using dummy reg= ulator > > These additions improve the accuracy of hardware description of the RockP= ro64 > and, in theory, they should result in no functional changes to the way bo= ard > works after the changes, because the "vcca_0v9" and "vcca_1v8" regulators= are > always enabled. [1][2] However, extended reliability testing, performed = by > Chris, [3] has proven that the age-old issues with some PCI Express cards= , > when used with a Pine64 RockPro64, are also resolved. Thanks for this patch :-) I 'reported' the issue based on the logs I saw from other people, but now that I have a RockPro64 (version 2.1) myself, I can confirm that without this patch I saw those warnings myself. When booted up without a PCIe card in the slot, I also saw these errors: [ 5.106650] rockchip-pcie f8000000.pcie: PCIe link training gen1 timeout= ! [ 5.107373] rockchip-pcie f8000000.pcie: probe with driver rockchip-pcie= failed with error -110 You indicated that that was due to there being no PCIe card inserted. After applying this patch I booted up my RockPro64 and found that the above mentioned warnings are indeed gone. Then I inserted a Renesas Electronics Corp. uPD720201 USB 3.0 Host Controller in the PCIe slot and booted up. The above mentioned errors were indeed gone. Furthermore ``lspci`` showed that card and when I plugged in an USB 3 drive in one of the ports, it was correctly detected and I could mount the partition on my system. So feel free to include: Tested-by: Diederik de Haas Cheers, Diederik > Those issues were already mentioned in the commit 43853e843aa6 (arm64: dt= s: > rockchip: Remove unsupported node from the Pinebook Pro dts, 2024-04-01), > together with a brief description of the out-of-tree enumeration delay pa= tch > that reportedly resolves those issues. In a nutshell, booting a RockPro6= 4 > with some PCI Express cards attached to it caused a kernel oops. [4] > > Symptomatically enough, to the commit author's best knowledge, only the P= ine64 > RockPro64, out of all RK3399-based boards and devices supported upstream,= has > been reported to suffer from those PCI Express issues, and only the RockP= ro64 > had some of the PCI Express supplies missing in its DT. Thus, perhaps so= me > weird timing issues exist that caused the "vcca_1v8" always-on regulator, > which is part of the RK808 PMIC, to actually not be enabled before the PC= I > Express is initialized and enumerated on the RockPro64, causing oopses wi= th > some PCIe cards, and the aforementioned enumeration delay patch [4] proba= bly > acted as just a workaround for the underlying timing issue. > > Admittedly, the Pine64 RockPro64 is a bit specific board by having a stan= dard > PCI Express slot, allowing use of various standard cards, but pretty much > standard PCI Express cards have been attached to other RK3399 boards as w= ell, > and the commit author is unaware ot such issues reported for them. > > It's quite hard to be sure that the PCI Express issues are fully resolved= by > these additions to the DT, without some really extensive and time-consumi= ng > testing. However, these additions to the DT can result in good things an= d > improvements anyway, making them perfectly safe from the standpoint of be= ing > unable to do any harm or cause some unforeseen regressions. > > Shuffle and reorder the "vpcie*-supply" properties a bit, so they're sort= ed > alphanumerically, which is a bit more logical and more useful than having > these properties listed in their strict alphabetical order. > > These changes apply to the both supported hardware revisions of the Pine6= 4 > RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] > > [1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf > [2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf > [3] https://z9.de/hedgedoc/s/nF4d5G7rg#reboot-tests-for-PCIe-improvements > [4] https://lore.kernel.org/lkml/20230509153912.515218-1-vincenzopalazzod= ev@gmail.com/T/#u > > Fixes: bba821f5479e ("arm64: dts: rockchip: add PCIe nodes on rk3399-rock= pro64") > Cc: stable@vger.kernel.org > Cc: Vincenzo Palazzo > Cc: Peter Geis > Cc: Bjorn Helgaas > Reported-by: Diederik de Haas > Tested-by: Chris Vogel > Signed-off-by: Dragan Simic > --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/ar= m64/boot/dts/rockchip/rk3399-rockpro64.dtsi > index 47dc198706c8..41ee381ff81f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > @@ -673,8 +673,10 @@ &pcie0 { > num-lanes =3D <4>; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pcie_perst>; > - vpcie12v-supply =3D <&vcc12v_dcin>; > + vpcie0v9-supply =3D <&vcca_0v9>; > + vpcie1v8-supply =3D <&vcca_1v8>; > vpcie3v3-supply =3D <&vcc3v3_pcie>; > + vpcie12v-supply =3D <&vcc12v_dcin>; > status =3D "okay"; > }; > =20 --3e1d67d79bc1372e9f689bf3a32389e21547715a78ffa78981b7ded1a50b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ8YZxQAKCRDXblvOeH7b btp4AQCpxT1Wwlbg+zU1W+K7B20UFqP9NHEG0RITnzD0J3T3KQEAnWg5e7gb3kpe v8idNl4faXofRHNasq3iEeMwbqLWQA0= =fTAb -----END PGP SIGNATURE----- --3e1d67d79bc1372e9f689bf3a32389e21547715a78ffa78981b7ded1a50b--