From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A40EEC282C6 for ; Mon, 3 Mar 2025 21:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:Cc:To:From:Message-Id:Date:Content-Type:Mime-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SPR0yHTL9G5UObQ+1ZLwbXfpYibvfRkKqDO5ejFcj7c=; b=3PMCyX6xDQWqmDqZOM4IeRphWo bdW2ntkVq71RwNWMNzY9iAzimeWLXPrrhcj/QrylmofNp2PFzsPb+pJMZxujr6j4s/32k+KRXciFu 8GFNOqLfjG41JkjM3/sQQIg/1hXi1HF+Ts7c54fjzzJc2QqI8NVbdFjYu40HGAfwdASiAKinebLN2 8GSHiDIkibUCbm5lo9g18sBma11sTkjERFQK3+zEfunJnCTgcrQBXx/3ffbpGPMbXlia9869omNcW Cr7+aqXuE/laBOi6hEOWHi8LFWBBmQsA7MgEPsdpZNyw3OChjdt68Gmycj9fnR4o5l7ldsThgDk7h JjssmCzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpDUb-00000002Nb7-0DQe; Mon, 03 Mar 2025 21:38:29 +0000 Received: from out-174.mta1.migadu.com ([2001:41d0:203:375::ae]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpDT1-00000002NVM-29V6 for linux-arm-kernel@lists.infradead.org; Mon, 03 Mar 2025 21:36:52 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1741037799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SPR0yHTL9G5UObQ+1ZLwbXfpYibvfRkKqDO5ejFcj7c=; b=FKPHvcH7c9zqAD2wESgcTCiEHMa1t179PF75OD/gBjZUlW35GuneHgQh3HWsNZMX0pOnbi +6RkoPQH9w6R5bz9uQHkHfTFpwYR0WulMu3vkJDuVzl8DOFABTBxXR1TQBYqrHEpFdhebd 9VdLQKQUsz67EHvE8Mai5BwzwVmn0P7sqW6bTZ/H5kwcyrfjsxxifLMp2+72CRfE8fvwJU ucj94m+EDxHS5Yw9ACbnRbsfw7RB1uMUBMEXG3Voi5ce9rEWlXJVXCY13HQg46uiB5HpZA aaNnQuUSoe16F5dTA5w+uR+1mqMYFUtVFYI6EREYjbqJlr7nDvw3cnNOKCpUPQ== Content-Type: multipart/signed; boundary=d8a90991c87105546b1f1cba4bc2dbbd19c5ea33d56cd1a4d2b8bf3508e6; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Mon, 03 Mar 2025 22:36:23 +0100 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Dragan Simic" , Cc: , , , , , , , , , "Marek Kraus" Subject: Re: [PATCH v2 1/2] arm64: dts: rockchip: Add avdd HDMI supplies to RockPro64 board dtsi References: In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250303_133651_685443_E51E86FF X-CRM114-Status: GOOD ( 23.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --d8a90991c87105546b1f1cba4bc2dbbd19c5ea33d56cd1a4d2b8bf3508e6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Dragan, On Sun Mar 2, 2025 at 7:48 PM CET, Dragan Simic wrote: > Add missing "avdd-0v9-supply" and "avdd-1v8-supply" properties to the "hd= mi" > node in the Pine64 RockPro64 board dtsi file. To achieve this, also add = the > associated "vcca_0v9" regulator that produces the 0.9 V supply, [1][2] wh= ich > hasn't been defined previously in the board dtsi file. > > This also eliminates the following warnings from the kernel log: > > dwhdmi-rockchip ff940000.hdmi: supply avdd-0v9 not found, using dummy r= egulator > dwhdmi-rockchip ff940000.hdmi: supply avdd-1v8 not found, using dummy r= egulator Also thanks for this patch :-) I've now also confirmed for myself that without this patch I see the above warnings and I don't see them with this patch applied. When booting up I saw an U-Boot logo (hadn't seen that one before) and not longer after that I saw the various boot messages come by on the monitor I had connected to the HDMI port. This is only a *very* barebones install (yet), so I couldn't do 'deeper' tests, but HDMI appears to work. So feel free to include: Tested-by: Diederik de Haas Cheers, Diederik > > There are no functional changes to the way board works with these additio= ns, > because the "vcc1v8_dvp" and "vcca_0v9" regulators are always enabled, [1= ][2] > but these additions improve the accuracy of hardware description. > > These changes apply to the both supported hardware revisions of the Pine6= 4 > RockPro64, i.e. to the production-run revisions 2.0 and 2.1. [1][2] > > [1] https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf > [2] https://files.pine64.org/doc/rockpro64/rockpro64_v20-SCH.pdf > > Fixes: e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for R= ockpro64") > Cc: stable@vger.kernel.org > Suggested-by: Diederik de Haas > Signed-off-by: Dragan Simic > --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/ar= m64/boot/dts/rockchip/rk3399-rockpro64.dtsi > index 69a9d6170649..47dc198706c8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > @@ -227,6 +227,16 @@ vcc5v0_usb: regulator-vcc5v0-usb { > vin-supply =3D <&vcc12v_dcin>; > }; > =20 > + vcca_0v9: regulator-vcca-0v9 { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "vcca_0v9"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt =3D <900000>; > + regulator-max-microvolt =3D <900000>; > + vin-supply =3D <&vcc3v3_sys>; > + }; > + > vdd_log: regulator-vdd-log { > compatible =3D "pwm-regulator"; > pwms =3D <&pwm2 0 25000 1>; > @@ -312,6 +322,8 @@ &gmac { > }; > =20 > &hdmi { > + avdd-0v9-supply =3D <&vcca_0v9>; > + avdd-1v8-supply =3D <&vcc1v8_dvp>; > ddc-i2c-bus =3D <&i2c3>; > pinctrl-names =3D "default"; > pinctrl-0 =3D <&hdmi_cec>; --d8a90991c87105546b1f1cba4bc2dbbd19c5ea33d56cd1a4d2b8bf3508e6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ8Yg3QAKCRDXblvOeH7b bq9wAQCusrEFMAJXQYDLkDEx+x1dIC0qmK207Wx9wyGlJYC3XgD/awM9hupSqNWO O0yXgcsLM0uoj1NxWs+YlE7lnWbdIAs= =ukKr -----END PGP SIGNATURE----- --d8a90991c87105546b1f1cba4bc2dbbd19c5ea33d56cd1a4d2b8bf3508e6--