From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D75D2C369D1 for ; Tue, 22 Apr 2025 19:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RRoJLlC7A12/TR2Wz8V+c+670ziWaCSA92DtyIsQ39c=; b=qWA7r1fEEnQmePrYtfe4u+K4hh EK4G4LZt/fFNzilF7L2myy3E+Yx9Z0l6mGJ7rKkP0he9aovgHb9zZTam+L4mpiUh7Ew2Q/wJjHAtU APjS1j1FDJaouPueGFSZ5+Mf7BbPB2dmZ4xhsVr5UUqcnlL2mxGCXOPACt1Y+gri6HgqOnAQV+L8Y zKVu8ADUz2pT5K30zxkWKf6Kc2To7yPUJO+BYaWsC/E06QCwynBF1CXa1oI0vH8cxzCPN9qVKOQ7V aEhqbB71RYpoJ/8hGy8CtjiVTnZeenFdHFOUbYjHglm8yR2Q6LaOilAIVmVpdLk9Vlt6/altdvmTM kYBmu99A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7JaP-00000008LVP-1tsK; Tue, 22 Apr 2025 19:47:17 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7GDT-00000007qXq-0eND for linux-arm-kernel@lists.infradead.org; Tue, 22 Apr 2025 16:11:25 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6506D43A46; Tue, 22 Apr 2025 16:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745338279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRoJLlC7A12/TR2Wz8V+c+670ziWaCSA92DtyIsQ39c=; b=BL+N8Q5Fn6rdiqBn6OmTsxXoJ9Hmwb4+Cp9EPmNsArEyLxUBWFVxrjkUHAF0kIsavPM6XX diCJtu+5Ly9c8KpN6G8x6k6lDFpyCYNdFdmJbLzqvILAA2E461zP6Vl5aQnWM52I1ZKFjb URv4AQLYjPslN6FYm//6sL4cTinqbdZ0ozPAQ8e/3iB+TBYuQf2hdfFevjXWgqw3IDHG8/ uY3oRLwfCgKhdSGVb6x4CH2T0ogBE6yTmirNGCqLE14+OuS7xL/NOa3//AO+jRjVas+IZt Do7zVrHIg0pSTNgvl5tNaYZYAfY7atWN0Xxx+Tu4ztV+/zEpRVIM3rCNf3Da9w== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 22 Apr 2025 18:11:18 +0200 Message-Id: To: "Maxime Chevallier" Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Maxime Coquelin" , "Alexandre Torgue" , "Richard Cochran" , "Daniel Machon" , "Thomas Petazzoni" , , , , , "Russell King (Oracle)" Subject: Re: [PATCH net 1/2] net: stmmac: fix dwmac1000 ptp timestamp status offset From: =?utf-8?q?Alexis_Lothor=C3=A9?= X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250422-stmmac_ts-v1-0-b59c9f406041@bootlin.com> <20250422-stmmac_ts-v1-1-b59c9f406041@bootlin.com> <20250422174934.309a1309@fedora.home> In-Reply-To: <20250422174934.309a1309@fedora.home> X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeegudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkvfevuffhofhfjgesthhqredtredtjeenucfhrhhomheptehlvgigihhsucfnohhthhhorhoruceorghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeekgfffhfehhfefgeekhfffudfhheekveffleeuhfelgfefueevhedvkeduhfehveenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudeipdhrtghpthhtohepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdprhgtphhtthhopegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhto hepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtohepmhgtohhquhgvlhhinhdrshhtmhefvdesghhmrghilhdrtghomhdprhgtphhtthhopegrlhgvgigrnhgurhgvrdhtohhrghhuvgesfhhoshhsrdhsthdrtghomh X-GND-Sasl: alexis.lothore@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_091123_495386_5DB5F47B X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Tue Apr 22, 2025 at 5:49 PM CEST, Maxime Chevallier wrote: > Hi Alexis, > > On Tue, 22 Apr 2025 17:07:22 +0200 > Alexis Lothore wrote: > >> When a PTP interrupt occurs, the driver accesses the wrong offset to >> learn about the number of available snapshots in the FIFO for dwmac1000: >> it should be accessing bits 29..25, while it is currently reading bits >> 19..16 (those are bits about the auxiliary triggers which have generated >> the timestamps). As a consequence, it does not compute correctly the >> number of available snapshots, and so possibly do not generate the >> corresponding clock events if the bogus value ends up being 0. >>=20 >> Fix clock events generation by reading the correct bits in the timestamp >> register for dwmac1000. >>=20 >> Fixes: 19b93bbb20eb ("net: stmmac: Introduce dwmac1000 timestamping oper= ations") > > Looks like the commit hash is wrong, should be : > > 477c3e1f6363 ("net: stmmac: Introduce dwmac1000 timestamping operations") Yes, you are absolutely right, I wrongly picked this hash from a custom branch rather than a stable branch -_- Thanks for spotting this, will be fixed in v2. > > Other than that I agree with the change, these offset are the right > ones, thanks... > > With the Fixes tag fixed, > > Reviewed-by: Maxime Chevallier Thanks, Alexis --=20 Alexis Lothor=C3=A9, Bootlin Embedded Linux and Kernel engineering https://bootlin.com