From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECEFFC369DC for ; Tue, 29 Apr 2025 09:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To :From:Subject:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tqZ0WDpd3UCnsiyB13GsKoIcLdHmxLRzaHRSKG1EEsE=; b=x8VR74lqeR3IRBCXjZ6kMgsPzW Znsb+XlTPgeJz49wXgk36+DrV1J1dxaOZN5SMz/0oe+dNqbxPRS6hydeRG02jvuernEa99757pale lFmtaoVKpfrrT4/43qq8qM/06MRkwPLj5UZ69Yl3sZgYENGouG1l8VO9yLIx+hVrBfw+HQwz2jaWk D228+VoOguXhXvn7cGhumsfxGw0FUPcDOFAASWdU9VTSw45uL73T3Rg6YLFi+PKyGgKk2bK7+N/3L H9ySS26KO/O0TggxkepUPEQ2pcJDR1y/npAjP46ybKKVA/qdJ0cNgSuHH4vnaT+nn6SSMnLFNtAnk StvviI4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9hcR-00000009CeU-0Qf9; Tue, 29 Apr 2025 09:51:15 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9haU-00000009CPW-1BwK for linux-arm-kernel@lists.infradead.org; Tue, 29 Apr 2025 09:49:15 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 656F74328B; Tue, 29 Apr 2025 09:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1745920150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tqZ0WDpd3UCnsiyB13GsKoIcLdHmxLRzaHRSKG1EEsE=; b=BaZ8t7kO9QR35XhfDlLfJAdORCV3aUUi29DxhEffSeC4/qO92hJbYxjDTNjWePj37YQqqF qGV6UZvx7sYqEEapQ2sJNm8niEkNvhO1YEYSUYaDBCnaRPwA/+XiuSdXFeCM0VFFeU/bQY 63jcFp8qOHYMrHQAugG28HWTCZ2mKc9+ShVrmzLnKjnShPn3uM5fl9OcmuIovrkmIk9dnB +mgoGULFSg3PqOsylSrO84e2Aq1HJ8dM5/81jemh5xyMQ8O6QnGTO/ieBXvFUb2f2tyJxA AscSm/s01ycVbb1sJuvhgTwL7GxTNG7mEqCS/+UO/dOKPnWJJyxUsEMvUKnq3Q== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 29 Apr 2025 11:49:08 +0200 Message-Id: Subject: Re: [PATCH RFC bpf-next 3/4] bpf/selftests: add tests to validate proper arguments alignment on ARM64 From: =?utf-8?q?Alexis_Lothor=C3=A9?= To: =?utf-8?q?Alexis_Lothor=C3=A9?= , "Eduard Zingerman" Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "John Fastabend" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Puranjay Mohan" , "Xu Kuohai" , "Catalin Marinas" , "Will Deacon" , "Mykola Lysenko" , "Shuah Khan" , "Maxime Coquelin" , "Alexandre Torgue" , "Florent Revest" , "Bastien Curutchet" , , "Thomas Petazzoni" , , , , , X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250411-many_args_arm64-v1-0-0a32fe72339e@bootlin.com> <20250411-many_args_arm64-v1-3-0a32fe72339e@bootlin.com> <3a16fae0346d4f733fb1a67ae6420d8bf935dbd8.camel@gmail.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieefhedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkuffhvfevofhfjgesthhqredtredtjeenucfhrhhomheptehlvgigihhsucfnohhthhhorhoruceorghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeetudfgvefhveeugeegudethffgvefhleetgfeijeejieejjeevgedtheegfeekhfenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepfedtpdhrtghpthhtoheprghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepvgguugihiiekjeesghhmrghilhdrtghomhdprhgtphhtthhopegrshhtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegurghnihgvlhesihhoghgvrghrsghogidrnhgvthdprhgtphhtthhopehjohhhnhdrfhgrshhtr ggsvghnugesghhmrghilhdrtghomhdprhgtphhtthhopegrnhgurhhiiheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhgrrhhtihhnrdhlrghusehlihhnuhigrdguvghvpdhrtghpthhtohepshhonhhgsehkvghrnhgvlhdrohhrgh X-GND-Sasl: alexis.lothore@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250429_024914_468300_6DF37DDA X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon Apr 28, 2025 at 10:41 PM CEST, Alexis Lothor=C3=A9 wrote: > On Mon Apr 28, 2025 at 6:52 PM CEST, Eduard Zingerman wrote: >> Alexis Lothor=C3=A9 writes: > If things really behaved correctly, f would not have the correct value bu= t > would still be handled as a 16 bytes value, so the test would not fail wi= th > "actual 35 !=3D 43", but something like "actual > 27254487904906932132179118915584 !=3D 43" (43 << 64 | 35) I guess. I stil= l > need to sort this out. And so indeed, the broken value is a big one: (gdb) p skel->bss->t11_f $4 =3D 793209995169510719523 (gdb) p/x skel->bss->t11_f $5 =3D 0x2b0000000000000023 (gdb) But we see the 35 (0x23) value in the error log because the formatters used= in ASSERT_EQ truncate the actual value. Alexis --=20 Alexis Lothor=C3=A9, Bootlin Embedded Linux and Kernel engineering https://bootlin.com