* [PATCH 0/3] Fix the Rockchip PinePhone Pro DTS warnings.
@ 2025-06-17 22:31 Olivier Benjamin
2025-06-17 22:32 ` [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro Olivier Benjamin
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Olivier Benjamin @ 2025-06-17 22:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, Olivier Benjamin
Small fixes to the PinePhone Pro DTS to fit bindings and
suppress warnings at build.
Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
---
Olivier Benjamin (3):
arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro
arm64: dts: rockchip: Fix the mipi port definition for RK3399
arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
---
--
Olivier Benjamin <olivier.benjamin@bootlin.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro 2025-06-17 22:31 [PATCH 0/3] Fix the Rockchip PinePhone Pro DTS warnings Olivier Benjamin @ 2025-06-17 22:32 ` Olivier Benjamin 2025-06-18 13:54 ` Diederik de Haas 2025-06-17 22:32 ` [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 Olivier Benjamin 2025-06-17 22:32 ` [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel Olivier Benjamin 2 siblings, 1 reply; 10+ messages in thread From: Olivier Benjamin @ 2025-06-17 22:32 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, Olivier Benjamin As documented in its bindings, the compatible for the Himax HX8394 MIPI-DSI LCD panel controller is in 2 parts. The PinePhone Pro DTS currently only specifies the first part of the compatible, generating a warning. Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 04ba4c4565d0a205e2e46d7535c6a3190993621d..5ebc380a24df86ba7172b0950b89cac56b61c507 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -479,7 +479,7 @@ mipi_out_panel: endpoint { }; panel@0 { - compatible = "hannstar,hsd060bhw4"; + compatible = "hannstar,hsd060bhw4", "himax,hx8394"; reg = <0>; backlight = <&backlight>; reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; -- 2.49.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro 2025-06-17 22:32 ` [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro Olivier Benjamin @ 2025-06-18 13:54 ` Diederik de Haas 2025-06-18 14:11 ` Olivier Benjamin 0 siblings, 1 reply; 10+ messages in thread From: Diederik de Haas @ 2025-06-18 13:54 UTC (permalink / raw) To: Olivier Benjamin, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1369 bytes --] On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: > As documented in its bindings, the compatible for the Himax HX8394 > MIPI-DSI LCD panel controller is in 2 parts. > The PinePhone Pro DTS currently only specifies the first part of the > compatible, generating a warning. > > Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 04ba4c4565d0a205e2e46d7535c6a3190993621d..5ebc380a24df86ba7172b0950b89cac56b61c507 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -479,7 +479,7 @@ mipi_out_panel: endpoint { > }; > > panel@0 { > - compatible = "hannstar,hsd060bhw4"; > + compatible = "hannstar,hsd060bhw4", "himax,hx8394"; > reg = <0>; > backlight = <&backlight>; > reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; Reviewed-by: Diederik de Haas <didi.debian@cknow.org> But I'd actually suggest to combine it with patch 3 and use that opportunity to also fix the property sorting, so you'd get 1 patch which fixes all of the panel issues. Cheers, Diederik [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro 2025-06-18 13:54 ` Diederik de Haas @ 2025-06-18 14:11 ` Olivier Benjamin 0 siblings, 0 replies; 10+ messages in thread From: Olivier Benjamin @ 2025-06-18 14:11 UTC (permalink / raw) To: Diederik de Haas, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 6/18/25 15:54, Diederik de Haas wrote: > On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: >> As documented in its bindings, the compatible for the Himax HX8394 >> MIPI-DSI LCD panel controller is in 2 parts. >> The PinePhone Pro DTS currently only specifies the first part of the >> compatible, generating a warning. >> >> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> >> --- >> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> index 04ba4c4565d0a205e2e46d7535c6a3190993621d..5ebc380a24df86ba7172b0950b89cac56b61c507 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> @@ -479,7 +479,7 @@ mipi_out_panel: endpoint { >> }; >> >> panel@0 { >> - compatible = "hannstar,hsd060bhw4"; >> + compatible = "hannstar,hsd060bhw4", "himax,hx8394"; >> reg = <0>; >> backlight = <&backlight>; >> reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; > > Reviewed-by: Diederik de Haas <didi.debian@cknow.org> > Thanks for the review. > But I'd actually suggest to combine it with patch 3 and use that > opportunity to also fix the property sorting, so you'd get 1 patch which > fixes all of the panel issues. > Makes sense, I'll integrate your suggestions from the other 2 patches, fix the property sorting, and squash the fixes into 1 commit/patch in v2. > Cheers, > Diederik -- Olivier Benjamin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 2025-06-17 22:31 [PATCH 0/3] Fix the Rockchip PinePhone Pro DTS warnings Olivier Benjamin 2025-06-17 22:32 ` [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro Olivier Benjamin @ 2025-06-17 22:32 ` Olivier Benjamin 2025-06-18 13:50 ` Diederik de Haas 2025-06-17 22:32 ` [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel Olivier Benjamin 2 siblings, 1 reply; 10+ messages in thread From: Olivier Benjamin @ 2025-06-17 22:32 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, Olivier Benjamin The RK3399's MIPI DSI has 2 ports: in an out. The definition of the port property necessitates the value of #address-cells to be 1. Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 5ebc380a24df86ba7172b0950b89cac56b61c507..5a7341fb6bcb0613af6f3ac31d99355a0f890e89 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -468,7 +468,7 @@ &mipi_dsi { ports { mipi_out: port@1 { - #address-cells = <0>; + #address-cells = <1>; #size-cells = <0>; reg = <1>; -- 2.49.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 2025-06-17 22:32 ` [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 Olivier Benjamin @ 2025-06-18 13:50 ` Diederik de Haas 2025-06-18 14:14 ` Olivier Benjamin 0 siblings, 1 reply; 10+ messages in thread From: Diederik de Haas @ 2025-06-18 13:50 UTC (permalink / raw) To: Olivier Benjamin, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2432 bytes --] Hi (again), On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: > The RK3399's MIPI DSI has 2 ports: in an out. The definition of > the port property necessitates the value of #address-cells to be 1. > > Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 5ebc380a24df86ba7172b0950b89cac56b61c507..5a7341fb6bcb0613af6f3ac31d99355a0f890e89 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -468,7 +468,7 @@ &mipi_dsi { > > ports { > mipi_out: port@1 { > - #address-cells = <0>; > + #address-cells = <1>; > #size-cells = <0>; > reg = <1>; > In rk3399-base.dtsi there is already a definition for mipi-in and mipi-out. AFAICT what this change does is require a reg property on the endpoint and I don't think that's correct. It seems to me that all you need is a mipi_out_panel definition. So what I came up with is this: ```sh $ git diff diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 04ba4c4565d0..b175aeed99e2 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -466,18 +466,6 @@ &mipi_dsi { status = "okay"; clock-master; - ports { - mipi_out: port@1 { - #address-cells = <0>; - #size-cells = <0>; - reg = <1>; - - mipi_out_panel: endpoint { - remote-endpoint = <&mipi_in_panel>; - }; - }; - }; - panel@0 { compatible = "hannstar,hsd060bhw4"; reg = <0>; @@ -495,6 +483,12 @@ mipi_in_panel: endpoint { }; }; +&mipi_out { + mipi_out_panel: endpoint { + remote-endpoint = <&mipi_in_panel>; + }; +}; + &pmu_io_domains { pmu1830-supply = <&vcc_1v8>; status = "okay"; ``` I don't have a PPP so I can't verify it, but ``make CHECK_DTBS=y W=1 rockchip/rk3399-pinephone-pro.dtb`` no longer reports issues wrt dsi@ff960000 (after I also fixed the panel compatible like in patch 1 and added a LCD1_RST pinctrl definition as indicated in my reply to patch 3). Cheers, Diederik [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 2025-06-18 13:50 ` Diederik de Haas @ 2025-06-18 14:14 ` Olivier Benjamin 0 siblings, 0 replies; 10+ messages in thread From: Olivier Benjamin @ 2025-06-18 14:14 UTC (permalink / raw) To: Diederik de Haas, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 6/18/25 15:50, Diederik de Haas wrote: > Hi (again), > Hello again, I appreciate you taking the time! > On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: >> The RK3399's MIPI DSI has 2 ports: in an out. The definition of >> the port property necessitates the value of #address-cells to be 1. >> >> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> >> --- >> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> index 5ebc380a24df86ba7172b0950b89cac56b61c507..5a7341fb6bcb0613af6f3ac31d99355a0f890e89 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> @@ -468,7 +468,7 @@ &mipi_dsi { >> >> ports { >> mipi_out: port@1 { >> - #address-cells = <0>; >> + #address-cells = <1>; >> #size-cells = <0>; >> reg = <1>; >> > > In rk3399-base.dtsi there is already a definition for mipi-in and > mipi-out. AFAICT what this change does is require a reg property on the > endpoint and I don't think that's correct. > Those definitions do indeed exist in the base DTSI. > It seems to me that all you need is a mipi_out_panel definition. > So what I came up with is this: > > ```sh > $ git diff > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 04ba4c4565d0..b175aeed99e2 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -466,18 +466,6 @@ &mipi_dsi { > status = "okay"; > clock-master; > > - ports { > - mipi_out: port@1 { > - #address-cells = <0>; > - #size-cells = <0>; > - reg = <1>; > - > - mipi_out_panel: endpoint { > - remote-endpoint = <&mipi_in_panel>; > - }; > - }; > - }; > - > panel@0 { > compatible = "hannstar,hsd060bhw4"; > reg = <0>; > @@ -495,6 +483,12 @@ mipi_in_panel: endpoint { > }; > }; > > +&mipi_out { > + mipi_out_panel: endpoint { > + remote-endpoint = <&mipi_in_panel>; > + }; > +}; > + > &pmu_io_domains { > pmu1830-supply = <&vcc_1v8>; > status = "okay"; > ``` > Thanks for the suggestion, that looks like it might actually solve the issue. > I don't have a PPP so I can't verify it, but ``make CHECK_DTBS=y W=1 > rockchip/rk3399-pinephone-pro.dtb`` no longer reports issues wrt > dsi@ff960000 (after I also fixed the panel compatible like in patch 1 > and added a LCD1_RST pinctrl definition as indicated in my reply to > patch 3). > I'll test on my PPP and report back in v2. > Cheers, > Diederik -- Olivier Benjamin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel 2025-06-17 22:31 [PATCH 0/3] Fix the Rockchip PinePhone Pro DTS warnings Olivier Benjamin 2025-06-17 22:32 ` [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro Olivier Benjamin 2025-06-17 22:32 ` [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 Olivier Benjamin @ 2025-06-17 22:32 ` Olivier Benjamin 2025-06-18 12:12 ` Diederik de Haas 2 siblings, 1 reply; 10+ messages in thread From: Olivier Benjamin @ 2025-06-17 22:32 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, Olivier Benjamin The MIPI panel definition in the PinePhone Pro DTS includes a "pinctrl-names" property, which is unused in the absence of pinctrl-0. Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> --- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -485,7 +485,6 @@ panel@0 { reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; vcc-supply = <&vcc2v8_lcd>; iovcc-supply = <&vcc1v8_lcd>; - pinctrl-names = "default"; port { mipi_in_panel: endpoint { -- 2.49.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel 2025-06-17 22:32 ` [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel Olivier Benjamin @ 2025-06-18 12:12 ` Diederik de Haas 2025-06-18 13:39 ` Olivier Benjamin 0 siblings, 1 reply; 10+ messages in thread From: Diederik de Haas @ 2025-06-18 12:12 UTC (permalink / raw) To: Olivier Benjamin, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1129 bytes --] Hi, On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: > The MIPI panel definition in the PinePhone Pro DTS includes a > "pinctrl-names" property, which is unused in the absence of pinctrl-0. > > Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> > --- > arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -485,7 +485,6 @@ panel@0 { > reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; > vcc-supply = <&vcc2v8_lcd>; > iovcc-supply = <&vcc1v8_lcd>; > - pinctrl-names = "default"; Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in pinctrl-0? (See page 11 and 16 of the schematics) Cheers, Diederik > > port { > mipi_in_panel: endpoint { [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel 2025-06-18 12:12 ` Diederik de Haas @ 2025-06-18 13:39 ` Olivier Benjamin 0 siblings, 0 replies; 10+ messages in thread From: Olivier Benjamin @ 2025-06-18 13:39 UTC (permalink / raw) To: Diederik de Haas, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner Cc: Thomas Petazzoni, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel On 6/18/25 14:12, Diederik de Haas wrote: > Hi, > Hello Diederik, > On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: >> The MIPI panel definition in the PinePhone Pro DTS includes a >> "pinctrl-names" property, which is unused in the absence of pinctrl-0. >> >> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com> >> --- >> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> @@ -485,7 +485,6 @@ panel@0 { >> reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; >> vcc-supply = <&vcc2v8_lcd>; >> iovcc-supply = <&vcc1v8_lcd>; >> - pinctrl-names = "default"; > > Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in > pinctrl-0? (See page 11 and 16 of the schematics) > That is a very fair question. I had simply missed that signal. I'll get right on that, thanks for the suggestion! > Cheers, > Diederik >> >> port { >> mipi_in_panel: endpoint { > -- Olivier Benjamin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-06-18 19:11 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-17 22:31 [PATCH 0/3] Fix the Rockchip PinePhone Pro DTS warnings Olivier Benjamin 2025-06-17 22:32 ` [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro Olivier Benjamin 2025-06-18 13:54 ` Diederik de Haas 2025-06-18 14:11 ` Olivier Benjamin 2025-06-17 22:32 ` [PATCH 2/3] arm64: dts: rockchip: Fix the mipi port definition for RK3399 Olivier Benjamin 2025-06-18 13:50 ` Diederik de Haas 2025-06-18 14:14 ` Olivier Benjamin 2025-06-17 22:32 ` [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel Olivier Benjamin 2025-06-18 12:12 ` Diederik de Haas 2025-06-18 13:39 ` Olivier Benjamin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).