From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF1EC5517A for ; Mon, 9 Nov 2020 05:47:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE04021534 for ; Mon, 9 Nov 2020 05:47:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="URsnGwZo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="V+TtallJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE04021534 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4lQFoIov4b8oGGWD3LQqj+QIvetf4kIly9q91XtGfmY=; b=URsnGwZoWgM3hT6nl/PKOSexv R80DZhHuSjNAwtCNfDQpOSgTkQB/y/tZXtaENPsM9dRV4QFxTBzaw90HXotlIxcwTXr6Fh1W31G/u ZGzk5nI4NLaxhDlI+QI+bybYbYtt07vOM3gWgO24G5Xf+wyCX0TpIxxBDB6Adwi4hbVueGFR7bkkH FVzCyYIUgzS5Ktn3qUwaNfzvoZXg1c769Vk0Fxx4HGR03i3tt6xdA0KlefHWvQd9SgFRtyrUmqqBv VbNrwRMMeTAQoTLU7XX0bzqBet+rfT1pqdEPbWYXb0AKJQOpQCFdAe8B9PaMlygewzT344tPjC7Ek F7tTZ7H9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbzzz-0003sb-Vd; Mon, 09 Nov 2020 05:45:52 +0000 Received: from mail-eopbgr80079.outbound.protection.outlook.com ([40.107.8.79] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbzzw-0003s6-Bt for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 05:45:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEpxucKjGNcyJG5HBRJ8zTSc6ih7yw2JJluMR04v7tUUOPiFGvIOIGVgHGP7NFE34G1TlYU4/lb5JBy6/sypjg3ANm8jOkDACw4TUEz+LJ8e8KHEC+4B/5DP/vogVAOP2/76G/L0kUMpQtyr475GfpAFk4WU/2i5v00Oo6GmBd7ZD9MKb3jWcp7ZCJxxkkVrbH0LuDHxMOs2pwzVSggInPzuZl5syMgplENZ5cnfun/5S3M/6vADzfAd4PAf5Ahc/5t0lztcB6vWWdyKvI3WWaomt3viWTNpbU/nam7t4p1Ux+Mgx8sXkHgmHSl9SmUCo2EmhXYwUwWyNtpK/oiMxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8O8SGzaH8XdB8f7DAtBetUN1dp+UHJ91I3BKmVRBPQ=; b=KaX9FFujoI45VXUyV7tSxK91OF2VJfpg6LZtBvEORdWOS9oQGKpWTb79lxmyavvD91n/Nw18NA8yeoqmLjCq2S/giIBAdnmXKs0BF5+ZnQVdORnKul59d6ilMyE1xvsFZbZ6ga4uJNi4LM+tVwkNcWb3I3iskWpJehsAb1kZJozao5tCu/e3qv7l/lAURFzr4kn2j0iNyYm5+EFN6cYUSbKuzxQuGeIMtyEqrVAdiZd2WX+/dfPOTDnvJXi+TsbiQfiiOwQxNUcmfHNslowzUSxojynUETfv/VCI9v075lQZ2+u3/k7EWQL49zhsNdVuo3J1gyZXboo4M9XSxJgppg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8O8SGzaH8XdB8f7DAtBetUN1dp+UHJ91I3BKmVRBPQ=; b=V+TtallJ2T1skPSMYRStqTt95rwSlrdBUWgAvlZLy7fQgW8K4/CmlRu94dltGLNteuQNnOZbYazTzq3n0XsqHGj3VIt1RAhFv7kgsFlVmqSSyhFAPw1XC6cpfErrCyWRKS6KpEGPigjuCi8H9dGBdQ5vDDymb+9QgCucqEpWTw8= Received: from DBBPR04MB7930.eurprd04.prod.outlook.com (2603:10a6:10:1ea::12) by DBBPR04MB7787.eurprd04.prod.outlook.com (2603:10a6:10:1e3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.22; Mon, 9 Nov 2020 05:45:43 +0000 Received: from DBBPR04MB7930.eurprd04.prod.outlook.com ([fe80::681b:7b29:32bf:d4f]) by DBBPR04MB7930.eurprd04.prod.outlook.com ([fe80::681b:7b29:32bf:d4f%7]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 05:45:43 +0000 From: Jacky Bai To: Abel Vesa , Mike Turquette , Stephen Boyd , Adam Ford , Marek Vasut , Lucas Stach , Rob Herring , Shawn Guo , Sascha Hauer , Fabio Estevam , Anson Huang , Peng Fan , Aisheng Dong Subject: RE: [PATCH v5 10/14] clk: imx: Add generic blk-ctl driver Thread-Topic: [PATCH v5 10/14] clk: imx: Add generic blk-ctl driver Thread-Index: AQHWsdMtW7/mWMYbfES8MUsWPsLRJ6m/Uplg Date: Mon, 9 Nov 2020 05:45:43 +0000 Message-ID: References: <1604402306-5348-1-git-send-email-abel.vesa@nxp.com> <1604402306-5348-11-git-send-email-abel.vesa@nxp.com> In-Reply-To: <1604402306-5348-11-git-send-email-abel.vesa@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 020e4d48-4769-4f71-714d-08d88472b312 x-ms-traffictypediagnostic: DBBPR04MB7787: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bWO+nhsmexbkEpJA+c8qnZYCFWVGk7KGH3VkFzGiHcbzeBE6A1ZG/pkamA0wg/3Piq7KnycxnVDrNxddvjKn/E3uIXnafoykEy4ulCHwXkGFx1cw7FwUvwcQGFkqzTtb7CoXV5VEa9qvFgxKkLViteDjsNfokxEkSCsO+C/GEbmo4FjY+z6R6eIrIRnhBR3jsLc8zX4VA5EvRkEI3lX0Ojz7d9egZGWDDgVjCOYtX4crx7ixBIIs0sgqft8iB/Mm5Fg3L5kXUtArnFRpeaoIEpGAYqAmmbwYRAQwuPfWhWGLebzGoPF7QeW5GAJYboaI9Ko/N3YlwwiV8fDg59eBO8jAgwLsqOujv93tIyWDqmPRuhWd7/J1W1ueUpus4pitkziIQCm1uSZ442U3j67bAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR04MB7930.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(8936002)(83380400001)(6636002)(4326008)(86362001)(2906002)(110136005)(8676002)(26005)(316002)(7696005)(55016002)(64756008)(66556008)(66476007)(66946007)(66446008)(33656002)(54906003)(478600001)(53546011)(6506007)(76116006)(71200400001)(9686003)(30864003)(5660300002)(52536014)(7416002)(186003)(41533002)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +8xbK/D/YcmLkadH7X6JcgV5CliqLR5gKrW+B9Cjh5q0UJNBDesSbNCw9jKDGlJbhb7qgF9DdeM9ySS9fFE/G7eHJ13PL5cKXF35IgGgW3nUQ6NfJXAm5tjtr5aoWn4cViviDhpwN+xuuQa92gDNJuJu7GaFk47JUiq1VsP9d193JpEWoPtQz4dtY6jRZKmXPiiyhi/7oBZYmC4ztARuCSuzqBeo9u6hpiA8PtLeriw+iRf5QV/RblRnDa9+Pg48C2v/86l7a6EN6SPZ0q8QsKGI+6YMhr/mwxUz6NRuIyWLR+aGe5ImqbUfpZYDQfXL+51bDFXyhIvzjx44SvK1pFQnaiar4rI5ENaXQbbPKdDXO/pdxCG8R/NtGjyX4OuRGzg1/Ji1qPgDwThxT2pQgsGMhCqsVogASByu8HcYEff1qlDUbg0ybOuCHKzBs4x46ZrofeK4qAeLrav7z7ZLOStw9ZFrkgvok8Bzrpv4FHxRTWm90Ij+k2yjhqA5b9MkKU16XXA+aLMS0d+k5VOwVO30gJCyjyEYYkmPhb17/raR/FM0DyL3WwH1etHEq4rNKs0/2PRN3G42tpz/Bl7GctubZejPEfARHEeVQD1tD1ERHf9TKQdFI5TmeqilUAbozlsLjC0B/tCsyEpa+VcPlQ== MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB7930.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 020e4d48-4769-4f71-714d-08d88472b312 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 05:45:43.6880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lk2eeBxzzbWchK8DLq1YaTAaVb70T8K/n+McgBURchh8fsZf8p3IlFiRJckUOB2wSTpXKONqi3ou3LTrRV50LA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7787 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_004548_996546_3CF155C3 X-CRM114-Status: GOOD ( 30.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Abel Vesa , Linux Kernel Mailing List , dl-linux-imx , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Abel Vesa [mailto:abel.vesa@nxp.com] > Sent: Tuesday, November 3, 2020 7:18 PM > To: Mike Turquette ; Stephen Boyd > ; Adam Ford ; Marek Vasut > ; Lucas Stach ; Rob > Herring ; Shawn Guo ; Sascha > Hauer ; Fabio Estevam ; > Anson Huang ; Jacky Bai ; Peng > Fan ; Aisheng Dong > Cc: dl-linux-imx ; linux-arm-kernel@lists.infradead.org; > Linux Kernel Mailing List ; > linux-clk@vger.kernel.org; devicetree@vger.kernel.org; Abel Vesa > > Subject: [PATCH v5 10/14] clk: imx: Add generic blk-ctl driver > > The i.MX8MP platform introduces a new type of IP which is called BLK_CTL in > RM and usually is comprised of some GPRs that are considered too generic to > be part of any dedicated IP from that specific subsystem. > > In general, some of the GPRs have some clock bits, some have reset bits, so in > order to be able to use the imx clock API, this needs to be in a clock driver. > From there it can use the reset controller API and leave the rest to the syscon. > >From the test I did internally, this blk ctrl implementation will have system deadlock risk due to the clock prepare mutex. Please make sure it can works without deadlock. BR Jacky Bai > Signed-off-by: Abel Vesa > --- > drivers/clk/imx/Makefile | 2 +- > drivers/clk/imx/clk-blk-ctl.c | 302 > ++++++++++++++++++++++++++++++++++++++++++ > drivers/clk/imx/clk-blk-ctl.h | 80 +++++++++++ > 3 files changed, 383 insertions(+), 1 deletion(-) create mode 100644 > drivers/clk/imx/clk-blk-ctl.c create mode 100644 > drivers/clk/imx/clk-blk-ctl.h > > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index > dd6a737..3d6d9cb 100644 > --- a/drivers/clk/imx/Makefile > +++ b/drivers/clk/imx/Makefile > @@ -23,7 +23,7 @@ obj-$(CONFIG_MXC_CLK) += mxc-clk.o > > obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o > obj-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o > -obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o > +obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o clk-blk-ctl.o > obj-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o > > obj-$(CONFIG_MXC_CLK_SCU) += clk-imx-scu.o clk-imx-lpcg-scu.o diff --git > a/drivers/clk/imx/clk-blk-ctl.c b/drivers/clk/imx/clk-blk-ctl.c new file mode > 100644 index 00000000..9ac0ed0 > --- /dev/null > +++ b/drivers/clk/imx/clk-blk-ctl.c > @@ -0,0 +1,302 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright 2020 NXP. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "clk.h" > +#include "clk-blk-ctl.h" > + > +struct imx_reset_hw { > + u32 offset; > + u32 shift; > + u32 mask; > + unsigned long asserted; > +}; > + > +struct imx_pm_safekeep_info { > + uint32_t *regs_values; > + uint32_t *regs_offsets; > + uint32_t regs_num; > +}; > + > +struct imx_blk_ctl_drvdata { > + void __iomem *base; > + struct reset_controller_dev rcdev; > + struct imx_reset_hw *rst_hws; > + struct imx_pm_safekeep_info pm_info; > + > + spinlock_t lock; > +}; > + > +static void __maybe_unused imx_blk_ctl_read_write(struct device *dev, > + bool write) > +{ > + struct imx_blk_ctl_drvdata *drvdata = dev_get_drvdata(dev); > + struct imx_pm_safekeep_info *pm_info = &drvdata->pm_info; > + void __iomem *base = drvdata->base; > + int i; > + > + if (!pm_info->regs_num) > + return; > + > + for (i = 0; i < pm_info->regs_num; i++) { > + u32 offset = pm_info->regs_offsets[i]; > + > + if (write) > + writel(pm_info->regs_values[i], base + offset); > + else > + pm_info->regs_values[i] = readl(base + offset); > + } > + > +} > + > +static int __maybe_unused imx_blk_ctl_runtime_suspend(struct device > +*dev) { > + imx_blk_ctl_read_write(dev, false); > + > + return 0; > +} > + > +static int __maybe_unused imx_blk_ctl_runtime_resume(struct device > +*dev) { > + imx_blk_ctl_read_write(dev, true); > + > + return 0; > +} > + > +const struct dev_pm_ops imx_blk_ctl_pm_ops = { > + SET_RUNTIME_PM_OPS(imx_blk_ctl_runtime_suspend, > + imx_blk_ctl_runtime_resume, NULL) > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > + pm_runtime_force_resume) > +}; > +EXPORT_SYMBOL_GPL(imx_blk_ctl_pm_ops); > + > +static int imx_blk_ctl_reset_set(struct reset_controller_dev *rcdev, > + unsigned long id, bool assert) > +{ > + struct imx_blk_ctl_drvdata *drvdata = container_of(rcdev, > + struct imx_blk_ctl_drvdata, rcdev); > + unsigned int offset = drvdata->rst_hws[id].offset; > + unsigned int shift = drvdata->rst_hws[id].shift; > + unsigned int mask = drvdata->rst_hws[id].mask; > + void __iomem *reg_addr = drvdata->base + offset; > + unsigned long flags; > + u32 reg; > + > + if (!assert && !test_bit(1, &drvdata->rst_hws[id].asserted)) > + return -ENODEV; > + > + if (assert && !test_and_set_bit(1, &drvdata->rst_hws[id].asserted)) > + pm_runtime_get_sync(rcdev->dev); > + > + spin_lock_irqsave(&drvdata->lock, flags); > + > + reg = readl(reg_addr); > + if (assert) > + writel(reg & ~(mask << shift), reg_addr); > + else > + writel(reg | (mask << shift), reg_addr); > + > + spin_unlock_irqrestore(&drvdata->lock, flags); > + > + if (!assert && test_and_clear_bit(1, &drvdata->rst_hws[id].asserted)) > + pm_runtime_put(rcdev->dev); > + > + return 0; > +} > + > +static int imx_blk_ctl_reset_assert(struct reset_controller_dev *rcdev, > + unsigned long id) > +{ > + return imx_blk_ctl_reset_set(rcdev, id, true); } > + > +static int imx_blk_ctl_reset_deassert(struct reset_controller_dev *rcdev, > + unsigned long id) > +{ > + return imx_blk_ctl_reset_set(rcdev, id, false); } > + > +static const struct reset_control_ops imx_blk_ctl_reset_ops = { > + .assert = imx_blk_ctl_reset_assert, > + .deassert = imx_blk_ctl_reset_deassert, > +}; > + > +static int imx_blk_ctl_register_reset_controller(struct device *dev) { > + const struct imx_blk_ctl_dev_data *dev_data = > of_device_get_match_data(dev); > + struct imx_blk_ctl_drvdata *drvdata = dev_get_drvdata(dev); > + int max = dev_data->resets_max; > + struct imx_reset_hw *hws; > + int i; > + > + spin_lock_init(&drvdata->lock); > + > + drvdata->rcdev.owner = THIS_MODULE; > + drvdata->rcdev.nr_resets = max; > + drvdata->rcdev.ops = &imx_blk_ctl_reset_ops; > + drvdata->rcdev.of_node = dev->of_node; > + drvdata->rcdev.dev = dev; > + > + drvdata->rst_hws = devm_kcalloc(dev, max, sizeof(struct imx_reset_hw), > + GFP_KERNEL); > + hws = drvdata->rst_hws; > + > + for (i = 0; i < dev_data->hws_num; i++) { > + struct imx_blk_ctl_hw *hw = &dev_data->hws[i]; > + > + if (hw->type != BLK_CTL_RESET) > + continue; > + > + hws[hw->id].offset = hw->offset; > + hws[hw->id].shift = hw->shift; > + hws[hw->id].mask = hw->mask; > + } > + > + return devm_reset_controller_register(dev, &drvdata->rcdev); } static > +struct clk_hw *imx_blk_ctl_register_one_clock(struct device *dev, > + struct imx_blk_ctl_hw *hw) > +{ > + struct imx_blk_ctl_drvdata *drvdata = dev_get_drvdata(dev); > + void __iomem *base = drvdata->base; > + struct clk_hw *clk_hw = NULL; > + > + switch (hw->type) { > + case BLK_CTL_CLK_MUX: > + clk_hw = imx_dev_clk_hw_mux_flags(dev, hw->name, > + base + hw->offset, > + hw->shift, hw->width, > + hw->parents, > + hw->parents_count, > + hw->flags); > + break; > + case BLK_CTL_CLK_GATE: > + clk_hw = imx_dev_clk_hw_gate(dev, hw->name, hw->parents, > + base + hw->offset, hw->shift); > + break; > + case BLK_CTL_CLK_SHARED_GATE: > + clk_hw = imx_dev_clk_hw_gate_shared(dev, hw->name, > + hw->parents, > + base + hw->offset, > + hw->shift, > + hw->shared_count); > + break; > + case BLK_CTL_CLK_PLL14XX: > + clk_hw = imx_dev_clk_hw_pll14xx(dev, hw->name, hw->parents, > + base + hw->offset, hw->pll_tbl); > + break; > + }; > + > + return clk_hw; > +} > + > +static int imx_blk_ctl_register_clock_controller(struct device *dev) { > + const struct imx_blk_ctl_dev_data *dev_data = > of_device_get_match_data(dev); > + struct clk_hw_onecell_data *clk_hw_data; > + struct clk_hw **hws; > + int i; > + > + clk_hw_data = devm_kzalloc(dev, struct_size(clk_hw_data, hws, > + dev_data->hws_num), GFP_KERNEL); > + if (WARN_ON(!clk_hw_data)) > + return -ENOMEM; > + > + clk_hw_data->num = dev_data->clocks_max; > + hws = clk_hw_data->hws; > + > + for (i = 0; i < dev_data->hws_num; i++) { > + struct imx_blk_ctl_hw *hw = &dev_data->hws[i]; > + > + if (hw->type == BLK_CTL_RESET) > + continue; > + > + hws[hw->id] = imx_blk_ctl_register_one_clock(dev, hw); > + } > + > + imx_check_clk_hws(hws, dev_data->clocks_max); > + > + return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get, > + clk_hw_data); > +} > + > +static int imx_blk_ctl_init_runtime_pm_safekeeping(struct device *dev) > +{ > + const struct imx_blk_ctl_dev_data *dev_data = > of_device_get_match_data(dev); > + struct imx_blk_ctl_drvdata *drvdata = dev_get_drvdata(dev); > + struct imx_pm_safekeep_info *pm_info = &drvdata->pm_info; > + u32 regs_num = dev_data->pm_runtime_saved_regs_num; > + const u32 *regs_offsets = dev_data->pm_runtime_saved_regs; > + > + if (!dev_data->pm_runtime_saved_regs_num) > + return 0; > + > + pm_info->regs_values = devm_kzalloc(dev, > + sizeof(u32) * regs_num, > + GFP_KERNEL); > + if (WARN_ON(IS_ERR(pm_info->regs_values))) > + return PTR_ERR(pm_info->regs_values); > + > + pm_info->regs_offsets = kmemdup(regs_offsets, > + regs_num * sizeof(u32), GFP_KERNEL); > + if (WARN_ON(IS_ERR(pm_info->regs_offsets))) > + return PTR_ERR(pm_info->regs_offsets); > + > + pm_info->regs_num = regs_num; > + > + return 0; > +} > + > +int imx_blk_ctl_register(struct platform_device *pdev) { > + struct imx_blk_ctl_drvdata *drvdata; > + struct device *dev = &pdev->dev; > + int ret; > + > + drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > + if (WARN_ON(!drvdata)) > + return -ENOMEM; > + > + drvdata->base = devm_platform_ioremap_resource(pdev, 0); > + if (WARN_ON(IS_ERR(drvdata->base))) > + return PTR_ERR(drvdata->base); > + > + dev_set_drvdata(dev, drvdata); > + > + ret = imx_blk_ctl_init_runtime_pm_safekeeping(dev); > + if (ret) > + return ret; > + > + pm_runtime_get_noresume(dev); > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + > + ret = imx_blk_ctl_register_clock_controller(dev); > + if (ret) { > + pm_runtime_put(dev); > + return ret; > + } > + > + ret = imx_blk_ctl_register_reset_controller(dev); > + > + pm_runtime_put(dev); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(imx_blk_ctl_register); > diff --git a/drivers/clk/imx/clk-blk-ctl.h b/drivers/clk/imx/clk-blk-ctl.h new file > mode 100644 index 00000000..3f14a47 > --- /dev/null > +++ b/drivers/clk/imx/clk-blk-ctl.h > @@ -0,0 +1,80 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __MACH_IMX_CLK_BLK_CTL_H > +#define __MACH_IMX_CLK_BLK_CTL_H > + > +enum imx_blk_ctl_hw_type { > + BLK_CTL_CLK_MUX, > + BLK_CTL_CLK_GATE, > + BLK_CTL_CLK_SHARED_GATE, > + BLK_CTL_CLK_PLL14XX, > + BLK_CTL_RESET, > +}; > + > +struct imx_blk_ctl_hw { > + int type; > + char *name; > + u32 offset; > + u32 shift; > + u32 mask; > + u32 width; > + u32 flags; > + u32 id; > + const void *parents; > + u32 parents_count; > + int *shared_count; > + const struct imx_pll14xx_clk *pll_tbl; }; > + > +struct imx_blk_ctl_dev_data { > + struct imx_blk_ctl_hw *hws; > + u32 hws_num; > + > + u32 clocks_max; > + u32 resets_max; > + > + u32 pm_runtime_saved_regs_num; > + u32 pm_runtime_saved_regs[]; > +}; > + > +#define IMX_BLK_CTL(_type, _name, _id, _offset, _shift, _width, _mask, > _parents, _parents_count, _flags, sh_count, _pll_tbl) \ > + { \ > + .type = _type, \ > + .name = _name, \ > + .id = _id, \ > + .offset = _offset, \ > + .shift = _shift, \ > + .width = _width, \ > + .mask = _mask, \ > + .parents = _parents, \ > + .parents_count = _parents_count, \ > + .flags = _flags, \ > + .shared_count = sh_count, \ > + .pll_tbl = _pll_tbl, \ > + } > + > +#define IMX_BLK_CTL_CLK_MUX(_name, _id, _offset, _shift, _width, > _parents) \ > + IMX_BLK_CTL(BLK_CTL_CLK_MUX, _name, _id, _offset, _shift, _width, 0, > +_parents, ARRAY_SIZE(_parents), 0, NULL, NULL) > + > +#define IMX_BLK_CTL_CLK_MUX_FLAGS(_name, _id, _offset, _shift, _width, > _parents, _flags) \ > + IMX_BLK_CTL(BLK_CTL_CLK_MUX, _name, _id, _offset, _shift, _width, 0, > +_parents, ARRAY_SIZE(_parents), _flags, NULL, NULL) > + > +#define IMX_BLK_CTL_CLK_GATE(_name, _id, _offset, _shift, _parents) \ > + IMX_BLK_CTL(BLK_CTL_CLK_GATE, _name, _id, _offset, _shift, 1, 0, > +_parents, 1, 0, NULL, NULL) > + > +#define IMX_BLK_CTL_CLK_SHARED_GATE(_name, _id, _offset, _shift, > _parents, sh_count) \ > + IMX_BLK_CTL(BLK_CTL_CLK_SHARED_GATE, _name, _id, _offset, _shift, > 1, > +0, _parents, 1, 0, sh_count, NULL) > + > +#define IMX_BLK_CTL_CLK_PLL14XX(_name, _id, _offset, _parents, _pll_tbl) > \ > + IMX_BLK_CTL(BLK_CTL_CLK_PLL14XX, _name, _id, _offset, 0, 0, 0, > +_parents, 1, 0, NULL, _pll_tbl) > + > +#define IMX_BLK_CTL_RESET(_id, _offset, _shift) \ > + IMX_BLK_CTL(BLK_CTL_RESET, NULL, _id, _offset, _shift, 0, 1, NULL, 0, > +0, NULL, NULL) > + > +#define IMX_BLK_CTL_RESET_MASK(_id, _offset, _shift, mask) \ > + IMX_BLK_CTL(BLK_CTL_RESET, NULL, _id, _offset, _shift, 0, mask, NULL, > +0, 0, NULL, NULL) > + > +extern const struct dev_pm_ops imx_blk_ctl_pm_ops; > + > +int imx_blk_ctl_register(struct platform_device *pdev); > + > +#endif > -- > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel