Re: [RFC PATCH 1/3] dt-bindings: gpu: img: Add AM62P SoC specific compatible

["Michael Walle" <mwalle@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

Hi Andrew,

On Wed Jul 16, 2025 at 6:17 PM CEST, Andrew Davis wrote:
> On 7/16/25 8:47 AM, Michael Walle wrote:
> > The AM62P and the J722S features the same BXS-4 GPU as the J721S2. Add a
> > new SoC specific compatible.
> > 
>
> If the GPU is the same, and the integration is the same, do you really need
> a new compatible?

AFAIK it's good practise to have one to have a base for future SoC
specific quirks. For example, there are differences how that IP was
integrated, i.e. the am62p doesn't have DMA coherency (for this
peripheral), the clock is dedicated and there might be more.

>
> > Signed-off-by: Michael Walle <mwalle@kernel.org>
> > ---
> >   Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > index 4450e2e73b3c..bad3e412a168 100644
> > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > @@ -23,6 +23,7 @@ properties:
> >             - const: img,img-rogue
> >         - items:
> >             - enum:
> > +              - ti,am62p-gpu
>
> There is a check below based on SoC compat:
>
> >  - if:
> >      properties:
> >        compatible:
> >          contains:
> >            enum:
> >              - ti,am62-gpu
> >              - ti,j721s2-gpu
> >    then:
> >      properties:
> >        clocks:
> >          maxItems: 1
>
> If you do add a new SoC specific compatible does this check need updating?

Thanks! Yes probably.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]