Re: [PATCH] arm64: dts: rockchip: Make RK3588 GPU OPP table naming uniform

Diederik de Haas
2025-09-06T11:44:18Z

[-- Attachment #1: Type: text/plain, Size: 2020 bytes --]

Hi,

On Sat Sep 6, 2025 at 12:01 PM CEST, Dragan Simic wrote:
> Unify the naming of the existing GPU OPP table nodes found in the RK3588
> and RK3588J SoC dtsi files with the other SoC's GPU OPP nodes, following
> the more "modern" node naming scheme.

Like we discussed in private (without an agreement), I think it would be
beneficial if the (gpu) opp naming would be made consistent across SoC
series as right now there are several different naming schemes applied.
They're all valid, but inconsistent. And if consistency is improved,
which I like, then let's go 'all the way'?

Cheers,
Diederik

> Fixes: a7b2070505a2 ("arm64: dts: rockchip: Split GPU OPPs of RK3588 and RK3588j")
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-opp.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3588j.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-opp.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-opp.dtsi
> index 0f1a77697351..b5d630d2c879 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-opp.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-opp.dtsi
> @@ -115,7 +115,7 @@ opp-2400000000 {
> };
> };
>
> - gpu_opp_table: opp-table {
> + gpu_opp_table: opp-table-gpu {
> compatible = "operating-points-v2";
>
> opp-300000000 {
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588j.dtsi b/arch/arm64/boot/dts/rockchip/rk3588j.dtsi
> index 9884a5df47df..e1e0e3fc0ca7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588j.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588j.dtsi
> @@ -66,7 +66,7 @@ opp-1608000000 {
> };
> };
>
> - gpu_opp_table: opp-table {
> + gpu_opp_table: opp-table-gpu {
> compatible = "operating-points-v2";
>
> opp-300000000 {
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]