From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74FD2CCD1AA for ; Tue, 21 Oct 2025 12:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jYftyPWe3cSDHOa3crBNXagLfu5+YLZP87koZDXEKHE=; b=Pa8ZbZAToMYxNP4UNlVt+NYIIO W63EokuhXS6JLzdagPPhUpJJwNAx5t55Bv4bTkZx7CrwCDkKz4cGe5MqSZeC/AbXYF3D5pSf19di1 soxR3JVQYZ0Ayv98Q1aV2842WQxY2DuYcE4eQFpWzOmU8QOBFj0fQz4a/nYxBLucewzEfOmWZmsML +KKtEDj8eGMs8IHLyZcBoAhvmOwZSVilX7NflC5Bcts7aTphdphRUWQZYvz3iWb/zK53SOqGUNOKQ 48bNrtq7DY3KVhRXZQJzPOqB6RA6xCcVR+OS/FLwsJclyCnjfOZBVLQcyhYqZCOzNsulKR4Q1C1Fk Dbw+UqhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBBBi-0000000GuM1-1NYe; Tue, 21 Oct 2025 12:10:02 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBBBd-0000000GuJ8-2dlA; Tue, 21 Oct 2025 12:10:01 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id B2AE0C0B88D; Tue, 21 Oct 2025 12:09:34 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3731360680; Tue, 21 Oct 2025 12:09:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9E336102F23E9; Tue, 21 Oct 2025 14:09:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761048593; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jYftyPWe3cSDHOa3crBNXagLfu5+YLZP87koZDXEKHE=; b=AZ06nvrfdkt65l4E235uJTkuujLAFE0Xkr8yMlv8YGs+4Wjxl3cDNrgnC2wekfhdFKRJbx p978H1NRdxMUpJOiFKTjCdI2um+XRjTW5kiMLUBqR8J0FIKF/0630noMdkQ5tTxG2+A3iG 5z+SYTF9YQI2Kqf5cFY5J7mxrPj7RJGbY7dzFj2hWOIjY+oL8pIl7gsj2ke1a4Gbrc/VfF jlZMh+iIoacYmLgyB4ovjesL8k3qgXAxwHguAQanDz0WhDnNO7IDoGaAnG34IFTBjEpU0W sAoLDPQEgCpOCHULSukUf3kb/HqaPCJuyQye8KRi/jTHKU1fRYNuNPbOB6YXLg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Oct 2025 14:09:39 +0200 Message-Id: Cc: "Kever Yang" , "Minas Harutyunyan" , "Alan Stern" , "Louis Chauvet" , =?utf-8?q?Herv=C3=A9_Codina?= , "Thomas Petazzoni" , , , , , , "linux-phy" Subject: Re: [PATCH 0/2] phy: rockchip: inno-usb2: fix gadget mode disconnection after 6 seconds From: "Luca Ceresoli" To: "Luca Ceresoli" , "Vinod Koul" , "Kishon Vijay Abraham I" , "Heiko Stuebner" , "William Wu" X-Mailer: aerc 0.20.1 References: <20250722-rk3308-fix-usb-gadget-phy-disconnect-v1-0-239872f05f17@bootlin.com> In-Reply-To: <20250722-rk3308-fix-usb-gadget-phy-disconnect-v1-0-239872f05f17@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251021_050957_843094_1EA3C75D X-CRM114-Status: GOOD ( 14.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Tue Jul 22, 2025 at 10:43 AM CEST, Luca Ceresoli wrote: > The USB OTG port of the RK3308 exibits a bug when: > > - configured as peripheral, and > - used in gadget mode, and > - the USB cable is connected since before booting > > The symptom is: about 6 seconds after configuring gadget mode the device = is > disconnected and then re-enumerated. This happens only once per boot. > > Investigation showed that in this configuration the charger detection cod= e > turns off the PHY after 6 seconds. Patch 1 avoids this when a cable is > connected (VBUS present). > > After patch 1 the connection is stable but communication stops after 6 > seconds. this is addressed by patch 2. > > The topic had been discussed in [0]. Thanks Alan and Minas for the > discussion and Louis for having found the 1st issue, leading to patch 1. > > [0] https://lore.kernel.org/lkml/20250414185458.7767aabc@booty/ > > Luca > > Signed-off-by: Luca Ceresoli Anything I should do to move forward with this work? These two few-liner patches solve real-world bugs, there is no complaint about them, and both the bug and the solution is explained as clearly as the public documentation allows. FWIW, this series applied cleany on current master (v6.18-rc2-8-g6548d364a3e8). Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com