From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Diederik de Haas" <diederik@cknow-tech.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"Dragan Simic" <dsimic@manjaro.org>,
"Johan Jonker" <jbx6244@gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices
Date: Sun, 26 Oct 2025 18:44:42 +0100 [thread overview]
Message-ID: <DDSFVM1TXN8C.3JNX2M8XX04IF@cknow-tech.com> (raw)
In-Reply-To: <20251026153805.107774-1-diederik@cknow-tech.com>
On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
> The regulator node properties in Pine64 rk3566 devices were formatted
> rather inconsistently. To name a few:
> - 'name' was sometimes put at the top of the list, while at other times
> it was (mostly) sorted in alphabetical order
> - 'always-on' and 'boot-on' were sometimes at the top of the list,
> sometimes not
> - 'state-mem' nodes sometimes had a preceding blank line, as they
> should, but sometimes not
> - other properties seem to have been added to the end of the list, not
> in their alphabetical/natural order
>
> So harmonize the formatting by making all properties sorted
> alphabetically/naturally. And harmonize the formatting of the
> 'state-mem' nodes so they all have a preceding blank line. While at it,
> also fix 2 incorrectly indented nodes.
>
> No functional changes.
I just found some additional ones.
If these changes are considered OK (in principle), then I'll send a v2
at some point.
Cheers,
Diederik
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
> ---
> .../boot/dts/rockchip/rk3566-pinenote.dtsi | 52 +++++++++----------
> .../boot/dts/rockchip/rk3566-pinetab2.dtsi | 29 ++++++++---
> .../boot/dts/rockchip/rk3566-quartz64-a.dts | 51 +++++++++++-------
> .../boot/dts/rockchip/rk3566-quartz64-b.dts | 52 ++++++++++---------
> .../dts/rockchip/rk3566-soquartz-blade.dts | 6 +--
> .../boot/dts/rockchip/rk3566-soquartz-cm4.dts | 6 +--
> .../dts/rockchip/rk3566-soquartz-model-a.dts | 10 ++--
> .../boot/dts/rockchip/rk3566-soquartz.dtsi | 43 ++++++++++-----
> 8 files changed, 148 insertions(+), 101 deletions(-)
next prev parent reply other threads:[~2025-10-26 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 15:37 [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices Diederik de Haas
2025-10-26 17:44 ` Diederik de Haas [this message]
2025-10-27 11:38 ` Dragan Simic
2025-10-27 16:46 ` Heiko Stuebner
2025-10-27 19:54 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDSFVM1TXN8C.3JNX2M8XX04IF@cknow-tech.com \
--to=diederik@cknow-tech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).