From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E923FD65C4F for ; Wed, 17 Dec 2025 14:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc: Subject:From:To:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=to5iMxlqbo+pcsR8bNTm6k5Dmpabhv622hhzqTz8TTc=; b=ZoK8lznKEjB1wJ7KdHEAKi2LK4 3300yIRAhk5/qTDB4kISty2xrrC/YT8cqmiexoeWoGFw47V/pKZ23xe2IPBDLRLnS7UAPfeA5IsEX JBCNm9EN3WDREwhgzN0NvdLY2qi8EKKrRuEClImjfkk6SIXzPsBS2pbvSsPz/VwsBl2uasDjboeT5 xeCo+UWhSaPLJcv/9J9A3XQHHDnOhRIukGuxP/rFSnwFwCw3OccabHvluZnhA5XOoMdizBfV+44oJ EZVUlY/FECqkQV3QK5NQ3EzrTfezmC6GkZKeGbwUjjCueFC1boEWZs5dUAs1e+Eq2d4cte8P0Phoi ja4RI6rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVsTf-00000006vo1-0xJK; Wed, 17 Dec 2025 14:26:07 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVsTc-00000006vmC-31ke for linux-arm-kernel@lists.infradead.org; Wed, 17 Dec 2025 14:26:06 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 42BD31A2281; Wed, 17 Dec 2025 14:26:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 16AD96072F; Wed, 17 Dec 2025 14:26:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E1866102F0AE0; Wed, 17 Dec 2025 15:25:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765981561; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=to5iMxlqbo+pcsR8bNTm6k5Dmpabhv622hhzqTz8TTc=; b=F0CiiNN/SEpf0zrbWcF6F4oxhc5QhsKITa3SgfDtBpPHN99SuY6z9+SldYbyV/KgdhnT5t 3G6MeSyxnuBvDGtFcZk5Iywy6lQVOisnkSRA2vWS66aGC3FaeRF67vWBXmeLtncwtrrZpU o9CfFQgk3RpuxmpchCS4j/9wf1zLZ/gV4M/KxRLMt7R2YS+PJwpShaCZkxWmsNjzvhJakB 3L2izt1hNmLP07szLly4Hll48At7/XO3cj9yBeFhbuFbMIBlvzvBBvxrIHJ8o9yiZNUFRC F7rOvJCaEIhIbPqBxmpx5J5XLpl9CGddpfReLroTamMk9jFFo9+IcpOC4tXa/A== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Dec 2025 15:25:57 +0100 Message-Id: To: "Kory Maincent (TI.com)" , "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" From: "Luca Ceresoli" Subject: Re: [PATCH v2 14/20] drm/tilcdc: Modernize driver initialization and cleanup paths Cc: "Markus Schneider-Pargmann" , "Bajjuri Praneeth" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , X-Mailer: aerc 0.20.1 References: <20251211-feature_tilcdc-v2-0-f48bac3cd33e@bootlin.com> <20251211-feature_tilcdc-v2-14-f48bac3cd33e@bootlin.com> In-Reply-To: <20251211-feature_tilcdc-v2-14-f48bac3cd33e@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251217_062604_898280_07CD0C53 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > Refactor the driver initialization to use modern DRM managed resource > APIs, simplifying the code. > > The tilcdc_init and tilcdc_fini wrapper functions are removed since they > served no purpose after the component framework was eliminated. Their > logic is integrated directly into probe and remove. > > Key changes: > - Use devm_drm_dev_alloc() instead of drm_dev_alloc(). > - Use drmm_mode_config_init() instead of drm_mode_config_init(). > - Align the remove path with the probe error path to ensure consistent > cleanup ordering in both success and failure cases. > - Adjust platform_set_drvdata() to store the private structure instead > of the drm_device, matching the new allocation pattern. > > These changes reduce error-prone code while maintaining the same > functional behavior. > > Signed-off-by: Kory Maincent (TI.com) Overall looks good: Reviewed-by: Luca Ceresoli However the diff is not very readable dues to the code moved around. I suspect this could have been split in multiple patches: some just moving code around and no functional changes, others doing the actual work but without moving around code so the diff is more readable. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com