From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4FC9D31A23 for ; Wed, 14 Jan 2026 08:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References: Subject:From:To:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OrlcgvLEASE7cgCAVQW4sEC2L2tinvXr+j0pOUZUjvY=; b=49GVAKMqz5HUdfuh32PqGpao1n 8B3tq8NaeMS+OF6emYWVBcxatgA6MVMWhaXgPWmlVomw7+Gkn+sSAGI9xzQslK/kViN1mtb1zKvqu 17b4+EV9A7MdoynJDS5tPXTs2kUFLMrRyvedfyIW0zLwUJ1VLZ7YuImpFwwgli5Gv2d3psDHshqiy x2Zxobpql3L0PIFQ4I3MKtCFeR4WOHQeG6WAzA1/+18C2qOfNNB1difoh3TZsuKGjwc/Fe5sIfXaz XUp5bymmd4huqxyAsWzI/WKjqwdDC1lLXa3LpHVRhKm8opBQg3zc1DfZnsDMV3xOjhlSga1u6hUvN Zq9w1vPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfvq7-00000008GJe-3dxP; Wed, 14 Jan 2026 08:02:51 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfvq3-00000008GFA-3lWc for linux-arm-kernel@lists.infradead.org; Wed, 14 Jan 2026 08:02:50 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 4B0061A2857; Wed, 14 Jan 2026 08:02:44 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0E5C76074A; Wed, 14 Jan 2026 08:02:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 95556103C82AE; Wed, 14 Jan 2026 09:02:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768377762; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=OrlcgvLEASE7cgCAVQW4sEC2L2tinvXr+j0pOUZUjvY=; b=x88kuLUqFra37jp+2L7Hmyl1rJK9Luj34PccVPygGuBCC5mIUNebQlygEiXB90nJrOOq+B bdtRJbNiaHF/QALBf/DPpUr60ZpM5vhmVOXLlkv7oMKeKJQNP+BV4YdafCKgB1jDyaAPS2 tq5kA2oEP25DWOWvI0u2Fyifk3icvqsLbMsUmjXV3ejO7GBvLUNaiqfEvB2ZkGbiC+5LTu zHYrpWi9KCbcQZYi3IgsxHlw0lA3zBo1u/c47qXxbQWSy3rWbbKhvEIWU87kPC41Ert43H A1ighEQjWb6vQJdU5S1OfOJxLVA3ZVpXbWi0B45Cr3vvnRFlbka6Iwu8FsX63Q== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 14 Jan 2026 09:02:35 +0100 Message-Id: Cc: , , , , To: "Marco Felsch" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Peng Fan" , "Liu Ying" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" From: "Luca Ceresoli" Subject: Re: [PATCH v8 2/3] drm/bridge: imx: Add i.MX93 parallel display format configuration support X-Mailer: aerc 0.20.1 References: <20260113-v6-18-topic-imx93-parallel-display-v8-0-4abccdc473a5@pengutronix.de> <20260113-v6-18-topic-imx93-parallel-display-v8-2-4abccdc473a5@pengutronix.de> In-Reply-To: <20260113-v6-18-topic-imx93-parallel-display-v8-2-4abccdc473a5@pengutronix.de> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260114_000248_208892_16FDEDDF X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Marco, Liu, On Tue Jan 13, 2026 at 8:07 PM CET, Marco Felsch wrote: > From: Liu Ying > > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add a DRM bridge driver to support the display format configuratio= n. > > Signed-off-by: Liu Ying > [m.felsch@pengutronix.de: port to v6.19-rc1] > [m.felsch@pengutronix.de: add review feedback (Alexander)] > [m.felsch@pengutronix.de: fix to short Kconfig description (checkpath)] > [m.felsch@pengutronix.de: use "GPL" instead of "GPL v2" (checkpatch)] > [m.felsch@pengutronix.de: add bus-width support] > Signed-off-by: Marco Felsch I'm sorry to be reviewing at v8 only, I hadn't noticed this series before. > --- > drivers/gpu/drm/bridge/imx/Kconfig | 11 ++ > drivers/gpu/drm/bridge/imx/Makefile | 1 + > drivers/gpu/drm/bridge/imx/imx93-pdfc.c | 221 ++++++++++++++++++++++++++= ++++++ > 3 files changed, 233 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/= imx/Kconfig > index b9028a5e5a065c3237b404111d8df57e8e017f9d..181ee87bc0f9f65ee0b6e5edb= b48ba808dfbb71f 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -99,4 +99,15 @@ config DRM_IMX93_MIPI_DSI > Choose this to enable MIPI DSI controller found in Freescale i.MX93 > processor. > > +config DRM_IMX93_PARALLEL_DISP_FMT_CONFIG > + tristate "NXP i.MX91/i.MX93 parallel display format configuration" Minor nit: this is a driver for a device, so calling it "configuration" seems weird. From the code it looks like a device converting the color format, so what about "NXP i.MX91/i.MX93 parallel display format converter"? [...] > +static int imx93_pdfc_bridge_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct imx93_pdfc *pdfc; > + struct device_node *ep; > + int err; > + > + pdfc =3D devm_drm_bridge_alloc(dev, struct imx93_pdfc, bridge, &funcs); > + if (IS_ERR(pdfc)) > + return PTR_ERR(pdfc); > + > + pdfc->regmap =3D syscon_node_to_regmap(dev->of_node->parent); > + if (IS_ERR(pdfc->regmap)) > + return dev_err_probe(dev, PTR_ERR(pdfc->regmap), > + "failed to get regmap\n"); > + > + /* No limits per default */ > + pdfc->phy_bus_width =3D 24; > + > + /* Get output ep (port1/endpoint) */ > + ep =3D of_graph_get_endpoint_by_regs(dev->of_node, 1, -1); > + if (ep) { > + err =3D of_property_read_u32(ep, "bus-width", &pdfc->phy_bus_width); > + of_node_put(ep); > + > + /* bus-width is optional but it must have valid data if present */ > + if (err && err !=3D -EINVAL) > + return dev_err_probe(dev, err, > + "failed to query bus-width\n"); > + } > + > + pdfc->next_bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 1, 0); > + if (IS_ERR(pdfc->next_bridge)) > + return dev_err_probe(dev, PTR_ERR(pdfc->next_bridge), > + "failed to get next bridge\n"); > + > + pdfc->dev =3D dev; > + pdfc->bridge.driver_private =3D pdfc; pdfc embeds the struct drm_bridge, which is the mandatory design since devm_drm_bridge_alloc() got added, so driver_private shouldn't be needed anymore. Most drivers have a bridge_to_foo() inline function using component_of() to get the private struct from the drm_bridge pointer, e.g. [0] and [1]. [0] https://elixir.bootlin.com/linux/v6.18.5/source/drivers/gpu/drm/bridge/= simple-bridge.c#L39-L43 [1] https://elixir.bootlin.com/linux/v6.18.5/source/drivers/gpu/drm/bridge/= ti-sn65dsi83.c#L287-L290 A short discussion took place a few months ago about driver_private, kind of suggesting it might be removed after all drivers have switched to devm_drm_bridge_alloc(). I think we should at least not introduce new users of driver_private at least. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com