From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Detlev Casanova" <detlev.casanova@collabora.com>,
<linux-kernel@vger.kernel.org>
Cc: "Nicolas Frattaroli" <frattaroli.nicolas@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Heiko Stuebner" <heiko@sntech.de>,
<linux-rockchip@lists.infradead.org>,
<linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@collabora.com>,
<alexandre.belloni@bootlin.com>, <thomas.petazzoni@bootlin.com>
Subject: Re: [REGRESSION] Re: [PATCH v1] ASoC: rockchip: i2s_tdm: Re-add the set_sysclk callback
Date: Wed, 18 Feb 2026 17:51:51 +0100 [thread overview]
Message-ID: <DGI8RSUWQ7W8.MDY7YGXPA5LX@bootlin.com> (raw)
In-Reply-To: <34f61d25-607c-4967-bc67-3c7517c7fe14@collabora.com>
Hello Detlev,
On Wed Feb 18, 2026 at 5:01 PM CET, Detlev Casanova wrote:
> Hi Lucas, sorry for breaking support on your board.
> I'm also surprised that you were not added in CC of the original patch.
>
> Can you try to keep the patch and apply the attached one instead ?
Thanks for the quick feedback.
About your patch:
--- a/sound/soc/rockchip/rockchip_i2s_tdm.c
+++ b/sound/soc/rockchip/rockchip_i2s_tdm.c
@@ -665,6 +665,12 @@ static int rockchip_i2s_tdm_hw_params(struct snd_pcm_substream *substream,
mclk_rate = i2s_tdm->mclk_rx_freq;
}
+ /* If the dai/component driver didn't call set_sysclk(), simply
+ * use the freq from the params.
+ */
The comment is slightly incorrect: set_sysclk() was called in my case, but
only for playback, not for capture. You can reword accordingly.
+ if (!mclk_rate)
+ mclk_rate = DEFAULT_MCLK_FS * params_rate(params);
With this, and DEFAULT_MCLK_FS defined to 256, arecord is working again.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-02-18 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 16:31 [PATCH v1] ASoC: rockchip: i2s_tdm: Re-add the set_sysclk callback Detlev Casanova
2025-01-21 18:10 ` Mark Brown
2026-02-10 9:54 ` [REGRESSION] " Luca Ceresoli
2026-02-17 19:22 ` Mark Brown
2026-02-18 12:14 ` Luca Ceresoli
2026-02-18 12:19 ` Luca Ceresoli
2026-02-18 16:01 ` Detlev Casanova
2026-02-18 16:51 ` Luca Ceresoli [this message]
2026-02-18 17:10 ` Mark Brown
2026-02-18 17:17 ` Detlev Casanova
2026-02-18 17:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGI8RSUWQ7W8.MDY7YGXPA5LX@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox