Re: [PATCH] arm64: dts: rockchip: configure hdmirx in Rock 5 ITX

["Diederik de Haas" <diederik@cknow-tech.com>]

On Wed Mar 4, 2026 at 2:54 PM CET, Pedro Alves wrote:
> The Radxa Rock 5 ITX board exposes an HDMI input exactly the same way as
> the Rock 5B, but this was not reflected in its DTS.
>
> Change the rk3588-rock-5-itx to configure and enable the hdmi_receiver
> and hdmi_receiver_cma nodes.
>
> One of the existing pinctrl labels, hdmirx_det, was renamed into
> hdmirx_hpd to match the other boards. The _det name seems to have come
> from the downstream kernel sources, where the other boards also have
> that name. Changing it to hdmirx_hpd in order to be consistent with the
> other rk3588 boards in the kernel.

I have a strong suspicion that it was named 'hdmirx_det' because in the
schema its label is 'HDMIIRX_DET_L' where the extra 'I' was probably
dropped as that seems to be a spelling issue and the '_L' suffix is
quite often dropped.

FWIW: The label in the schematic for Rock 5B, Rock 5B+, Rock 5T and Rock
5 ITX+ are all 'HDMIIRX_DET_L', yet none of them follow the convention
to use the label from the schematics.

So now the 'problem' is indeed: make it consistent with the other boards
or keep the one where the convention was followed.

Cheers,
  Diederik

> The configurations were confirmed to be identical on the downstream
> Radxa kernel, and this has been tested to work on a Rock 5 ITX board
> running kernel 6.19.3.
>
> Signed-off-by: Pedro Alves <pta2002@pta2002.com>
> ---
> Tested with the following commands:
>
> v4l2-ctl --verbose -d /dev/video4 \
>   --set-fmt-video=width=3840,height=2160,pixelformat='BGR3' \
>   --stream-mmap=4 --stream-skip=3 --stream-count=20 \
>   --stream-to=hdmiin.raw --stream-poll
>
> ffmpeg -f rawvideo -vcodec rawvideo -s 3840x2160 -r 30 -pix_fmt bgr24 \
>   -i hdmiin.raw output.mp4
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> index 172aeabba72a..9f4f31d1ca94 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts
> @@ -349,6 +349,18 @@ &hdmi1_sound {
>  	status = "okay";
>  };
>  
> +&hdmi_receiver_cma {
> +	status = "okay";
> +};
> +
> +&hdmi_receiver {
> +	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
> +	pinctrl-names = "default";
> +
> +	hpd-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};
> +
>  &hdptxphy1 {
>  	status = "okay";
>  };
> @@ -746,7 +758,7 @@ vbus5v0_typec_en: vbus5v0-typec-en {
>  	};
>  
>  	hdmirx {
> -		hdmirx_det: hdmirx-det {
> +		hdmirx_hpd: hdmirx-5v-detection {
>  			rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
>  		};
>  	};
>
> ---
> base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
> change-id: 20260303-radxa-r5-itx-hdmirx-f4645e64f8c3
>
> Best regards,