From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D0D2EFCE33 for ; Wed, 4 Mar 2026 18:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NfY2kXCUHHtHIbcGOoAHRgzyuErTZbqiG1z4V5950IY=; b=PuAxqnlNM6Spbj7Gib08+/TAMw YqttpsjKz5uRJzYy1Jsde6jGtU/5J6DfGgmnBI60wUVFr6qptypwGPt9hK3IgOfytYhz59asa07SP dwx3JXVimtGaJA0n7lH1q7D/v4yg+VpuD+fgnA1KNjg1bHFvpvuECWnc2mW4onfRUijA6oCzZT0Ju o0F+SMevmQmwgMbf8NTj8e/arVDjnpttt1acnuPeUORyxPt7Ur7LxpnUP1h938f8PAdKJJkiCL+Rw 7UtgtiBgk3aYZeGndSBTyXlD6mZMXRISCbQZkIOXyL93phUB5nxFr2blqAfc0r8zMRLNrkaEj9CJO HAlvHL6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxr6x-00000000Lgr-3RI8; Wed, 04 Mar 2026 18:38:19 +0000 Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxr6v-00000000Lfj-2vtN for linux-arm-kernel@lists.infradead.org; Wed, 04 Mar 2026 18:38:18 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1772649485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NfY2kXCUHHtHIbcGOoAHRgzyuErTZbqiG1z4V5950IY=; b=YZG1wEEYVUF5+0ocmTUfXGVXA5oB/lK5ZWwcUsx41JHqqaNmCohlDPhDNyxMUy6KmOctWh qknC1NH0ITC1ABnI6rMhSties4AvN1cxJKG2kIBqshS5/pgPMOOEDKPP21jJ862TJH4ot9 SFQqkWIxHezOPy8Zx4YSHszbsxf10liguBULWlfhyf+kUjaxKwFNq555eFA0mZ718fd+07 fCu+82dEM1JBRJtAfLi+V/tZAizk/DrCcPDYkuOF526f7T+NrC7OVeiLLSSgxYl0s2WfYM JiHNq3Dqn9ikUVVfmYnWjVNvSgRHmWvBCt+XPxMUMSj2qno1/LRsxFIcJFF6Ow== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 04 Mar 2026 19:38:02 +0100 Message-Id: Cc: , , , Subject: Re: [PATCH] arm64: dts: rockchip: configure hdmirx in Rock 5 ITX X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Pedro Alves" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" References: <20260304-radxa-r5-itx-hdmirx-v1-1-f77bf1f7ce03@pta2002.com> In-Reply-To: <20260304-radxa-r5-itx-hdmirx-v1-1-f77bf1f7ce03@pta2002.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260304_103817_875952_9AA8E141 X-CRM114-Status: GOOD ( 22.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed Mar 4, 2026 at 2:54 PM CET, Pedro Alves wrote: > The Radxa Rock 5 ITX board exposes an HDMI input exactly the same way as > the Rock 5B, but this was not reflected in its DTS. > > Change the rk3588-rock-5-itx to configure and enable the hdmi_receiver > and hdmi_receiver_cma nodes. > > One of the existing pinctrl labels, hdmirx_det, was renamed into > hdmirx_hpd to match the other boards. The _det name seems to have come > from the downstream kernel sources, where the other boards also have > that name. Changing it to hdmirx_hpd in order to be consistent with the > other rk3588 boards in the kernel. I have a strong suspicion that it was named 'hdmirx_det' because in the schema its label is 'HDMIIRX_DET_L' where the extra 'I' was probably dropped as that seems to be a spelling issue and the '_L' suffix is quite often dropped. FWIW: The label in the schematic for Rock 5B, Rock 5B+, Rock 5T and Rock 5 ITX+ are all 'HDMIIRX_DET_L', yet none of them follow the convention to use the label from the schematics. So now the 'problem' is indeed: make it consistent with the other boards or keep the one where the convention was followed. Cheers, Diederik > The configurations were confirmed to be identical on the downstream > Radxa kernel, and this has been tested to work on a Rock 5 ITX board > running kernel 6.19.3. > > Signed-off-by: Pedro Alves > --- > Tested with the following commands: > > v4l2-ctl --verbose -d /dev/video4 \ > --set-fmt-video=3Dwidth=3D3840,height=3D2160,pixelformat=3D'BGR3' \ > --stream-mmap=3D4 --stream-skip=3D3 --stream-count=3D20 \ > --stream-to=3Dhdmiin.raw --stream-poll > > ffmpeg -f rawvideo -vcodec rawvideo -s 3840x2160 -r 30 -pix_fmt bgr24 \ > -i hdmiin.raw output.mp4 > --- > arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts b/arch/ar= m64/boot/dts/rockchip/rk3588-rock-5-itx.dts > index 172aeabba72a..9f4f31d1ca94 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts > @@ -349,6 +349,18 @@ &hdmi1_sound { > status =3D "okay"; > }; > =20 > +&hdmi_receiver_cma { > + status =3D "okay"; > +}; > + > +&hdmi_receiver { > + pinctrl-0 =3D <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_r= x_sda &hdmirx_hpd>; > + pinctrl-names =3D "default"; > + > + hpd-gpios =3D <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>; > + status =3D "okay"; > +}; > + > &hdptxphy1 { > status =3D "okay"; > }; > @@ -746,7 +758,7 @@ vbus5v0_typec_en: vbus5v0-typec-en { > }; > =20 > hdmirx { > - hdmirx_det: hdmirx-det { > + hdmirx_hpd: hdmirx-5v-detection { > rockchip,pins =3D <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > > --- > base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b > change-id: 20260303-radxa-r5-itx-hdmirx-f4645e64f8c3 > > Best regards,