public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Fabian Grünbichler" <debian@fabian.gruenbichler.email>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Christian Schrrefl" <chrisi.schrefl@gmail.com>,
	"Russell King" <rmk+kernel@armlinux.org.uk>
Cc: "Rudraksha Gupta" <guptarud@gmail.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: arm `rustdoc` Rust 1.85.0-only build error
Date: Fri, 03 Apr 2026 13:48:16 +0100	[thread overview]
Message-ID: <DHJJ59GIJ16B.2TSQW73T2JWAL@garyguo.net> (raw)
In-Reply-To: <d47bcff5-ae97-4a27-8348-efef67ed3d98@app.fastmail.com>

On Fri Apr 3, 2026 at 9:12 AM BST, Fabian Grünbichler wrote:
> On Tue, Mar 31, 2026, at 9:00 PM, Miguel Ojeda wrote:
>> Hi Christian, Russell, arm, Fabian,
>>
>> For Rust 1.85.0, for arm32, for the `rustdoc` target (i.e. all those
>> combined), I am seeing:
>>
>>       RUSTDOC   
>> .../1.85.0-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/lib.rs
>>     error: target feature `fp-armv8` cannot be toggled with 
>> `#[target_feature]`: Rust ties `fp-armv8` to `neon`
>>         --> 
>> .../1.85.0-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/../../stdarch/crates/core_arch/src/arm_shared/neon/generated.rs:7538:48
>>          |
>>     7538 | #[cfg_attr(target_arch = "arm", target_feature(enable = 
>> "fp-armv8,v8"))]
>>          |                                                
>> ^^^^^^^^^^^^^^^^^^^^^
>>
>> The issue is [1], was introduced in Rust 1.85.0 and was fixed already in
>> Rust 1.85.1 [2]:
>>
>>   Link: https://github.com/rust-lang/rust/issues/137366 [1]
>>   Link: https://github.com/rust-lang/rust/pull/137632 [2]
>>
>> It is unfortunate since our minimum is going to be 1.85.0 since that is
>> what Debian Stable has (even if patches may be on top) -- I generally
>> test the latest patch versions for each minor, but I noticed this since
>> I also test the actual minimum, and I am bumping it to 1.85.0.
>>
>> To be clear, it is likely almost no one actually cares about this, since
>> nobody complained yet, and this can easily be fixed using the already
>> released Rust 1.85.1.
>>
>> By the way, what is Debian's policy on upstream Rust patch versions?
>
> In unstable, we pull them in usually by virtue of lagging behind a bit anyway.
>
> In stable there is no policy per se - both importing a new smallish important
> upstream release, or cherry-picking patches are options in general. A few
> packages with clear upstream LTS policies are updated often (systemd, glibc,
> the kernel itself, firefox-esr and chromium would be the most popular
> examples). If there is no upstream stable release series that matches Debian
> stable policies, the usual approach is to do a targeted backport of just the
> fixes.
> lack of rustc LTS, usually there are no point releases for the version to be
> included in Debian stable anyway.
>
> It's up to the stable release managers how big of a delta is acceptable.
>
> I will check how the full diff for 1.85.1 looks like compared to just picking
> the rustdoc fix referenced above, and then file a stable update request. AFAIU
> either option works for you?

You can check diff here:
https://github.com/rust-lang/rust/compare/1.85.0...1.85.1

The change is not much, there is a library change although that's for Windows
only. The compiler and rustdoc changes are usually pretty harmless to backport.

I guess for Debian you cared about binary compatibility; in which case you
probably want to keep the compiler version number at 1.85.0, so the compiler
verison hash stays unchanged.

Best,
Gary


      parent reply	other threads:[~2026-04-03 12:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 19:00 arm `rustdoc` Rust 1.85.0-only build error Miguel Ojeda
2026-04-03  8:12 ` Fabian Grünbichler
2026-04-03 10:19   ` Miguel Ojeda
2026-04-03 12:48   ` Gary Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHJJ59GIJ16B.2TSQW73T2JWAL@garyguo.net \
    --to=gary@garyguo.net \
    --cc=ardb@kernel.org \
    --cc=chrisi.schrefl@gmail.com \
    --cc=debian@fabian.gruenbichler.email \
    --cc=guptarud@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox