From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23929CD8CB9 for ; Tue, 9 Jun 2026 16:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To :From:Subject:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GU6hxEB3LrImYHmp13AtCCpp8e8bRkCTpxK/TD8cOpY=; b=f+eVtf0EjuKDE9McVvnBsdMO/7 mbLZdYw0wcTEx4ar8P5W8dRF9DsP6aN7w84W2MaNn+3HloFpi40aM3OnXHI7j12XFO251JiY2OETb 2RvKpImpO7gejCSKNoOm/CPm+VUrKK0cxp2+AD45wxfEKPktybp+Fx+sENQ1v+m+nNdWWsBRlCH4R ZqbAv0q10vsbV93ODz8s8JkdHKRKGEdhch45AG4uJe/KsWWM/Lh29tRldSpvuzWNFWDP5RK/vhMBA 6Ly/rseDCIfPuCB+6FM4llj1Jrits878zaaKMhw5+IeKBdwKGSKJgfJpnCbtmViJXMafAwHqRjynS uTA4c9FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWzO1-0000000636D-2jfT; Tue, 09 Jun 2026 16:33:10 +0000 Received: from out-171.mta0.migadu.com ([91.218.175.171]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWzNz-0000000631q-1qbO for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2026 16:33:08 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1781022750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GU6hxEB3LrImYHmp13AtCCpp8e8bRkCTpxK/TD8cOpY=; b=QOUagz86dzoPrDjhHrSwN/06Sdmkq2iGHnAcJWwwkB4jGy9cpZbeuBVKzUQ2wMbiBEhNfS fkXZcqO/FX8Da8Q0Jb9q0Ri64dwxeIwsei3wq03ji5x/sDo2a0B2GzHSiIlmdfbqDYKmid EBrn1SB3ts5kXNKC6WG9f27WKnnLVyBVAsiozmaoQqJlJEKXdh+T01Ds0t55ucLSSadvdw uUknq9hMXc6S/2Q00PMkA2/C5aaG+6n43UK9L2qDQhzLWDO7kxIpqzKkWDvYmcreWWk91w ytsziuJNh2KWUV6GtxJWxrmErpQ4KJkuERcFgsEFkG1uOfZG+MkDxu5o+509UA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 09 Jun 2026 18:32:16 +0200 Message-Id: Subject: Re: [PATCH 1/2] dt-bindings: usb: Add Rockchip RK3568 compatible for EHCI and OHCI X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Jonas Karlman" , "Heiko Stuebner" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Greg Kroah-Hartman" Cc: "Diederik de Haas" , , , , , References: <20260609154124.445182-1-jonas@kwiboo.se> <20260609154124.445182-2-jonas@kwiboo.se> In-Reply-To: <20260609154124.445182-2-jonas@kwiboo.se> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260609_093307_626119_B72D95A4 X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonas, On Tue Jun 9, 2026 at 5:41 PM CEST, Jonas Karlman wrote: > The Rockchip RK3568 EHCI/OHCI controller depends on clk_usbphy1_480m > being enabled, or the system may freeze when registers are accessed. > > Add Rockchip RK3568 EHCI and OHCI compatibles with a similar four-clock > constraint as RK3588. > > Signed-off-by: Jonas Karlman > --- > Existing DTs for RK3568 use the plain generic-ehci/ohci compatible, > next patch make use of these new compatibles and adds the missing > clk_usbphy1_480m clock references. > --- > .../devicetree/bindings/usb/generic-ehci.yaml | 10 ++++++++++ > .../devicetree/bindings/usb/generic-ohci.yaml | 5 ++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Do= cumentation/devicetree/bindings/usb/generic-ehci.yaml > index 55a5aa7d7a54..c49a1bbc8cfd 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -52,6 +52,7 @@ properties: > - ibm,476gtr-ehci > - nxp,lpc1850-ehci > - qca,ar7100-ehci > + - rockchip,rk3568-ehci > - rockchip,rk3588-ehci > - snps,hsdk-v1.0-ehci > - socionext,uniphier-ehci > @@ -186,6 +187,15 @@ allOf: > required: > - clocks > - clock-names > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3568-ehci > + then: > + properties: > + clocks: > + minItems: 4 I think that the constraint for rk3588 is this: - minItems: 1 - maxItems: 4 Like ~ every other compatible; there's no 'branch' for rk3588-ehci. That's different from what you add for rk3568. Is that deliberate? Because from the commit message I assumed they should be the same. > unevaluatedProperties: false > =20 > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Do= cumentation/devicetree/bindings/usb/generic-ohci.yaml > index d42f448fa204..5f1b4d2bff89 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > @@ -47,6 +47,7 @@ properties: > - hpe,gxp-ohci > - ibm,476gtr-ohci > - ingenic,jz4740-ohci > + - rockchip,rk3568-ohci > - rockchip,rk3588-ohci > - snps,hsdk-v1.0-ohci > - const: generic-ohci > @@ -198,7 +199,9 @@ allOf: > properties: > compatible: > contains: > - const: rockchip,rk3588-ohci > + enum: > + - rockchip,rk3568-ohci > + - rockchip,rk3588-ohci Here they clearly do have the same constraint. Cheers, Diederik > then: > properties: > clocks: