From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D1F1CDB46F for ; Tue, 23 Jun 2026 13:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To: From:Subject:Cc:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UZ4++YxJXc/6SFIqw2u6ldCc2haTxcSXXUeS9bd2ENM=; b=THeOYKVUmipPYLUiXALfUWfLlL YT3Rrpj1W/mqlDDUxCeuT1lSKfT2IaLUgi1ui7g76o201UQsySqwIzkpiP1MJyW1OHiOkVQ+EvkJu NJwyyhjdioWXxHokU1n2ZtO+wn2XnmWSD5ofTR7Y2IWRDw+kJQhCFd6Xi8TbRpvYcrCf5YEnb09L5 rFm/eNKEz7BFlELr4DZPzO5V4Acj0+uAm+C1rlfjdwAaJu1Kl5AABaJrZDW+WWRhF/IP7Mc9jWe36 c7GQrJj6UlJFrL2o6T5FGzHiyRe7w7JqAOf1LowRh9d8iV+dhOro4Vuc4SG/8Z99pO43q/NnYwn0S +1NdLvtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wc1Ri-00000006MVJ-3y5D; Tue, 23 Jun 2026 13:45:46 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wc1Rg-00000006MUH-483t for linux-arm-kernel@lists.infradead.org; Tue, 23 Jun 2026 13:45:46 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1782222332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZ4++YxJXc/6SFIqw2u6ldCc2haTxcSXXUeS9bd2ENM=; b=Xvt2WwtmOY6PYw8fMMtaKUPwhp00TjzdQIEHqcqaypIosTEKgcmztrkWySTKWpaBWtZTCA 1L4m4hU0BAGVvOjQ+nMVV0yHMl39CI6/NJfo8JrXcGL71Gtfc2bxxcCIpcQ1/NHm0YSScq VixU+qrUJNYvHsjEUT/yHEAyQjSidSJOszChjXClbXTCVq1nBsFVsdfkEQ3XlUrvRKI7Co QdXQtaOX2kRLeEiv6rBCwXc0J7rhVqhqtw7KvAZ3ArRpIPUeJEG9l7IjUTcel/3bweDh7B moSJILJFXOBN0NCfuwE0orLdYnOz0zgWN6FG/xVbLACwjwdu2UIz6BWcHfUQWw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 Jun 2026 15:45:23 +0200 Message-Id: Cc: "Nicolas Frattaroli" , , , , , , "Ricardo Pardini" Subject: Re: [PATCH v4 5/5] clk: rockchip: rk3588: add GATE_GRF clocks for I2S MCLK output to IO X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Daniele Briguglio" , "Diederik de Haas" , "Heiko Stuebner" , "Michael Turquette" , "Stephen Boyd" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" References: <20260419-rk3588-mclk-gate-grf-v4-0-513a42dd1dcc@superkali.me> <20260419-rk3588-mclk-gate-grf-v4-5-513a42dd1dcc@superkali.me> <2100447.PIDvDuAF1L@diego> <20260623123316.4111002-1-hello@superkali.me> <20260623132351.4144457-1-hello@superkali.me> In-Reply-To: <20260623132351.4144457-1-hello@superkali.me> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260623_064545_168774_A3F1B4BA X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniele, On Tue Jun 23, 2026 at 3:23 PM CEST, Daniele Briguglio wrote: >> md.l 0xfd58c318 >> fd58c318: 00000600 > > Thanks. Bit 0 is clear there, so the I2S0 gate is open at the U-Boot > prompt, after BL31 and before Linux. That matches the symptom: the > firmware on your T6 leaves it open, and the kernel closes it once nothing > references it. > > Given that, I think Heiko's suggestion makes sense here. Marking the four > gates CLK_IGNORE_UNUSED keeps the kernel from disabling what the firmware > already left open, and boards that reference _TO_IO still drive it throug= h > the consumer. My suspicion that more RK3588 based boards would be broken is because NONE = use I2S0_8CH_MCLKOUT_TO_IO; they all use I2S0_8CH_MCLKOUT. (And the testing was only done on not (yet?) upstreamed boards) > Could you test that change if you get a chance? Just set the flag on the > I2S0/1/2/3 _TO_IO gates in clk-rk3588.c and check your analog audio comes > back. The series is already merged, so I'll send the fix as a separate > follow-up patch, this evening if Heiko is fine with the approach. I'm going to build a new kernel where I did ``s/0/CLK_IGNORE_UNUSED/`` 4 ti= mes and I adjusted my NanoPC-T6 Plus board dts to use I2S0_8CH_MCLKOUT_TO_IO, w= hile I keep the LTS board dts to I2S0_8CH_MCLKOUT. So IIUC that means I'd be testing both variants. Cheers, Diederik