From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Linus Walleij" <linusw@kernel.org>
Cc: "Bartosz Golaszewski" <brgl@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] gpio: nomadik: drop "chip registered" log on probe success
Date: Thu, 02 Jul 2026 10:34:02 +0200 [thread overview]
Message-ID: <DJNY3N48KALQ.1JASSQTBU3GTN@bootlin.com> (raw)
In-Reply-To: <CAD++jLmmHXBC9ni0pcVoB2HNK+osBzgirxH7vLHZaANmoe-tpQ@mail.gmail.com>
Hello Linus,
On Thu Jul 2, 2026 at 10:00 AM CEST, Linus Walleij wrote:
> On Wed, Jul 1, 2026 at 6:57 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:
>
>> Successful driver probing should be silent. Drop unconditional
>> dev_info() call that is done at nmk_gpio_probe() exit.
>>
>> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
>
> I actually don't generally agree, but you are using this driver more than
> me now so let's go with your minimalist dmesg style for this driver.
I get from where you stand, but the info level is somewhat strong.
Documentation/process/coding-style.rst agrees ("When drivers are
working properly they are quiet").
If you like this log line we can turn it into a lower debug level?
> Reviewed-by: Linus Walleij <linusw@kernel.org>
Thanks for the reviews Linus!
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-07-02 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 16:56 [PATCH 0/5] gpio: nomadik: silence boot log Théo Lebrun
2026-07-01 16:56 ` [PATCH 1/5] gpio: nomadik: convert nmk_gpio_populate_chip() to goto cleanup Théo Lebrun
2026-07-02 7:58 ` Linus Walleij
2026-07-01 16:56 ` [PATCH 2/5] gpio: nomadik: add missing dev_err() call on chip populate failure Théo Lebrun
2026-07-02 7:58 ` Linus Walleij
2026-07-01 16:57 ` [PATCH 3/5] gpio: nomadik: drop duplicate probe error line Théo Lebrun
2026-07-02 7:59 ` Linus Walleij
2026-07-01 16:57 ` [PATCH 4/5] gpio: nomadik: use dev_err_probe() Théo Lebrun
2026-07-02 7:59 ` Linus Walleij
2026-07-01 16:57 ` [PATCH 5/5] gpio: nomadik: drop "chip registered" log on probe success Théo Lebrun
2026-07-02 8:00 ` Linus Walleij
2026-07-02 8:34 ` Théo Lebrun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJNY3N48KALQ.1JASSQTBU3GTN@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=brgl@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox