From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29352C531C9 for ; Sat, 25 Jul 2026 15:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From: Subject:Cc:To:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aurhGwZBtBlsxKOKCfqWZVexhQ9NLkHWaOYsLZ76OpY=; b=q219sFoNHLSR/CFImsrHGFUd6u OuMhDJEFwVMaYLWxcQOBI+T8oYI0AXIGr9FWqJlONZWeG38i1cWx3lvQnrRZdKDlxuLVs2LIUQ0Pf RlN5awES71ee1W3wJCDq6R8N9A9hb2xiI/SetXSbBVNpO5b/4DFYPaObLNy91TGq2PafAEYdqmHVl PgMIXaTd/LTFDlFa18+aGa2HQoP3j1WLNZlL8f8N4IzJHAcdYTtHciHlRgJvVNjyjkLxWYaTr5+qp mGogpYoyvE8TbsnF4w/0FcQzmOKwGYPueciXBUsTrgd02hY9EDWRbcvNk3sec9GYjZnwvtc2UPXJW XbCPhegg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnd8s-00000000QYE-2ZP6; Sat, 25 Jul 2026 14:14:18 +0000 Received: from out-187.mta1.migadu.com ([95.215.58.187]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnd8p-00000000QWj-1ez5 for linux-arm-kernel@lists.infradead.org; Sat, 25 Jul 2026 14:14:16 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1784988826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aurhGwZBtBlsxKOKCfqWZVexhQ9NLkHWaOYsLZ76OpY=; b=da3/HJr1HSGbmZyx2j9hWWmH/1NxbPWVXq53bqxfd0z44gcBfNWmUIIA6poL2n64I8AuhQ uRHFtQfiyIIfxu8b/wyNuRkBxvQN3BM0BJfvHvei1IPRL4KeXvslOUP9ZiE66TA+Otldtv hRIQf1bPl6eVm6eCP6JLYkI4iPPpCAG4g1JCSP9zKpHY0ubdI06qGvyfrPkGNyIR5aDcBu nCjm1OdSU9fHObwgOmGP+BVHPMGnGxKbOyZygf/C3kQjZ1gSMQCRPRuew+tMnCp2EHx4cY fTuUI51v5ibUUcc94fhxhBG8aXJlReALfZbHTprdNh640ubIcPrefCADtSLD0g== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 25 Jul 2026 16:13:20 +0200 Message-Id: To: "Dawid Olesinski" , =?utf-8?q?Heiko_St=C3=BCbner?= Cc: "Sebastian Reichel" , "Herbert Xu" , "David S . Miller" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Corentin Labbe" , , , , , Subject: Re: [PATCH v2 3/4] arm64: dts: rockchip: Add crypto node to rk356x-base X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20260708175837.1718437-1-dawidro@gmail.com> <20260708175837.1718437-4-dawidro@gmail.com> <4011768.FjKLVJYuhi@diego> <20260710153012.0a840512@enyo> In-Reply-To: <20260710153012.0a840512@enyo> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260725_071415_574825_86891135 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri Jul 10, 2026 at 4:30 PM CEST, Dawid Olesinski wrote: > On Thu, 09 Jul 2026 09:07:23 +0200 > Heiko St=C3=BCbner wrote: > >> Am Donnerstag, 9. Juli 2026, 01:56:10 Mitteleurop=C3=A4ische Sommerzeit >> schrieb Sebastian Reichel: >> > Hi, >> >=20 >> > On Wed, Jul 08, 2026 at 06:58:24PM +0100, Dawid Olesinski wrote: =20 >> > > Add the device tree node for the V2 cryptographic hardware >> > > accelerator on RK356x SoCs (RK3566, RK3568). >> > >=20 >> > > The IP block sits in the non-secure peripheral domain. Its three >> > > clocks (core, aclk, hclk) and reset line are accessible directly >> > > through the main non-secure CRU, so no firmware intermediary is >> > > required. >> > >=20 >> > > The node is disabled by default; board files that wish to use >> > > hardware crypto offload must enable it. =20 >> >=20 >> > Why is it disabled by default? It doesn't seem to be board specific >> > at all to me (the same question applies to the RK3588 DT). =20 >>=20 >> You're definitly right about that ... there are no board specific >> resources needed, so Dawid please drop the status from both nodes. >>=20 > > I'll drop the `status =3D "disabled";`=20 > lines from both the RK356x and RK3588 device trees in v3. That also means you can drop the label/phandle as there's no longer a need to reference it in board files. Cheers, Diederik > Thanks for the review! > > Dawid > >> > >=20 >> > > Signed-off-by: Dawid Olesinski >> > > --- >> > > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 12 ++++++++++++ >> > > 1 file changed, 12 insertions(+) >> > >=20 >> > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi >> > > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index >> > > a5832895bd39..9de7e7487ca1 100644 --- >> > > a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi +++ >> > > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi @@ -1112,6 >> > > +1112,18 @@ sdhci: mmc@fe310000 { status =3D "disabled"; >> > > }; >> > > =20 >> > > + crypto: crypto@fe380000 { >> > > + compatible =3D "rockchip,rk3568-crypto"; >> > > + reg =3D <0x0 0xfe380000 0x0 0x2000>; >> > > + interrupts =3D ; >> > > + clocks =3D <&cru CLK_CRYPTO_NS_CORE>, <&cru >> > > ACLK_CRYPTO_NS>, >> > > + <&cru HCLK_CRYPTO_NS>; >> > > + clock-names =3D "core", "aclk", "hclk"; >> > > + resets =3D <&cru SRST_CRYPTO_NS_CORE>; >> > > + reset-names =3D "core"; >> > > + status =3D "disabled"; >> > > + }; >> > > + >> > > /* >> > > * Testing showed that the HWRNG found in RK3566 >> > > produces unacceptably >> > > * low quality of random data, so the HWRNG isn't >> > > enabled for all RK356x =20 >> > =20 >>=20 >>=20 >>=20 >>=20 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip