From: "Kaustabh Chakraborty" <kauschluss@disroot.org>
To: "David Lechner" <dlechner@baylibre.com>,
"Kaustabh Chakraborty" <kauschluss@disroot.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] iio: proximity: add driver for Sharp GP2AP070S proximity sensor
Date: Mon, 03 Aug 2026 22:58:24 +0530 [thread overview]
Message-ID: <DKFHI80E1741.3L5TMU6D3P9OC@disroot.org> (raw)
In-Reply-To: <380b864f-6266-40fb-87a4-027afb422885@baylibre.com>
On 2026-08-01 11:41 -05:00, David Lechner wrote:
> On 7/30/26 3:07 PM, Kaustabh Chakraborty wrote:
>> The GP2AP070S is a proximity sensor designed and manufactured by Sharp
>> Corporation. This sensor is used in mobile devices, including, but not
>> limited to - the Samsung Galaxy J6.
>>
>> The driver has been adopted from Samsung's downstream kernel
>> implementation [1]. Due to the lack of public documentation about the
>> schematics of this device. The downstream driver acts as the secondary
>> source of information. Driver clarity has also been improved with the
>> help of the GP2AP* drivers in iio/light.
>>
>> Link: https://github.com/Exynos7870/android_kernel_samsung_universal7870/blob/lineage-16.0/drivers/sensors/gp2ap070s.c [1]
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
[...]
>> +static void gp2ap070s_reset_action(void *private)
>> +{
>> + struct gp2ap070s_drvdata *drvdata = private;
>
> Usually, we don't bother with a cast/local variable in these.
> The void* can be passed directly as an arg.
Yeah, but CFI will not be happy about that.
next prev parent reply other threads:[~2026-08-03 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 20:06 [PATCH v3 0/3] Add Sharp GP2AP070S Proximity Driver and enable it in Galaxy J6 (j6lte) Kaustabh Chakraborty
2026-07-30 20:07 ` [PATCH v3 1/3] dt-bindings: iio: proximity: add Sharp GP2AP070S proximity sensor Kaustabh Chakraborty
2026-08-03 7:11 ` Krzysztof Kozlowski
2026-07-30 20:07 ` [PATCH v3 2/3] iio: proximity: add driver for " Kaustabh Chakraborty
2026-08-01 16:41 ` David Lechner
2026-08-03 17:28 ` Kaustabh Chakraborty [this message]
2026-08-03 19:18 ` David Lechner
2026-07-30 20:07 ` [PATCH v3 3/3] arm64: dts: exynos7870-j6lte: add " Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKFHI80E1741.3L5TMU6D3P9OC@disroot.org \
--to=kauschluss@disroot.org \
--cc=alim.akhtar@samsung.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox