From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45619C001DB for ; Mon, 14 Aug 2023 08:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JpAZwKDiiS5jnfPs8D+Y4aj1rCQkOTF6US9DDwa5t+k=; b=B2swdIv2ZAAcFpLvFanOKkBiRZ 1jU4QqeYR6F2jV7SWUgBAVQFNENJ8bskEczWvA64DpCJ40CM7GFg8Pavi34euKv8jnmwJtoI7ERVH XgOI7VLhHulk+vOWhInfJMHlk1tZLdXhIPQK57diafqjEjxrTZPYU+49KHoZ25yBokGO1PZRxzoEL TB/ICMU+PEtm4IZ7f2bteEmqTOU4bvmms4ZinxDrpK0pWcdBMCxaSekno9+ZFFGWca+wKUePxnnAE /bqVW4dHNNC7NiUEOQFjrU04i4PvsRO6Cl2U3vrvHqmJg6mS6mlMVILBZW4PJK59C0PyCVQlFwcQf gvKV8/pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVSpv-00GVg8-2j; Mon, 14 Aug 2023 08:22:03 +0000 Received: from relay01.th.seeweb.it ([2001:4b7a:2000:18::162]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVSps-00GVdp-1C for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 08:22:01 +0000 Received: from [192.168.2.144] (bband-dyn221.178-41-211.t-com.sk [178.41.211.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id B9E2A1F4A4; Mon, 14 Aug 2023 10:21:55 +0200 (CEST) Date: Mon, 14 Aug 2023 10:21:49 +0200 From: Martin Botka Subject: Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Message-Id: In-Reply-To: <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> References: <20230814-sid-h616-v2-0-0267749b4471@somainline.org> <20230814-sid-h616-v2-1-0267749b4471@somainline.org> <830e5e34-f6de-3233-4a12-06c8390169d1@linaro.org> X-Mailer: geary/43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_012200_567778_972E5B82 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski wrote: > On 14/08/2023 08:38, Martin Botka wrote: >> Add binding for the SID controller found in H616 SoC >> >> Signed-off-by: Martin Botka >> --- >> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> index 296001e7f498..2ec0a1b8f803 100644 >> --- >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> +++ >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml >> @@ -27,6 +27,7 @@ properties: >> - const: allwinner,sun50i-a64-sid >> - const: allwinner,sun50i-h5-sid >> - const: allwinner,sun50i-h6-sid >> + - const: allwinner,sun50i-h616-sid > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Best regards, > Krzysztof > Yea completely forgot. Sorry for that. Will send v3 tomorrow with proper binding patch using items with enums _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel