linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] DMA: PL08x: select LLI bus only once per LLI setup
Date: Thu, 21 Jul 2011 17:11:46 +0100	[thread overview]
Message-ID: <E1Qjvqk-0003ME-EX@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20110721160800.GR26574@n2100.arm.linux.org.uk>

Avoid re-selecting the LLI bus each time we create an LLI.  Move it out
of the LLI setup loops.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/dma/amba-pl08x.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 90db51f..6808f7d 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -491,10 +491,10 @@ static inline u32 pl08x_cctl_bits(u32 cctl, u8 srcwidth, u8 dstwidth,
 
 struct pl08x_lli_build_data {
 	struct pl08x_txd *txd;
-	struct pl08x_driver_data *pl08x;
 	struct pl08x_bus_data srcbus;
 	struct pl08x_bus_data dstbus;
 	size_t remainder;
+	u32 lli_bus;
 };
 
 /*
@@ -547,8 +547,7 @@ static void pl08x_fill_lli_for_desc(struct pl08x_lli_build_data *bd,
 	llis_va[num_llis].src = bd->srcbus.addr;
 	llis_va[num_llis].dst = bd->dstbus.addr;
 	llis_va[num_llis].lli = llis_bus + (num_llis + 1) * sizeof(struct pl08x_lli);
-	if (bd->pl08x->lli_buses & PL08X_AHB2)
-		llis_va[num_llis].lli |= PL080_LLI_LM_AHB2;
+	llis_va[num_llis].lli |= bd->lli_bus;
 
 	if (cctl & PL080_CONTROL_SRC_INCR)
 		bd->srcbus.addr += len;
@@ -601,9 +600,9 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x,
 	cctl = txd->cctl;
 
 	bd.txd = txd;
-	bd.pl08x = pl08x;
 	bd.srcbus.addr = txd->src_addr;
 	bd.dstbus.addr = txd->dst_addr;
+	bd.lli_bus = (pl08x->lli_buses & PL08X_AHB2) ? PL080_LLI_LM_AHB2 : 0;
 
 	/* Find maximum width of the source bus */
 	bd.srcbus.maxwidth =
-- 
1.7.4.4

  parent reply	other threads:[~2011-07-21 16:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 13:10 [PATCH 0/9] PL08x further cleanups Russell King - ARM Linux
2011-07-05 13:10 ` [PATCH 1/9] DMA: PL08x: remove unused constants Russell King - ARM Linux
2011-07-05 13:11 ` [PATCH 2/9] DMA: PL08x: select LLI bus only once per LLI setup Russell King - ARM Linux
2011-07-05 13:11 ` [PATCH 3/9] DMA: PL08x: clean up LLI debugging Russell King - ARM Linux
2011-07-05 13:11 ` [PATCH 4/9] DMA: PL08x: separately store source/destination slave address Russell King - ARM Linux
2011-07-05 13:12 ` [PATCH 5/9] DMA: PL08x: separately store source/destination cctl Russell King - ARM Linux
2011-07-05 13:12 ` [PATCH 6/9] DMA: PL08x: constify plchan->cd and plat->slave_channels Russell King - ARM Linux
2011-07-05 13:12 ` [PATCH 7/9] DMA: PL08x: cleanup selection of buswidth Russell King - ARM Linux
2011-07-05 13:13 ` [PATCH 8/9] DMA: PL08x: avoid recalculating cctl at each prepare Russell King - ARM Linux
2011-07-05 13:13 ` [PATCH 9/9] DMA: PL08x: cleanup selection of burst size Russell King - ARM Linux
2011-07-07 19:51 ` [PATCH 0/9] PL08x further cleanups Linus Walleij
2011-07-13 23:05 ` Koul, Vinod
2011-07-21 16:08   ` Russell King - ARM Linux
2011-07-21 16:11     ` [PATCH 1/9] DMA: PL08x: remove unused constants Russell King - ARM Linux
2011-07-21 16:11     ` Russell King - ARM Linux [this message]
2011-07-21 16:12     ` [PATCH 3/9] DMA: PL08x: clean up LLI debugging Russell King - ARM Linux
2011-07-21 16:12     ` [PATCH 4/9] DMA: PL08x: separately store source/destination slave address Russell King - ARM Linux
2011-07-21 16:12     ` [PATCH 5/9] DMA: PL08x: separately store source/destination cctl Russell King - ARM Linux
2011-07-21 16:13     ` [PATCH 6/9] DMA: PL08x: constify plchan->cd and plat->slave_channels Russell King - ARM Linux
2011-07-21 16:13     ` [PATCH 7/9] DMA: PL08x: cleanup selection of buswidth Russell King - ARM Linux
2011-07-21 16:13     ` [PATCH 8/9] DMA: PL08x: avoid recalculating cctl at each prepare Russell King - ARM Linux
2011-07-21 16:14     ` [PATCH 9/9] DMA: PL08x: cleanup selection of burst size Russell King - ARM Linux
2011-07-25 13:38     ` [PATCH 0/9] PL08x further cleanups Vinod Koul
2011-07-25 13:43       ` Russell King - ARM Linux
2011-07-25 13:51         ` Vinod Koul
2011-07-25 14:22           ` Russell King - ARM Linux
2011-07-25 14:38             ` Vinod Koul
2011-07-25 13:51         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Qjvqk-0003ME-EX@rmk-PC.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).