linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rmk+kernel@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/14] ASoC: kirkwood-dma: remove IEC958_SUBFRAME formats
Date: Sat, 31 Aug 2013 13:43:36 +0100	[thread overview]
Message-ID: <E1VFkWe-0003Iw-UI@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20130831123458.GF6617@n2100.arm.linux.org.uk>

The Audio block does not support IEC958 subframes as formatted by
ALSA: they're very close, but not close enough.  The formats differ
by:

3  2   2   2   1   1
1  8   4   0   6   2   8   4   0
PCUVDDDDDDDDDDDDDDDD....AAAATTTT - IEC958 subframe
PCUV0000........DDDDDDDDDDDDDDDD - Audio block format

Where P = parity, C = channel status, U = user data, V = validity,
D = sample data, A = aux, T = preamble.  As can be seen, the
position of the sample is in a different position, and the audio
block does not have the aux or preamble bits.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 sound/soc/kirkwood/kirkwood-dma.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
index ee31016..3c8fc75 100644
--- a/sound/soc/kirkwood/kirkwood-dma.c
+++ b/sound/soc/kirkwood/kirkwood-dma.c
@@ -29,9 +29,7 @@
 #define KIRKWOOD_FORMATS \
 	(SNDRV_PCM_FMTBIT_S16_LE | \
 	 SNDRV_PCM_FMTBIT_S24_LE | \
-	 SNDRV_PCM_FMTBIT_S32_LE | \
-	 SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE | \
-	 SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_BE)
+	 SNDRV_PCM_FMTBIT_S32_LE)
 
 static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
 {
-- 
1.7.4.4

  parent reply	other threads:[~2013-08-31 12:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 12:34 [PATCH 00/14] SPDIF support Russell King - ARM Linux
2013-08-31 12:35 ` [PATCH 01/14] ASoC: kirkwood: merge struct kirkwood_dma_priv with struct kirkwood_dma_data Russell King
2013-08-31 12:36 ` [PATCH 02/14] ASoC: kirkwood: use devm_clk_get() for the external clock Russell King
2013-08-31 12:37 ` [PATCH 03/14] ASoC: avoid duplicated DAI routes Russell King
2013-08-31 12:38 ` [PATCH 04/14] ASoC: kirkwood: provide KIRKWOOD_PLAYCTL_ENABLE_MASK Russell King
2013-08-31 12:39 ` [PATCH 05/14] ASoC: kirkwood: combine kirkwood-i2s and kirkwood-dma drivers Russell King
2013-08-31 12:40 ` [PATCH 06/14] ASoC: kirkwood: move calculation of max buffer size to kirkwood.h Russell King
2013-08-31 12:41 ` [PATCH 07/14] ASoC: spdif_transceiver: add output pin widget Russell King
2013-08-31 12:42 ` [PATCH 08/14] ASoC: kirkwood: prefer external clock over internal clock Russell King
2013-09-01 16:41   ` Jean-Francois Moine
2013-09-02 11:01     ` Mark Brown
2013-09-02 14:17       ` Russell King - ARM Linux
2013-08-31 12:43 ` Russell King [this message]
2013-09-02 11:02   ` [PATCH 09/14] ASoC: kirkwood-dma: remove IEC958_SUBFRAME formats Mark Brown
2013-08-31 12:44 ` [PATCH 10/14] ASoC: kirkwood: add DAPM widgets for input and output routing Russell King
2013-08-31 12:45 ` [PATCH 11/14] ASoC: kirkwood-openrd: add DAPM links between codec and cpu DAI Russell King
2013-08-31 12:46 ` [PATCH 12/14] ASoC: kirkwood-t5325: " Russell King
2013-08-31 12:47 ` [PATCH 13/14] ASoC: kirkwood: add SPDIF output support Russell King
2013-09-03 11:17   ` Mark Brown
2013-09-03 11:38     ` Russell King - ARM Linux
2013-09-03 11:59       ` Mark Brown
2013-09-03 13:34         ` Russell King - ARM Linux
2013-09-04 16:34           ` Mark Brown
2013-08-31 12:48 ` [PATCH 14/14] ASoC: kirkwood: add IEC958 channel status support Russell King
2013-08-31 15:28 ` [alsa-devel] [PATCH 00/14] SPDIF support Lars-Peter Clausen
2013-08-31 17:28   ` Mark Brown
2013-08-31 19:19     ` Russell King - ARM Linux
2013-08-31 20:46       ` Lars-Peter Clausen
2013-08-31 21:05         ` Russell King - ARM Linux
2013-08-31 22:23           ` Russell King - ARM Linux
2013-09-01 12:19           ` Mark Brown
2013-09-01 12:34             ` Russell King - ARM Linux
2013-09-01 13:02               ` Russell King - ARM Linux
2013-09-02 14:06               ` Mark Brown
2013-09-02 14:16                 ` Russell King - ARM Linux
2013-09-02 16:27                   ` Mark Brown
2013-09-02 16:59                     ` Russell King - ARM Linux
2013-09-02 20:44                       ` Mark Brown
2013-09-02 21:18                         ` Russell King - ARM Linux
2013-09-02 22:35                           ` Mark Brown
2013-09-02 23:00                             ` Russell King - ARM Linux
2013-09-04 19:33                               ` Mark Brown
2013-09-01  6:42         ` Russell King - ARM Linux
2013-09-01  7:42           ` Lars-Peter Clausen
2013-09-01  8:51             ` Russell King - ARM Linux
2013-09-01 10:08               ` Lars-Peter Clausen
2013-09-01 12:04                 ` Russell King - ARM Linux
2013-09-01 17:32                   ` Lars-Peter Clausen
2013-09-01 11:51               ` Mark Brown
2013-09-01 12:15                 ` Russell King - ARM Linux
2013-09-01 17:05                   ` Mark Brown
2013-08-31 19:14   ` Russell King - ARM Linux
2013-08-31 19:34     ` Russell King - ARM Linux
2013-09-02 14:47       ` Mark Brown
2013-09-02 14:52         ` Russell King - ARM Linux
2013-09-02 14:57           ` Russell King - ARM Linux
2013-09-02 16:41             ` Mark Brown
2013-08-31 20:45     ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1VFkWe-0003Iw-UI@rmk-PC.arm.linux.org.uk \
    --to=rmk+kernel@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).