From: rmk+kernel@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] imx-drm: hdmi: get rid of clk manipulations in imx_hdmi_fb_registered()
Date: Wed, 30 Oct 2013 20:44:09 +0000 [thread overview]
Message-ID: <E1Vbccb-00062v-IX@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20131030193622.GN16735@n2100.arm.linux.org.uk>
The clock manipulations do nothing for us: the clock is already enabled
by the only caller (imx_hdmi_platform_probe()). Get rid of these and
simplify the code.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/staging/imx-drm/imx-hdmi.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/imx-drm/imx-hdmi.c
index 267d3c9114c6..1eb12c57aa3e 100644
--- a/drivers/staging/imx-drm/imx-hdmi.c
+++ b/drivers/staging/imx-drm/imx-hdmi.c
@@ -1448,12 +1448,6 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
/* Wait until we are registered to enable interrupts */
static int imx_hdmi_fb_registered(struct imx_hdmi *hdmi)
{
- int ret;
-
- ret = clk_prepare_enable(hdmi->iahb_clk);
- if (ret)
- return ret;
-
hdmi_writeb(hdmi, HDMI_PHY_I2CM_INT_ADDR_DONE_POL,
HDMI_PHY_I2CM_INT_ADDR);
@@ -1470,8 +1464,6 @@ static int imx_hdmi_fb_registered(struct imx_hdmi *hdmi)
/* Unmute interrupts */
hdmi_writeb(hdmi, ~HDMI_IH_PHY_STAT0_HPD, HDMI_IH_MUTE_PHY_STAT0);
- clk_disable_unprepare(hdmi->iahb_clk);
-
return 0;
}
--
1.7.4.4
next prev parent reply other threads:[~2013-10-30 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1382992009-19407-1-git-send-email-festevam@gmail.com>
2013-10-28 21:03 ` [PATCH v3] imx-drm: Add mx6 hdmi transmitter support Greg KH
2013-10-29 22:01 ` Fabio Estevam
2013-10-29 23:47 ` Russell King - ARM Linux
2013-10-30 1:00 ` Fabio Estevam
2013-10-28 21:19 ` Russell King - ARM Linux
2013-10-29 15:00 ` Fabio Estevam
2013-10-29 15:45 ` Fabio Estevam
2013-10-29 18:53 ` Russell King - ARM Linux
2013-10-30 19:36 ` Russell King - ARM Linux
2013-10-30 20:39 ` Russell King - ARM Linux
2013-10-30 20:39 ` [PATCH 1/6] imx-drm: hdmi: fix PLL lock wait Russell King
2013-10-30 20:41 ` [PATCH 2/6] imx-drm: hdmi: fix pixel clock Russell King
2013-10-30 20:42 ` [PATCH 3/6] imx-drm: hdmi: fix wrong comment Russell King
2013-10-30 20:43 ` [PATCH 4/6] imx-drm: hdmi: get rid of pointless fb_reg Russell King
2013-10-30 20:44 ` Russell King [this message]
2013-10-30 20:45 ` [PATCH 6/6] imx-drm: hdmi: minor cleanups Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Vbccb-00062v-IX@rmk-PC.arm.linux.org.uk \
--to=rmk+kernel@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).