From: rmk@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH kexec-tools 30/32] arm: fix type of phys_offset
Date: Tue, 03 May 2016 11:23:39 +0100 [thread overview]
Message-ID: <E1axXUR-0004js-5j@e0050434b2927.dyn.arm.linux.org.uk> (raw)
In-Reply-To: <CAHB_GurHc1aVfzJATpNW5yf5s5KkF=t5s09FbWq3+9+ZX39KUg@mail.gmail.com>
Some LPAE systems may have phys_offset above the 4GB mark. Hence, we
need phys_offset to be a 64-bit integer.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
---
kexec/arch/arm/crashdump-arm.c | 4 ++--
kexec/arch/arm/crashdump-arm.h | 1 -
kexec/arch/arm/phys_to_virt.c | 4 +++-
kexec/arch/arm/phys_to_virt.h | 8 ++++++++
4 files changed, 13 insertions(+), 4 deletions(-)
create mode 100644 kexec/arch/arm/phys_to_virt.h
diff --git a/kexec/arch/arm/crashdump-arm.c b/kexec/arch/arm/crashdump-arm.c
index 2dc8846..2589582 100644
--- a/kexec/arch/arm/crashdump-arm.c
+++ b/kexec/arch/arm/crashdump-arm.c
@@ -33,6 +33,7 @@
#include "../../mem_regions.h"
#include "crashdump-arm.h"
#include "iomem.h"
+#include "phys_to_virt.h"
#if __BYTE_ORDER == __LITTLE_ENDIAN
#define ELFDATANATIVE ELFDATA2LSB
@@ -70,7 +71,6 @@ static struct crash_elf_info elf_info = {
.page_offset = DEFAULT_PAGE_OFFSET,
};
-unsigned long phys_offset;
extern unsigned long long user_page_offset;
/* Retrieve kernel _stext symbol virtual address from /proc/kallsyms */
@@ -293,7 +293,7 @@ int load_crashdump_segments(struct kexec_info *info, char *mod_cmdline)
* region as PHYS_OFFSET.
*/
phys_offset = usablemem_rgns.ranges->start;
- dbgprintf("phys_offset: %#lx\n", phys_offset);
+ dbgprintf("phys_offset: %#llx\n", phys_offset);
if (get_kernel_page_offset(info, &elf_info))
return -1;
diff --git a/kexec/arch/arm/crashdump-arm.h b/kexec/arch/arm/crashdump-arm.h
index 7314960..6e87b13 100644
--- a/kexec/arch/arm/crashdump-arm.h
+++ b/kexec/arch/arm/crashdump-arm.h
@@ -16,7 +16,6 @@ extern struct memory_ranges usablemem_rgns;
struct kexec_info;
-extern unsigned long phys_offset;
extern int load_crashdump_segments(struct kexec_info *, char *);
#ifdef __cplusplus
diff --git a/kexec/arch/arm/phys_to_virt.c b/kexec/arch/arm/phys_to_virt.c
index c2fe2ea..46a4f68 100644
--- a/kexec/arch/arm/phys_to_virt.c
+++ b/kexec/arch/arm/phys_to_virt.c
@@ -1,6 +1,8 @@
#include "../../kexec.h"
#include "../../crashdump.h"
-#include "crashdump-arm.h"
+#include "phys_to_virt.h"
+
+uint64_t phys_offset;
/**
* phys_to_virt() - translate physical address to virtual address
diff --git a/kexec/arch/arm/phys_to_virt.h b/kexec/arch/arm/phys_to_virt.h
new file mode 100644
index 0000000..b3147dd
--- /dev/null
+++ b/kexec/arch/arm/phys_to_virt.h
@@ -0,0 +1,8 @@
+#ifndef PHYS_TO_VIRT_H
+#define PHYS_TO_VIRT_H
+
+#include <stdint.h>
+
+extern uint64_t phys_offset;
+
+#endif
--
1.9.1
next prev parent reply other threads:[~2016-05-03 10:23 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 9:26 [PATCH 00/12] Fixing TI Keystone2 kexec Russell King - ARM Linux
2016-04-28 9:27 ` [PATCH 01/12] ARM: kexec: fix crashkernel= handling Russell King
2016-04-29 14:17 ` Pratyush Anand
2016-04-28 9:27 ` [PATCH 02/12] ARM: provide improved virt_to_idmap() functionality Russell King
2016-04-28 9:27 ` [PATCH 03/12] ARM: kexec: remove 512MB restriction on kexec crashdump Russell King
2016-04-29 14:19 ` Pratyush Anand
2016-04-29 18:10 ` Russell King - ARM Linux
2016-04-30 3:36 ` Pratyush Anand
2016-04-30 8:25 ` Russell King - ARM Linux
2016-04-28 9:28 ` [PATCH 04/12] ARM: provide arm_has_idmap_alias() helper Russell King
2016-04-29 14:21 ` Pratyush Anand
2016-04-28 9:28 ` [PATCH 05/12] ARM: kdump: advertise boot aliased crash kernel resource Russell King
2016-04-28 9:28 ` [PATCH 06/12] ARM: kexec: advertise location of bootable RAM Russell King
2016-04-29 14:56 ` Pratyush Anand
2016-04-29 18:00 ` Russell King - ARM Linux
2016-04-30 3:27 ` Pratyush Anand
2016-04-30 8:20 ` Russell King - ARM Linux
2016-05-02 7:34 ` Pratyush Anand
2016-05-02 10:10 ` Russell King - ARM Linux
2016-05-02 10:48 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 01/32] kdump: mmap() and munmap() only work on page-aligned quantites Russell King
2016-05-25 6:16 ` Pratyush Anand
2016-05-26 8:35 ` Russell King - ARM Linux
2016-05-03 10:21 ` [PATCH kexec-tools 02/32] kdump: fix multiple program header entries Russell King
2016-05-25 6:16 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 03/32] kdump: actually write out the memory Russell King
2016-05-25 6:16 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 04/32] kdump: fix kdump mapping Russell King
2016-05-25 6:17 ` Pratyush Anand
2016-05-26 14:33 ` Russell King - ARM Linux
2016-05-03 10:21 ` [PATCH kexec-tools 05/32] arm: fix kdump to work on LPAE systems Russell King
2016-05-28 11:28 ` Baoquan He
2016-05-03 10:21 ` [PATCH kexec-tools 06/32] kdump: print mmap() offset in hex Russell King
2016-05-25 6:21 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 07/32] kexec: fix warnings caused by selecting 64-bit file IO on 32-bit platforms Russell King
2016-05-28 11:33 ` Baoquan He
2016-05-28 13:53 ` Russell King - ARM Linux
2016-05-29 13:29 ` Baoquan He
2016-05-03 10:21 ` [PATCH kexec-tools 08/32] kexec: add max_size to memory_ranges Russell King
2016-05-27 11:43 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 09/32] kexec: phys_to_virt() must take unsigned long long Russell King
2016-05-25 6:31 ` Pratyush Anand
2016-05-03 10:21 ` [PATCH kexec-tools 10/32] kexec: add generic helper to add to memory_regions Russell King
2016-05-25 8:00 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 11/32] kexec: add mem_regions sorting implementation Russell King
2016-05-25 8:00 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 12/32] kexec: add helper to exlude a region from a set of memory ranges Russell King
2016-05-25 8:00 ` Pratyush Anand
2016-05-26 8:56 ` Russell King - ARM Linux
2016-05-27 15:07 ` Pratyush Anand
2016-05-27 15:12 ` Russell King - ARM Linux
2016-05-03 10:22 ` [PATCH kexec-tools 13/32] arm: fix pointer signedness warning in kexec-uImage-arm.c Russell King
2016-05-25 8:00 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 14/32] arm: fix off-by-one on memory end Russell King
2016-05-25 8:01 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 15/32] arm: fix get_kernel_stext_sym() to close its file Russell King
2016-05-25 8:01 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 16/32] arm: fix ELF32/ELF64 check Russell King
2016-05-03 10:22 ` [PATCH kexec-tools 17/32] arm: return proper error for missing crash kernel Russell King
2016-05-27 11:27 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 18/32] arm: report if crash kernel is out of bounds Russell King
2016-05-27 11:27 ` Pratyush Anand
2016-05-27 13:36 ` Russell King - ARM Linux
2016-05-03 10:22 ` [PATCH kexec-tools 19/32] arm: add memory ranges debug Russell King
2016-05-27 11:28 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 20/32] arm: add maximum number of memory ranges Russell King
2016-05-27 11:29 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 21/32] arm: parse crash_reserved_mem early Russell King
2016-05-27 11:30 ` Pratyush Anand
2016-05-03 10:22 ` [PATCH kexec-tools 22/32] arm: use generic mem_region sorting implementation Russell King
2016-05-27 11:30 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 23/32] arm: move crash system RAM parsing earlier Russell King
2016-05-27 11:33 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 24/32] arm: add support for platforms with boot memory aliases Russell King
2016-05-27 11:34 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 25/32] arm: crashdump needs boot alias of crash kernel region Russell King
2016-05-27 11:34 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 26/32] arm: rename crash_reserved_mem to crash_kernel_mem Russell King
2016-05-27 11:36 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 27/32] arm: add support for multiple reserved regions Russell King
2016-05-27 11:37 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 28/32] arm: add support for boot-time crash kernel resource Russell King
2016-05-27 11:37 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 29/32] arm: add debug of reserved and coredump memory ranges Russell King
2016-05-27 11:35 ` Pratyush Anand
2016-05-03 10:23 ` Russell King [this message]
2016-05-27 11:38 ` [PATCH kexec-tools 30/32] arm: fix type of phys_offset Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 31/32] arm: clean up phys/page offset debug Russell King
2016-05-27 11:38 ` Pratyush Anand
2016-05-03 10:23 ` [PATCH kexec-tools 32/32] arm: report which ELF core format we will use Russell King
2016-05-27 11:38 ` Pratyush Anand
2016-05-03 10:29 ` [PATCH 06/12] ARM: kexec: advertise location of bootable RAM Russell King - ARM Linux
2016-04-28 9:28 ` [PATCH 07/12] ARM: keystone: dts: add psci command definition Russell King
2016-04-28 9:28 ` [PATCH 08/12] kexec: don't invoke OOM-killer for control page allocation Russell King
2016-04-29 14:57 ` Pratyush Anand
2016-04-28 9:28 ` [PATCH 09/12] kexec: ensure user memory sizes do not wrap Russell King
2016-04-29 14:57 ` Pratyush Anand
2016-04-28 9:28 ` [PATCH 10/12] kexec: arrange for paddr_vmcoreinfo_note() to return phys_addr_t Russell King
2016-04-29 15:06 ` Pratyush Anand
2016-04-29 15:16 ` Mark Rutland
2016-04-29 15:47 ` Pratyush Anand
2016-05-03 4:24 ` Baoquan He
2016-05-03 5:53 ` Pratyush Anand
2016-05-03 9:01 ` Baoquan He
2016-05-03 10:12 ` Russell King - ARM Linux
2016-05-03 12:56 ` Baoquan He
2016-04-29 18:06 ` Russell King - ARM Linux
2016-04-30 3:30 ` Pratyush Anand
2016-04-28 9:28 ` [PATCH 11/12] kexec: allow architectures to override boot mapping Russell King
2016-04-29 15:14 ` Pratyush Anand
2016-04-29 18:08 ` Russell King - ARM Linux
2016-05-11 18:56 ` Russell King - ARM Linux
2016-05-12 6:26 ` Baoquan He
2016-05-12 8:22 ` Russell King - ARM Linux
2016-04-28 9:28 ` [PATCH 12/12] ARM: kexec: fix kexec for Keystone 2 Russell King
2016-04-28 23:04 ` [PATCH 00/12] Fixing TI Keystone2 kexec Simon Horman
2016-05-11 8:29 ` Dave Young
2016-05-11 8:52 ` Russell King - ARM Linux
2016-05-11 9:13 ` Dave Young
2016-05-11 9:32 ` Russell King - ARM Linux
2016-05-11 10:31 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1axXUR-0004js-5j@e0050434b2927.dyn.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).