* [PATCH] ARM: always enable AEABI for ARMv6+
@ 2017-06-22 9:12 Russell King
2017-06-22 9:59 ` Robin Murphy
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2017-06-22 9:12 UTC (permalink / raw)
To: linux-arm-kernel
Always enable AEABI for ARMv6+, as these use the double-word exclusives
which must be passed an even register to avoid errors such as:
/tmp/ccG2rCwe.s:905: Error: even register required -- `ldrexd r5,r6,[r7]'
/tmp/ccG2rCwe.s:909: Error: even register required -- `strexd sl,r3,r4,[r7]'
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
arch/arm/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 270ab2549def..78e42f691270 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1542,7 +1542,6 @@ config THUMB2_KERNEL
bool "Compile the kernel in Thumb-2 mode" if !CPU_THUMBONLY
depends on (CPU_V7 || CPU_V7M) && !CPU_V6 && !CPU_V6K
default y if CPU_THUMBONLY
- select AEABI
select ARM_ASM_UNIFIED
select ARM_UNWIND
help
@@ -1605,7 +1604,8 @@ config ARM_PATCH_IDIV
code to do integer division.
config AEABI
- bool "Use the ARM EABI to compile the kernel"
+ bool "Use the ARM EABI to compile the kernel" if !THUMB2_KERNEL && !CPU_V7 && !CPU_V7M && !CPU_V6 && !CPU_V6K
+ default THUMB2_KERNEL || CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K
help
This option allows for the kernel to be compiled using the latest
ARM ABI (aka EABI). This is only useful if you are using a user
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: always enable AEABI for ARMv6+
2017-06-22 9:12 [PATCH] ARM: always enable AEABI for ARMv6+ Russell King
@ 2017-06-22 9:59 ` Robin Murphy
0 siblings, 0 replies; 3+ messages in thread
From: Robin Murphy @ 2017-06-22 9:59 UTC (permalink / raw)
To: linux-arm-kernel
On 22/06/17 10:12, Russell King wrote:
> Always enable AEABI for ARMv6+, as these use the double-word exclusives
> which must be passed an even register to avoid errors such as:
>
> /tmp/ccG2rCwe.s:905: Error: even register required -- `ldrexd r5,r6,[r7]'
> /tmp/ccG2rCwe.s:909: Error: even register required -- `strexd sl,r3,r4,[r7]'
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> arch/arm/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 270ab2549def..78e42f691270 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1542,7 +1542,6 @@ config THUMB2_KERNEL
> bool "Compile the kernel in Thumb-2 mode" if !CPU_THUMBONLY
> depends on (CPU_V7 || CPU_V7M) && !CPU_V6 && !CPU_V6K
> default y if CPU_THUMBONLY
> - select AEABI
> select ARM_ASM_UNIFIED
> select ARM_UNWIND
> help
> @@ -1605,7 +1604,8 @@ config ARM_PATCH_IDIV
> code to do integer division.
>
> config AEABI
> - bool "Use the ARM EABI to compile the kernel"
> + bool "Use the ARM EABI to compile the kernel" if !THUMB2_KERNEL && !CPU_V7 && !CPU_V7M && !CPU_V6 && !CPU_V6K
Isn't !THUMB2_KERNEL already a strict subset of !CPU_V7 && !CPU_V7M?
Robin.
> + default THUMB2_KERNEL || CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K
> help
> This option allows for the kernel to be compiled using the latest
> ARM ABI (aka EABI). This is only useful if you are using a user
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: always enable AEABI for ARMv6+
@ 2017-07-20 9:18 Russell King
0 siblings, 0 replies; 3+ messages in thread
From: Russell King @ 2017-07-20 9:18 UTC (permalink / raw)
To: linux-arm-kernel
Always enable AEABI for ARMv6+, as these use the double-word exclusives
which must be passed an even register to avoid errors such as:
/tmp/ccG2rCwe.s:905: Error: even register required -- `ldrexd r5,r6,[r7]'
/tmp/ccG2rCwe.s:909: Error: even register required -- `strexd sl,r3,r4,[r7]'
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
arch/arm/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 270ab2549def..edb88d430b24 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1542,7 +1542,6 @@ config THUMB2_KERNEL
bool "Compile the kernel in Thumb-2 mode" if !CPU_THUMBONLY
depends on (CPU_V7 || CPU_V7M) && !CPU_V6 && !CPU_V6K
default y if CPU_THUMBONLY
- select AEABI
select ARM_ASM_UNIFIED
select ARM_UNWIND
help
@@ -1605,7 +1604,8 @@ config ARM_PATCH_IDIV
code to do integer division.
config AEABI
- bool "Use the ARM EABI to compile the kernel"
+ bool "Use the ARM EABI to compile the kernel" if !CPU_V7 && !CPU_V7M && !CPU_V6 && !CPU_V6K
+ default CPU_V7 || CPU_V7M || CPU_V6 || CPU_V6K
help
This option allows for the kernel to be compiled using the latest
ARM ABI (aka EABI). This is only useful if you are using a user
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-20 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-22 9:12 [PATCH] ARM: always enable AEABI for ARMv6+ Russell King
2017-06-22 9:59 ` Robin Murphy
-- strict thread matches above, loose matches on Subject: below --
2017-07-20 9:18 Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox