From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
"Alvin __ipraga" <alsi@bang-olufsen.dk>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
DENG Qingfang <dqfext@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
George McCollister <george.mccollister@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>,
Landen Chao <Landen.Chao@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Sean Wang <sean.wang@mediatek.com>,
UNGLinuxDriver@microchip.com,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>
Subject: [PATCH RFC net-next 3/4] net: phylink: add phylink_set_max_fixed_link()
Date: Fri, 24 Jun 2022 12:42:04 +0100 [thread overview]
Message-ID: <E1o4hhM-004Aoy-Df@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YrWi5oBFn7vR15BH@shell.armlinux.org.uk>
Add a function for DSA to use to configure phylink, in the absence of
any other configuration, to a fixed link operating at the maximum
supported link speed.
This is needed so we can support phylink usage on CPU and DSA ports.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/phylink.c | 83 +++++++++++++++++++++++++++++++++++++++
include/linux/phylink.h | 2 +
2 files changed, 85 insertions(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index e20cdab824db..bd9f09cfc281 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1317,6 +1317,89 @@ void phylink_destroy(struct phylink *pl)
}
EXPORT_SYMBOL_GPL(phylink_destroy);
+static struct {
+ unsigned long fd_mask;
+ unsigned long hd_mask;
+ int speed;
+} phylink_caps_speeds[] = {
+ { MAC_400000FD, 0, SPEED_400000 },
+ { MAC_200000FD, 0, SPEED_200000 },
+ { MAC_100000FD, 0, SPEED_100000 },
+ { MAC_56000FD, 0, SPEED_56000 },
+ { MAC_50000FD, 0, SPEED_50000 },
+ { MAC_40000FD, 0, SPEED_40000 },
+ { MAC_25000FD, 0, SPEED_40000 },
+ { MAC_20000FD, 0, SPEED_20000 },
+ { MAC_10000FD, 0, SPEED_10000 },
+ { MAC_5000FD, 0, SPEED_5000 },
+ { MAC_2500FD, 0, SPEED_2500 },
+ { MAC_1000FD, MAC_1000HD, SPEED_1000 },
+ { MAC_100FD, MAC_100HD, SPEED_100 },
+ { MAC_10FD, MAC_10HD, SPEED_10 },
+};
+
+/**
+ * phylink_set_max_fixed_link() - set a fixed link configuration for phylink
+ * @pl: a pointer to a &struct phylink returned from phylink_create()
+ *
+ * Set a maximum speed fixed-link configuration for the chosen interface
+ * mode and MAC capabilities for the phylink instance. Only valid for use
+ * immediately after creation. Must not be used at any other time.
+ *
+ * The user must have initialised mac_capabilities and set a valid interface.
+ */
+int phylink_set_max_fixed_link(struct phylink *pl)
+{
+ unsigned long caps;
+ int speed, duplex;
+ int i;
+
+ /* If we are not in PHY mode, or have a PHY, or have a SFP bus,
+ * then we must not default to a fixed link.
+ */
+ if (pl->cfg_link_an_mode != MLO_AN_PHY || pl->phydev || pl->sfp_bus)
+ return -EBUSY;
+
+ /* Get the speed/duplex capabilities and reduce according to the
+ * interface mode.
+ */
+ caps = pl->config->mac_capabilities;
+ caps &= ~(MAC_SYM_PAUSE | MAC_ASYM_PAUSE);
+ caps &= phylink_interface_to_caps(pl->link_config.interface);
+
+ /* If there are no capabilities, then we are not using this default. */
+ if (!caps)
+ return -EINVAL;
+
+ /* Decode to fastest speed and duplex */
+ duplex = DUPLEX_UNKNOWN;
+ speed = SPEED_UNKNOWN;
+ for (i = 0; i < ARRAY_SIZE(phylink_caps_speeds); i++) {
+ if (caps & phylink_caps_speeds[i].fd_mask) {
+ duplex = DUPLEX_FULL;
+ speed = phylink_caps_speeds[i].speed;
+ break;
+ } else if (caps & phylink_caps_speeds[i].hd_mask) {
+ duplex = DUPLEX_HALF;
+ speed = phylink_caps_speeds[i].speed;
+ break;
+ }
+ }
+
+ /* If we didn't find anything, bail. */
+ if (speed == SPEED_UNKNOWN)
+ return -EINVAL;
+
+ pl->link_config.speed = speed;
+ pl->link_config.duplex = duplex;
+ pl->link_config.link = 1;
+ pl->cfg_link_an_mode = MLO_AN_FIXED;
+ pl->cur_link_an_mode = MLO_AN_FIXED;
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(phylink_set_max_fixed_link);
+
static void phylink_phy_change(struct phy_device *phydev, bool up)
{
struct phylink *pl = phydev->phylink;
diff --git a/include/linux/phylink.h b/include/linux/phylink.h
index 6d06896fc20d..145fec38ad90 100644
--- a/include/linux/phylink.h
+++ b/include/linux/phylink.h
@@ -529,6 +529,8 @@ struct phylink *phylink_create(struct phylink_config *, struct fwnode_handle *,
const struct phylink_mac_ops *mac_ops);
void phylink_destroy(struct phylink *);
+int phylink_set_max_fixed_link(struct phylink *pl);
+
int phylink_connect_phy(struct phylink *, struct phy_device *);
int phylink_of_phy_connect(struct phylink *, struct device_node *, u32 flags);
int phylink_fwnode_phy_connect(struct phylink *pl,
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-24 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 11:41 [PATCH RFC net-next 0/4] net: dsa: always use phylink Russell King (Oracle)
2022-06-24 11:41 ` [PATCH RFC net-next 1/4] net: dsa: add support for retrieving the interface mode Russell King (Oracle)
2022-06-24 11:41 ` [PATCH RFC net-next 2/4] net: dsa: mv88e6xxx: report the default interface mode for the port Russell King (Oracle)
2022-06-24 11:42 ` Russell King (Oracle) [this message]
2022-06-24 11:42 ` [PATCH RFC net-next 4/4] net: dsa: always use phylink for CPU and DSA ports Russell King (Oracle)
2022-06-28 21:16 ` [PATCH RFC net-next 0/4] net: dsa: always use phylink Russell King (Oracle)
2022-06-29 7:18 ` Andrew Lunn
2022-06-29 9:27 ` Marek Behún
2022-06-29 9:34 ` Russell King (Oracle)
2022-06-29 9:42 ` Marek Behún
2022-06-29 9:43 ` Russell King (Oracle)
2022-06-29 10:10 ` Marek Behún
2022-06-29 12:41 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1o4hhM-004Aoy-Df@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).