From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Halaney <ahalaney@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jose Abreu <joabreu@synopsys.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Romain Gantois <romain.gantois@bootlin.com>
Subject: [PATCH net-next 5/5] net: stmmac: clean up stmmac_mac_select_pcs()
Date: Mon, 10 Jun 2024 15:40:54 +0100 [thread overview]
Message-ID: <E1sGgCc-00FadB-Ch@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ZmcQTuR5IKRp0pgy@shell.armlinux.org.uk>
Since all platform providers of PCS now populate the select_pcs()
method, there is no need for the common code to look at
priv->hw->phylink_pcs, so remove it.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index e9e2a95c91a3..5ddbb0d44373 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -957,7 +957,7 @@ static struct phylink_pcs *stmmac_mac_select_pcs(struct phylink_config *config,
return pcs;
}
- return priv->hw->phylink_pcs;
+ return NULL;
}
static void stmmac_mac_config(struct phylink_config *config, unsigned int mode,
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-10 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 14:40 [PATCH net-next 0/5] net: stmmac: provide platform select_pcs method Russell King (Oracle)
2024-06-10 14:40 ` [PATCH net-next 1/5] net: stmmac: add select_pcs() platform method Russell King (Oracle)
2024-06-11 7:36 ` Romain Gantois
2024-06-10 14:40 ` [PATCH net-next 2/5] net: stmmac: dwmac-intel: provide a select_pcs() implementation Russell King (Oracle)
2024-06-11 7:40 ` Romain Gantois
2024-06-13 10:33 ` Russell King (Oracle)
2024-06-11 11:10 ` kernel test robot
2024-06-11 14:32 ` kernel test robot
2024-06-11 15:41 ` kernel test robot
2024-06-11 17:19 ` Andy Shevchenko
2024-06-10 14:40 ` [PATCH net-next 3/5] net: stmmac: dwmac-rzn1: provide " Russell King (Oracle)
2024-06-11 7:41 ` Romain Gantois
2024-06-10 14:40 ` [PATCH net-next 4/5] net: stmmac: dwmac-socfpga: " Russell King (Oracle)
2024-06-11 7:45 ` Romain Gantois
2024-06-10 14:40 ` Russell King (Oracle) [this message]
2024-06-11 7:46 ` [PATCH net-next 5/5] net: stmmac: clean up stmmac_mac_select_pcs() Romain Gantois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1sGgCc-00FadB-Ch@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).