From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Abhishek Chauhan <quic_abchauha@quicinc.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Alexis Lothore <alexis.lothore@bootlin.com>,
"Alexis Lothor__" <alexis.lothore@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Daniel Machon <daniel.machon@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Furong Xu <0x1207@gmail.com>, Huacai Chen <chenhuacai@kernel.org>,
Inochi Amaoto <inochiama@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
"Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>,
Jisheng Zhang <jszhang@kernel.org>, Kees Cook <kees@kernel.org>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
Matthew Gerlach <matthew.gerlach@altera.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Oleksij Rempel <o.rempel@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Rohan G Thomas <rohan.g.thomas@altera.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Simon Horman <horms@kernel.org>,
Song Yoong Siang <yoong.siang.song@intel.com>,
Swathi K S <swathi.ks@samsung.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH RFC net-next v2 19/19] net: stmmac: add support specifying PCS supported interfaces
Date: Sun, 28 Sep 2025 10:21:41 +0100 [thread overview]
Message-ID: <E1v2nbB-00000007oM3-2PPb@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aNj8U4xPJ0JepmZs@shell.armlinux.org.uk>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 7 ++++++-
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 7 ++++++-
drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c | 6 ++++--
drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 3 ++-
4 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index a2ae136d2c0e..0d85902bafd0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -24,12 +24,17 @@
static int dwmac1000_pcs_init(struct stmmac_priv *priv)
{
+ phy_interface_t mode;
+
if (!priv->dma_cap.pcs)
return 0;
+ mode = PHY_INTERFACE_MODE_SGMII;
+
return stmmac_integrated_pcs_init(priv, GMAC_PCS_BASE,
GMAC_INT_DISABLE_PCSLINK |
- GMAC_INT_DISABLE_PCSAN);
+ GMAC_INT_DISABLE_PCSAN,
+ &mode, 1);
}
static void dwmac1000_core_init(struct mac_device_info *hw,
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index a4282fd7c3c7..af9a336a32e6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -24,11 +24,16 @@
static int dwmac4_pcs_init(struct stmmac_priv *priv)
{
+ phy_interface_t mode;
+
if (!priv->dma_cap.pcs)
return 0;
+ mode = PHY_INTERFACE_MODE_SGMII;
+
return stmmac_integrated_pcs_init(priv, GMAC_PCS_BASE,
- GMAC_INT_PCS_LINK | GMAC_INT_PCS_ANE);
+ GMAC_INT_PCS_LINK | GMAC_INT_PCS_ANE,
+ &mode, 1);
}
static void dwmac4_core_init(struct mac_device_info *hw,
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c
index 77d38936d898..5293c52cf7af 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c
@@ -65,7 +65,8 @@ static const struct phylink_pcs_ops dwmac_integrated_pcs_ops = {
};
int stmmac_integrated_pcs_init(struct stmmac_priv *priv, unsigned int offset,
- u32 int_mask)
+ u32 int_mask, const phy_interface_t *modes,
+ int num)
{
struct stmmac_pcs *spcs;
@@ -78,7 +79,8 @@ int stmmac_integrated_pcs_init(struct stmmac_priv *priv, unsigned int offset,
spcs->int_mask = int_mask;
spcs->pcs.ops = &dwmac_integrated_pcs_ops;
- __set_bit(PHY_INTERFACE_MODE_SGMII, spcs->pcs.supported_interfaces);
+ while (num--)
+ __set_bit(*modes++, spcs->pcs.supported_interfaces);
priv->integrated_pcs = spcs;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h
index e42a98162c2b..36da4dab4f8f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h
@@ -63,7 +63,8 @@ phylink_pcs_to_stmmac_pcs(struct phylink_pcs *pcs)
}
int stmmac_integrated_pcs_init(struct stmmac_priv *priv, unsigned int offset,
- u32 int_mask);
+ u32 int_mask, const phy_interface_t *modes,
+ int num);
/**
* dwmac_pcs_isr - TBI, RTBI, or SGMII PHY ISR
--
2.47.3
next prev parent reply other threads:[~2025-09-28 9:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 9:13 [PATCH RFC net-next v2 0/19] net: stmmac: experimental PCS conversion Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 01/19] net: stmmac: remove broken PCS code Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 02/19] net: stmmac: remove xstats.pcs_* members Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 03/19] net: stmmac: remove SGMII/RGMII/SMII interrupt handling Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 04/19] net: stmmac: remove PCS "mode" pause handling Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 05/19] net: stmmac: remove unused PCS loopback support Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 06/19] net: stmmac: remove hw->ps xxx_core_init() hardware setup Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 07/19] net: stmmac: remove RGMII "pcs" mode Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 08/19] net: stmmac: move reverse-"pcs" mode setup to stmmac_check_pcs_mode() Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 09/19] net: stmmac: simplify stmmac_check_pcs_mode() Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 10/19] net: stmmac: hw->ps becomes hw->reverse_sgmii_enable Russell King (Oracle)
2025-09-28 9:20 ` [PATCH RFC net-next v2 11/19] net: stmmac: do not require snps,ps-speed for SGMII Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 12/19] net: stmmac: only call stmmac_pcs_ctrl_ane() for integrated SGMII PCS Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 13/19] net: stmmac: convert to phylink PCS support Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 14/19] net: stmmac: only initialise PCS when present Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 15/19] net: stmmac: add stmmac_mac_irq_modify() Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 16/19] net: stmmac: add support for controlling PCS interrupts Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 17/19] net: stmmac: configure AN control according to phylink Russell King (Oracle)
2025-09-28 9:21 ` [PATCH RFC net-next v2 18/19] net: stmmac: report PCS configuration changes Russell King (Oracle)
2025-09-28 9:21 ` Russell King (Oracle) [this message]
2025-10-03 13:32 ` [PATCH RFC net-next v2 0/19] net: stmmac: experimental PCS conversion Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1v2nbB-00000007oM3-2PPb@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=chenhuacai@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eleanor15x@gmail.com \
--cc=faizal.abdul.rahim@linux.intel.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=inochiama@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mateusz.polchlopek@intel.com \
--cc=matthew.gerlach@altera.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_abchauha@quicinc.com \
--cc=rohan.g.thomas@altera.com \
--cc=shenwei.wang@nxp.com \
--cc=swathi.ks@samsung.com \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=yong.liang.choong@linux.intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).