From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Chen Wang <unicorn_wang@outlook.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Inochi Amaoto <inochiama@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
sophgo@lists.linux.dev
Subject: [PATCH net-next 02/11] net: stmmac: move initialisation of phy_addr to stmmac_plat_dat_alloc()
Date: Fri, 14 Nov 2025 15:28:29 +0000 [thread overview]
Message-ID: <E1vJviv-0000000EVjV-1CLF@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aRdKVMPHXlIn457m@shell.armlinux.org.uk>
Move the default initialisation of plat_dat->phy_addr to
stmmac_plat_dat_alloc().
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 3 ---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 1 -
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 --
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 2d803fa37e21..8593411844bc 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -114,9 +114,6 @@ static void loongson_default_data(struct pci_dev *pdev,
plat->clk_ref_rate = 125000000;
plat->clk_ptp_rate = 125000000;
- /* Default to phy auto-detection */
- plat->phy_addr = -1;
-
plat->dma_cfg->pbl = 32;
plat->dma_cfg->pblx8 = true;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 400b4b955820..1851f7d0702d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -7563,6 +7563,11 @@ struct plat_stmmacenet_data *stmmac_plat_dat_alloc(struct device *dev)
if (!plat_dat)
return NULL;
+ /* Set the defaults:
+ * - phy autodetection
+ */
+ plat_dat->phy_addr = -1;
+
return plat_dat;
}
EXPORT_SYMBOL_GPL(stmmac_plat_dat_alloc);
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
index 622cdbeca20f..b981a9dd511d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
@@ -112,7 +112,6 @@ static int snps_gmac5_default_data(struct pci_dev *pdev,
}
plat->bus_id = 1;
- plat->phy_addr = -1;
plat->phy_interface = PHY_INTERFACE_MODE_GMII;
plat->dma_cfg->pbl = 32;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 38d574907a04..745032fd46ce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -480,8 +480,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
plat->bus_id = ++bus_id;
}
- /* Default to phy auto-detection */
- plat->phy_addr = -1;
/* Default to get clk_csr from stmmac_clk_csr_set(),
* or get clk_csr from device tree.
--
2.47.3
next prev parent reply other threads:[~2025-11-14 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 15:27 [PATCH net-next 00/11] net: stmmac: clean up plat_dat allocation/initialisation Russell King (Oracle)
2025-11-14 15:28 ` [PATCH net-next 01/11] net: stmmac: add stmmac_plat_dat_alloc() Russell King (Oracle)
2025-11-14 15:28 ` Russell King (Oracle) [this message]
2025-11-14 15:28 ` [PATCH net-next 03/11] net: stmmac: move initialisation of clk_csr to stmmac_plat_dat_alloc() Russell King (Oracle)
2025-11-14 15:28 ` [PATCH net-next 04/11] net: stmmac: move initialisation of maxmtu " Russell King (Oracle)
2025-11-14 15:28 ` [PATCH net-next 05/11] net: stmmac: move initialisation of multicast_filter_bins " Russell King (Oracle)
2025-11-14 15:28 ` [PATCH net-next 06/11] net: stmmac: move initialisation of unicast_filter_entries " Russell King (Oracle)
2025-11-14 15:28 ` [PATCH net-next 07/11] net: stmmac: move initialisation of queues_to_use " Russell King (Oracle)
2025-11-14 15:29 ` [PATCH net-next 08/11] net: stmmac: setup default RX channel map in stmmac_plat_dat_alloc() Russell King (Oracle)
2025-11-14 15:29 ` [PATCH net-next 09/11] net: stmmac: remove unnecessary .use_prio queue initialisation Russell King (Oracle)
2025-11-14 15:29 ` [PATCH net-next 10/11] net: stmmac: remove unnecessary .prio " Russell King (Oracle)
2025-11-14 15:29 ` [PATCH net-next 11/11] net: stmmac: remove unnecessary .pkt_route " Russell King (Oracle)
2025-11-18 4:00 ` [PATCH net-next 00/11] net: stmmac: clean up plat_dat allocation/initialisation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1vJviv-0000000EVjV-1CLF@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=inochiama@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sophgo@lists.linux.dev \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).