From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
Ong Boon Leong <boon.leong.ong@intel.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next v2 01/14] net: stmmac: fix channel TSO enable on resume
Date: Wed, 01 Apr 2026 08:21:14 +0100 [thread overview]
Message-ID: <E1w7pt4-0000000Easn-14WL@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aczHVF04LIGq_lYO@shell.armlinux.org.uk>
Rather than configuring the channels depending on whether GSO/TSO is
currently enabled by the user, always enable if the hardware has TSO
support and the platform wants TSO to be enabled.
This avoids the channel TSO enable bit being disabled after a resume
when the user has disabled TSO features. This will cause problems when
the user re-enables TSO.
This bug goes back to commit f748be531d70 ("stmmac: support new GMAC4")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ce51b9c22129..cd76f62e1b6e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3705,7 +3705,7 @@ static int stmmac_hw_setup(struct net_device *dev)
stmmac_set_rings_length(priv);
/* Enable TSO */
- if (priv->tso) {
+ if (priv->dma_cap.tsoen && priv->plat->flags & STMMAC_FLAG_TSO_EN) {
for (chan = 0; chan < tx_cnt; chan++) {
struct stmmac_tx_queue *tx_q = &priv->dma_conf.tx_queue[chan];
--
2.47.3
next prev parent reply other threads:[~2026-04-01 7:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 7:20 [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Russell King (Oracle)
2026-04-01 7:21 ` Russell King (Oracle) [this message]
2026-04-01 7:21 ` [PATCH net-next v2 02/14] net: stmmac: fix .ndo_fix_features() Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 03/14] net: stmmac: fix TSO support when some channels have TBS available Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 04/14] net: stmmac: add stmmac_tso_header_size() Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 05/14] net: stmmac: add TSO check for header length Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 06/14] net: stmmac: add GSO MSS checks Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 07/14] net: stmmac: move TSO VLAN tag insertion to core code Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 08/14] net: stmmac: move check for hardware checksum supported Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 09/14] net: stmmac: simplify GSO/TSO test in stmmac_xmit() Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 10/14] net: stmmac: split out gso features setup Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 11/14] net: stmmac: make stmmac_set_gso_features() more readable Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 12/14] net: stmmac: add warning when TSO is requested but unsupported Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 13/14] net: stmmac: check txpbl for TSO Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 14/14] net: stmmac: move "TSO supported" message to stmmac_set_gso_features() Russell King (Oracle)
2026-04-01 12:19 ` [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Andrew Lunn
2026-04-01 12:41 ` Russell King (Oracle)
2026-04-02 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1w7pt4-0000000Easn-14WL@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox