public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next v2 04/14] net: stmmac: add stmmac_tso_header_size()
Date: Wed, 01 Apr 2026 08:21:29 +0100	[thread overview]
Message-ID: <E1w7ptJ-0000000Eat5-2ZlA@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aczHVF04LIGq_lYO@shell.armlinux.org.uk>

We will need to compute the size of the protocol headers in two places,
so move this into a separate function.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 890a1efb8733..2b5bccc727a5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4373,6 +4373,18 @@ static void stmmac_flush_tx_descriptors(struct stmmac_priv *priv, int queue)
 	stmmac_set_queue_tx_tail_ptr(priv, tx_q, queue, tx_q->cur_tx);
 }
 
+static size_t stmmac_tso_header_size(struct sk_buff *skb)
+{
+	size_t size;
+
+	if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
+		size = skb_transport_offset(skb) + sizeof(struct udphdr);
+	else
+		size = skb_tcp_all_headers(skb);
+
+	return size;
+}
+
 /**
  *  stmmac_tso_xmit - Tx entry point of the driver for oversized frames (TSO)
  *  @skb : the socket buffer
@@ -4444,13 +4456,11 @@ static netdev_tx_t stmmac_tso_xmit(struct sk_buff *skb, struct net_device *dev)
 	first_tx = tx_q->cur_tx;
 
 	/* Compute header lengths */
-	if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4) {
-		proto_hdr_len = skb_transport_offset(skb) + sizeof(struct udphdr);
+	proto_hdr_len = stmmac_tso_header_size(skb);
+	if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
 		hdr = sizeof(struct udphdr);
-	} else {
-		proto_hdr_len = skb_tcp_all_headers(skb);
+	else
 		hdr = tcp_hdrlen(skb);
-	}
 
 	/* Desc availability based on threshold should be enough safe */
 	if (unlikely(stmmac_tx_avail(priv, queue) <
-- 
2.47.3



  parent reply	other threads:[~2026-04-01  7:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  7:20 [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 01/14] net: stmmac: fix channel TSO enable on resume Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 02/14] net: stmmac: fix .ndo_fix_features() Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 03/14] net: stmmac: fix TSO support when some channels have TBS available Russell King (Oracle)
2026-04-01  7:21 ` Russell King (Oracle) [this message]
2026-04-01  7:21 ` [PATCH net-next v2 05/14] net: stmmac: add TSO check for header length Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 06/14] net: stmmac: add GSO MSS checks Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 07/14] net: stmmac: move TSO VLAN tag insertion to core code Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 08/14] net: stmmac: move check for hardware checksum supported Russell King (Oracle)
2026-04-01  7:21 ` [PATCH net-next v2 09/14] net: stmmac: simplify GSO/TSO test in stmmac_xmit() Russell King (Oracle)
2026-04-01  7:22 ` [PATCH net-next v2 10/14] net: stmmac: split out gso features setup Russell King (Oracle)
2026-04-01  7:22 ` [PATCH net-next v2 11/14] net: stmmac: make stmmac_set_gso_features() more readable Russell King (Oracle)
2026-04-01  7:22 ` [PATCH net-next v2 12/14] net: stmmac: add warning when TSO is requested but unsupported Russell King (Oracle)
2026-04-01  7:22 ` [PATCH net-next v2 13/14] net: stmmac: check txpbl for TSO Russell King (Oracle)
2026-04-01  7:22 ` [PATCH net-next v2 14/14] net: stmmac: move "TSO supported" message to stmmac_set_gso_features() Russell King (Oracle)
2026-04-01 12:19 ` [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Andrew Lunn
2026-04-01 12:41   ` Russell King (Oracle)
2026-04-02 18:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1w7ptJ-0000000Eat5-2ZlA@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox