From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Shilimkar, Santosh) Date: Tue, 5 Oct 2010 10:07:52 +0530 Subject: [PATCH 08/10] OMAP: split plat-omap/common.c In-Reply-To: References: <20101001213119.1408.65395.stgit@twilight.localdomain> <20101001213532.1408.55832.stgit@twilight.localdomain> <20101004065624.GD2559@legolas.emea.dhcp.ti.com> <20101004070040.GE2559@legolas.emea.dhcp.ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Paul Walmsley [mailto:paul at pwsan.com] > Sent: Tuesday, October 05, 2010 1:02 AM > To: Shilimkar, Santosh > Cc: Balbi, Felipe; linux-omap at vger.kernel.org; linux-arm- > kernel at lists.infradead.org > Subject: RE: [PATCH 08/10] OMAP: split plat-omap/common.c > > On Mon, 4 Oct 2010, Shilimkar, Santosh wrote: > > > > -----Original Message----- > > > From: Balbi, Felipe > > > Sent: Monday, October 04, 2010 12:31 PM > > > > > > On Mon, Oct 04, 2010 at 01:56:24AM -0500, Balbi, Felipe wrote: > > > > > > > >I still have that sitting on my gitorious tree. The patch is attached > > > >to this mail. I compile tested (only) for omap3_defconfig, it > probably > > > >needs to start using pm_runtime functions at some point and probably > > > >move to drivers/clocksource instead of arch/arm/plat-omap. > > > > > > > >patch is also available at [1] > > > > > > > >[1] git://gitorious.org/usb/usb.git clksource > > > > > > I made a few changes to make checkpatch.pl --strict happy. Attached > > > > > Good !! > > This patch addresses splitting as well as multi-omap builds and probably > > also a better candidate in case we need to convert sync timer to hwmod > > driver. > > > > Paul, what's your take? > > It's great that this is getting cleaned up but it's too late for 2.6.37. > We stop taking new code after -rc6 comes out so we can try to get all of > the changes integrated with each other and fix any bugs. > The patch was lying on the list for quite some time but didn't get much attention before. > The best thing for you and Felipe to do is to convert the driver to use > hwmod data and pm_runtime and test on more platforms, then post it to the > list after 2.6.37 comes out. Probably this make sense. Regards, Santosh