From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE473C43458 for ; Sat, 4 Jul 2026 02:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WqonFV7bjnqVXMcdhLtm8/HTIUbK1zFVwxuknNkA4QU=; b=B/Rib30szyk967M5EYob9Jtd4Q F6EfWLZ/xO+XwrwcLhbgpg26jgYkCnAoEy2XPmeCZciNn5kmtuEo5LhzQPykqL+WF5fOHH9O65x92 KcyjNmf2troY0Ict7/qSro11C698Q6SJtpeE+Cere8rFJccQSYjL6UhgDiJrx808GJru8SfHEXCE5 FgBqtbEMuyWglKVF6T/gB5/fT3frsETJW2YUBYEE0L3ZtCz2horzfXPprD2szTppjUcmvVf48rf2l xN3rJ8QmtzEj76fAP0c8Gm2GdNnHgPMAWK5BJokL6G/OsnIaKMM4uJREefK3iZj3J8Fq3NTjFzCLC CcocC0dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfqO4-0000000879R-05cz; Sat, 04 Jul 2026 02:45:48 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfqO1-0000000878u-3HFH for linux-arm-kernel@lists.infradead.org; Sat, 04 Jul 2026 02:45:47 +0000 Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783133132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqonFV7bjnqVXMcdhLtm8/HTIUbK1zFVwxuknNkA4QU=; b=mswa1nkqFQ9QtW9ww/AdCHgZCDLOSfbp5ZssYIQod1f/1WXquwt1AqR9FlNcbAM/qByYWC WDeKoy6TZu+m5xdVk3qMyxSAIX//ii+S0Ykra0/6NZBU3aK0O9n0LuIUzYcARqr7E/+b1Y xBXBaea+LO3bZ0it+TyRYp/BD2E/NAc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v3 2/6] mm/rmap: use huge_ptep_get() in try_to_unmap_one() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260703114202.365553-3-dev.jain@arm.com> Date: Sat, 4 Jul 2026 10:44:39 +0800 Cc: osalvador@suse.de, akpm@linux-foundation.org, ljs@kernel.org, david@kernel.org, liam@infradead.org, riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kas@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, apopple@nvidia.com, rcampbell@nvidia.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, ak@linux.intel.com, nao.horiguchi@gmail.com, mel@csn.ul.ie, j-nomura@ce.jp.nec.com, pfalcato@suse.de, tglx@kernel.org, dave.hansen@intel.com, jpoimboe@kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260703114202.365553-1-dev.jain@arm.com> <20260703114202.365553-3-dev.jain@arm.com> To: Dev Jain X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260703_194545_972348_A5F54217 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Jul 3, 2026, at 19:41, Dev Jain wrote: >=20 > try_to_unmap_one() handles hugetlb folios when memory failure needs > to replace a poisoned hugetlb mapping with a hwpoison entry. In that > case page_vma_mapped_walk() returns the pte pointer to the hugetlb = folio > in pvmw.pte, but the code reads it with ptep_get(). >=20 > On arches which provide their own huge_ptep_get() to dereference a = huge > pte pointer, accessing via ptep_get() would cause pte_pfn(), = pte_present() > etc to misbehave. >=20 > It is not clear whether this has a trivially visible effect to = userspace. >=20 > Just use huge_ptep_get() for dereferencing a huge pte pointer. >=20 > Fixes: c7ab0d2fdc84 ("mm: convert try_to_unmap_one() to use = page_vma_mapped_walk()") > Cc: stable@vger.kernel.org > Reported-by: David Hildenbrand > Signed-off-by: Dev Jain Reviewed-by: Muchun Song Thanks.