From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C484C432BE for ; Mon, 30 Aug 2021 08:38:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBF296101C for ; Mon, 30 Aug 2021 08:38:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBF296101C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lQg5f65vv0f38A4h0zf9po0pN4P8+ojlyYn1cpfgr7w=; b=R6fv4y1I93Vc3t 9TBCNGENwk1ED4Pd+xyR7ULVcmvSyQSBY2063e9sErvoK2e+tMV1WS/0wmwZy/p6AM6AhEEwk7+uX UhYHZT61zSP4LC4hUWhJcZNcVBoS8UzDz63wYX/YxIxS9KWC8cl0PM2rvbHs/qIyeO39LlF1Mz9JF jc+1yY0FrhBi6fHT8KVeTxtaX3IdbKXkgcOTWbzUO4wImYQh+zefCRCu4KmN5VEThIiDQykclsWLa DroFAxsPGVwtf9YSqzukKj6lA++hTByQnCOf6kn16/m/2zZm8ONos09W1uLJDLjmqZ13J1mga8dd0 5XDGFDgxmyGGumwuP0YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKcm3-00GkoH-D8; Mon, 30 Aug 2021 08:36:11 +0000 Received: from mail-eopbgr1300121.outbound.protection.outlook.com ([40.107.130.121] helo=APC01-HK2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKclu-00GknX-SQ for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 08:36:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SK56sauOhd9EFwxyfBlwWjgmgkDYOxQWa/SahlkrBpNMHz992saD5VJAgwx1h9FOWrPvL+BgnZ9/y6C8qc+BQKqC/1WnSA5T+EyAUS+ZzDLcKM9UnTabeaFLdDHTc0+KmEbeSCOcqVTFcNwSpBtgUsNPYTFPXWvmxcl5XErOya1F3zS00PXJBAHjENf5bmIJJwwazcOgPsGcP+pMf74sNjVeoTovXnamtCJp2JaxLJgNoMsW/dHisxanuVsPbc8zLbMfyK1n6Hfb88BiosVcSKndQmydKrjBEjiIL5470ej99doilJn2cTVWoLY39U951n2tlKNjxwkIURRK1TEfRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAw82U5o9rp1AgnAK7LiqX+JlnihDxwwJZVQDqJk4Vc=; b=SoT3Y1xsJFm8lm7gUCCoLFAlgUckV4joYqyvYxPvADu/GcFUfCaVyy1qxZMq1TYCWCsg09Q5NaKsCmKhGt4fn8V1WW9jnTDr6Fv0Lo1zGJj9BbQi3jZxtfBNjWeSE6nucNVTfr8MaI6Kt5L7mm2i6vI9Vs2Q3kfgVFcNhmlydiC+LrQDCCKCDgomNuFU2sewxlcj/3PFWQa3amS7b1GhnzASNPxWC8+D2eU8YTKB61oZ5F5sLO0fz7JKeEIGmRLKGW288c+eJ3lGf8p4IGN2KHE1kfQAy0vK5xb/Vy7N0/4iEV7s7vxdeDjUNYRWtXnGRNqIoemA0KsFvbky53tFdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAw82U5o9rp1AgnAK7LiqX+JlnihDxwwJZVQDqJk4Vc=; b=F5gh+3DiJdMHzTHN22/u0WkIU4SBLCqu1xfs50YhNl4iq4cGLY6oadBG548Uhxz4NKRMiIaEKbG2FzAps/tK6DDvNI7+p35A4gurkoLdNvgtB2ME+kjJsUXrmZakKld/y2xY9rYk45DZJhvUzzSyvhUjso4Q8zGP5/1dRAI9IJMO2sPl11EQ3b6uebvkkos/TGAvX804WJ64sJRd/rU1pT62J4+huMy9P9BABk3E4GUYF+eo8YOhaZ/NVZgC4g2kKWIJvpRwL36rRJPCrQdMSraC9uRYbwAxQ1HltCmE/8himPcbfiLioUCzDWv3Dm6UN0VVbwaI5I0jSZncwOC9ew== Received: from HK0PR06MB3362.apcprd06.prod.outlook.com (2603:1096:203:8b::10) by HK0PR06MB2130.apcprd06.prod.outlook.com (2603:1096:203:42::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18; Mon, 30 Aug 2021 08:35:53 +0000 Received: from HK0PR06MB3362.apcprd06.prod.outlook.com ([fe80::10fc:291d:32b8:dcb4]) by HK0PR06MB3362.apcprd06.prod.outlook.com ([fe80::10fc:291d:32b8:dcb4%7]) with mapi id 15.20.4436.025; Mon, 30 Aug 2021 08:35:53 +0000 From: Billy Tsai To: Jonathan Cameron CC: "lars@metafoo.de" , "pmeerw@pmeerw.net" , "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "p.zabel@pengutronix.de" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: Re: [RESEND v4 12/15] iio: adc: aspeed: Add func to set sampling rate. Thread-Topic: [RESEND v4 12/15] iio: adc: aspeed: Add func to set sampling rate. Thread-Index: AQHXnOtGanZsbH3nSEydpTOzzlCKGauMQFoA Date: Mon, 30 Aug 2021 08:35:53 +0000 Message-ID: References: <20210824091243.9393-1-billy_tsai@aspeedtech.com> <202108250003.17P03KRU092474@twspam01.aspeedtech.com> <20210829163659.2f7f5974@jic23-huawei> In-Reply-To: <20210829163659.2f7f5974@jic23-huawei> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4f23b9f-12a1-42de-ab24-08d96b912df5 x-ms-traffictypediagnostic: HK0PR06MB2130: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jYS0jA4g5ZjkWwTnW65crgOLvIzjNhwH+RqE0/dfHR+qOyY2Go+/9WeoseX3ntjYY2qvgg+2RevrvetlDLPCahbag+XAz/tNEt2JBVObTv4VPXHYF2KjgzeNt2O7uYgMO4ijP9BuHCYpkTiWgk+9roZfkJ1FNXTcmuwvkzfxCaCFbYDU812AdDotDUM7wdffAfyaD7VtYx7Six19Umz6dk6jdXGZpdfWhMatJbbTozwywhbc5WUEsM8VJyCivAROC58qihQyhfZBhiSesig5EpZcGxGSo8Wy3Xy1kqOysnpwdySjssflQRz8fexVKyf2NsoFybPIkWWlpijBAo20ciSrDwJONt5VJ3eM5QMgZrEbk6qb3jh0MV8Ghfh6z2COUS4iFkiBUyUxoCxTsyG7b0/6Fv6yWcamj+GrUN5sX/pP6ZUMzOrh0ANlhBmQC2gtluyCOnwM8wdp84y/7UD+U9kjW4tf8usZl2BohlMZRslBniPLZ1sd+7/gEwmKDkdtr+l783e+ck54iEi8fGTKqEs2gEqM9usAclrd0r8AWqQiUqUFcS/Ds7txz1minsiTtVBn8w7gm/OxFAB2e19on6pCedgc6WnHg9JBCeFsjYf8tStpBMzYjVsECv5F1o//BJY7phS545dHjCGLPy5V4e8bdwUqHNJ/iw9Zn5/YUiyz0T2WcByvRBEKy3ybOpdd5rUt312f/ctmEfchJsyGz6AVtiWW56TJrFlc0tTiDcNO1RY4lGPbYhIQJusZf+Nw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB3362.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(366004)(136003)(39840400004)(346002)(186003)(76116006)(8936002)(2906002)(6512007)(66556008)(64756008)(66946007)(66476007)(66446008)(2616005)(26005)(4326008)(107886003)(8676002)(71200400001)(6486002)(33656002)(53546011)(122000001)(86362001)(478600001)(7416002)(6506007)(38070700005)(83380400001)(316002)(54906003)(36756003)(6916009)(5660300002)(38100700002)(45980500001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Vm1DMmhzQlIyTWpyUEtBSnBvU3BTMlNhNjZCYXBtK1gwUm5PODVSQld0d1VR?= =?utf-8?B?SFVlMnZ0WUNRTW1FWUFQNi9jUjFxWmlid3M3MWR2M0lFd3RCRk9XUEovVW1E?= =?utf-8?B?MkNiKzZ4VjlDQ1VmWk5KTTViWGE2bmhlZ1BnWlpDQWU1bWZwK0xLOXBLaFVW?= =?utf-8?B?UUYxZmZNWWMwdkNGd24rb3Y0bjJlQmR4VHg1cUUzOUpRMTBIeUF6M1diZWd1?= =?utf-8?B?YnViZmhTd1U2Mmo5UWdVZE40KzVVUXN3ZVJtWWE5UGVsMkMzcXV5b1ZGRW1D?= =?utf-8?B?MTFadlg4WmM5MGQ1V3p3eUEwZ05wdkRES291SWttL0VlekFhNXlHM3J6Z2g3?= =?utf-8?B?K2JIaDFGR3F2bnJYbm5ueUhUaUdRc2szMFBUQjVWb3JkeUhpZ0dtNE5taGZJ?= =?utf-8?B?bWpOTEovOHZTZHFSeWpJYWdYc3VmeUxXUy9jemtNVXEzTjQwbEw1cnFINTVT?= =?utf-8?B?WXNGc0VleU54VmN1a21aWWRBODVwTmhVMEJiZVVDa0Q5WGhBckdVZFpUeG0x?= =?utf-8?B?YjFNUnRtVmdBSTBWeUlLbUZ3Y3ptZ0pSNk9jMEMra1VvYzZ3MGMyaXBJNmh5?= =?utf-8?B?WGwwRHJ1MEt1cm4xQXVzNlppZERHUE9OeUVWSmMwSnB0djUrL3F3RWx1dEcz?= =?utf-8?B?RU53REdlSStwa1lINTBTNmRtRUNRVkl0YS96eWVHQWlHeGRsUFhOdzlwVEdx?= =?utf-8?B?Z3dka2ZreUdLTVVWUTJEQ01EREM2SnVHRXVUQXp6a0QyMlgwbjc4QmlwOGpW?= =?utf-8?B?Z3NQMjdtRFMwWlMzVnJjKzZZbytjK0JEUjl5WDJmcFp5VDJmdXRudGZXeHFN?= =?utf-8?B?aWxOUjNETCt3c3V5dDhsaUlhcllNWlRObHpKbEJIZzhZNFBnbmNJaitYSzdr?= =?utf-8?B?VDVULzhsbEEzZmhaRUFuNDFUNHg5cXFkd3NqRFlkNDBzVGlaRnp3ZWl6cmVH?= =?utf-8?B?MFlxaUVlZkdiSUxyczlhMWVybzNQQ3BnRGVpYVRSdG1BeEpWcWpUQWl6VjBJ?= =?utf-8?B?dzlWa0tYTS9YNTlXZEYzbmRhZFZTMWd2YjR1dGtKSEpMNEJmeDZTS1pLN1RE?= =?utf-8?B?b0JYNzZFcWMwRXJxb1A1NFpVdFJhaUN3emd1b25CeTZJd3lLcXFickZtZHZs?= =?utf-8?B?RDRwZExkNGJ4TU1aMkVkZlVZTWsva1c4U3Q5RUJkQVQrK0ZqdFJ3c01ZTUNO?= =?utf-8?B?bkVuaGNKbVNvSlV0dVhmSzNLeG5VYlVPemVsandpclFIMkNLU01aY2lXQ0tG?= =?utf-8?B?U005MzIvL1BianBOUjhvam9UdkI2VnlVaU0vWXZKMG9wZ0ZmMkxEeVprNVlK?= =?utf-8?B?bWEwLzg3U21ZTmJaK2NOVEt6OVRERTB2b0xTb3BHNldlMmRCcndKT1ZKSlM4?= =?utf-8?B?L1NEYmt4eG56ZEIvWmFScnFlekRtbEV6UzRTNFQwTkd4Uk13MlJYMUFlWWJ1?= =?utf-8?B?Vi9ic0JJMlN4Y2c1L1hHVWkyOG02cEFxa3lkZTFmZnBKaFlCZ0NuQ1RCaU43?= =?utf-8?B?Z1hlMGJGdnJ1cVhHdEVNZXdKVFMxYjFsQSt3cjcwcEtXNDA5WW0ySGpEWVBH?= =?utf-8?B?RUl6c3VqQXFyOUZUWUI5VC94cGtVdDhuMlRGWEJqMVY4UWFyNmhkd3VwOHRj?= =?utf-8?B?RW1JeTNidmhEb24rcTZPMFUwRCttMTZyNjVESmhZQjVLckhMbUpnOURJemZC?= =?utf-8?B?L2NkS3kyMWtSaXF0WVhKYTR5UkFlb3VoNVpzb3pkTTJ4VDNPT1ZFYWlNL2dE?= =?utf-8?B?MEZXRVZxZTQ3RzducWlKMUtKdW9jMGx6cWJPL1p1RXNmM3c5cnFzZktDN2Ri?= =?utf-8?B?bEcxUnZqSFl4VFFKalRWUT09?= Content-ID: <6C82C4700F4F6A44AAC33E05F6FBDC36@apcprd06.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3362.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4f23b9f-12a1-42de-ab24-08d96b912df5 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2021 08:35:53.2602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d9Khiiu73HNFWxol2hQpE8yaHfWW0sjf8jO3OAHVJO4ltNJf97xpSKZChz5MVdT82N3QkvBb0++h3ERlyFdOvYpgvhmG0weWrns46/5OfEY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2130 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_013602_970784_44928A45 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On 2021/8/29, 11:33 PM, "Jonathan Cameron" wrote: On Tue, 24 Aug 2021 17:12:40 +0800 Billy Tsai wrote: >> Add the function to set the sampling rate and keep the sampling period >> for a driver used to wait the lastest value. >> >> Signed-off-by: Billy Tsai > Why move the code as well as factoring out the setter function? > I doubt it does any harm, but I'd like to understand why you did it. > Jonathan >> + ret = clk_prepare_enable(data->clk_scaler->clk); >> + if (ret) >> + return ret; >> + >> + ret = devm_add_action_or_reset(data->dev, >> + aspeed_adc_clk_disable_unprepare, >> + data->clk_scaler->clk); >> + if (ret) >> + return ret; >> + >> + ret = aspeed_adc_set_sampling_rate(indio_dev, ASPEED_ADC_DEF_SAMPLING_RATE); >> + if (ret) >> + return ret; >> + >> ret = aspeed_adc_vref_config(indio_dev); >> if (ret) >> return ret; >> @@ -413,16 +445,6 @@ static int aspeed_adc_probe(struct platform_device *pdev) >> } >> >> /* Start all channels in normal mode. */ > Why move this code up? Because the ADC clock is required when initializing the ADC device. In our system, the clock is always on. Thus, the legacy driver won't encounter any issues. I move the clk_prepare_enable ahead of initializing phase for making the driver probe logically closer to the hardware. >> - ret = clk_prepare_enable(data->clk_scaler->clk); >> - if (ret) >> - return ret; >> - >> - ret = devm_add_action_or_reset(data->dev, >> - aspeed_adc_clk_disable_unprepare, >> - data->clk_scaler->clk); >> - if (ret) >> - return ret; >> - >> adc_engine_control_reg_val = >> readl(data->base + ASPEED_REG_ENGINE_CONTROL); >> adc_engine_control_reg_val |= Best Regards, Billy Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel