From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0FC0ECAAD3 for ; Thu, 1 Sep 2022 21:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QKVuEdT+ogCRMcWel2vKCn+2sEhYeCcgX12wesZiE0Q=; b=cBaYyhIZv6WrUb zuHIeGmdcLV/yVDiQ64cPxfp0PIftbR+Igh1DPsCkjlvdgT9GpuyOFeE69/K1IVvdaC9JPuIqGdLa ZGT40XNu5StGKuIc6YEXgMFCowXHcGYdapQYf8L2OLgBeyAgX9eoqyD22vyy+knSzKKtQrtvorw+R KGgHc+y2jk8Ue3Al5mX8RmU4yzsdvSRa9CMNBllRgcWS5BuJPpwE3FfSURq8/jeTOmkRg667PGkN5 ercgUolqqtFUmsSPC98McvHlRp+fSp+CsmKdvbiAXrebaFFrldDjIJBhdZwKct+TtkdeNQw38sSeI 12ztyQ9fFN7EQq5Fl/fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTs6m-00F2kE-6r; Thu, 01 Sep 2022 21:52:20 +0000 Received: from hutie.ust.cz ([185.8.165.127]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTs6g-00F2ej-2k for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 21:52:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1662069121; bh=6E8Q4wd/LRO3ATv7di2IKGCyLDe3Uj2KYJjxGmXvAqA=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=gGHHpB/Fs7mHD1tU54DYL55+BG8BkevJFoxUvVNqVfi/CcHWEv2z6mMlECabYVQ5s MRl3+QAI682tOWMapOrix6kZd528jR/+1sBSvZF34sryKPgf4YU7IVOzU+qRl5XUjU y6MzgNnMrmoDmJSOmBN1D2ZYP4FPQuyQbFo5jjoU= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs From: =?utf-8?Q?Martin_Povi=C5=A1er?= In-Reply-To: Date: Thu, 1 Sep 2022 23:51:58 +0200 Cc: Russell King , Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Sven Peter Message-Id: References: To: Andy Shevchenko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_145215_131285_328C5A79 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 1. 9. 2022, at 20:55, Andy Shevchenko wrote: > > On Thu, Sep 1, 2022 at 5:17 PM Russell King wrote: >> + ret = apple_smc_write_u32(smcgp->smc, key, CMD_OUTPUT | value); >> + if (ret < 0) >> + dev_err(smcgp->dev, "GPIO set failed %p4ch = 0x%x\n", &key, value); > > Strange specifier... It seems like a hashed pointer with added (or > skipped? I don't remember) '4ch'. Perhaps you meant one of '%pE', > '%p4cc'? > Ditto for other cases. As was pointed out by Sven elsewhere in the thread, this is an unupstreamed specifier (that was missed as a dependency of this code). https://github.com/AsahiLinux/linux/blob/f8c0d18173a7b649999ee27515393f7aae40310c/Documentation/core-api/printk-formats.rst#generic-fourcc-code Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel