From: Cameron Nemo <cnemo@tutanota.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org
Subject: rk3328 USB3 support
Date: Sat, 15 Aug 2020 21:48:51 +0200 (CEST) [thread overview]
Message-ID: <MEnei4S--3-2@tutanota.com> (raw)
Hello all,
I was reading a past discussion about enabling USB3 support for the rk3328 boards:
https://patchwork.kernel.org/patch/10853379/
In the discussions Heiko Stuebner outlined a possible path forward to enabling USB3
for these devices without disrupting rk3399 devices in the future:
> A possible way forward would be to introduce a separate compatible for
> rk3328 (both in the binding doc and the generic dwc3 driver), so that
> we get only a
>
> compatible = "rockchip,rk3328-dwc3";
>
> Which then even can move easily into a new driver if necessary without
> causing issues for existing devicetrees.
I am new to kernel development, but it seems like this is just moving some pieces around.
Specifically I believe I need to:
- edit drivers/usb/dwc3/dwc3-of-simple.c to add "rockchip,rk3328-dwc3" in the two locations
that reference rk3399
- adjust the dtsi in the patch linked above to contain the single compatible line for rk3328
Would that be correct?
Thanks,
--
Cameron Nemo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reply other threads:[~2020-08-15 19:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MEnei4S--3-2@tutanota.com \
--to=cnemo@tutanota.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).