From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3D9C55191 for ; Sun, 26 Apr 2020 12:57:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1310D2071C for ; Sun, 26 Apr 2020 12:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rgobfelQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="AbMvu2fR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1310D2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AGNdaiHUvN1ijmwh4xLURHqFkZvdHyi/z+o0+D0ib88=; b=rgobfelQBtEgVuKNmEpIz8Xws A9g0HQYE9SIBuVeGUKZ7w5ft8CGti2y0SPW1FF80E4VVP9oJmWc2lcBhTbEB1bzrMI2isz9dUh9Nm BDOM2145roFY/R79Hblpd5QkyAZ3beMYR2buvtKPCUWLdMNu6WwqQBOx2XhEYH5FV/dIpMtZZYqWM +e7fqKypcuGkaLzUYqhsLooR2kdhcmYGhEg2/Wxcbft0TJ1MVwbORUtSsmQFXE61e1DEBmGVnld/3 vVZ8azDosx39sEHm6hEnDr42WoyFw77HvvCg/Ji6ZRxOz/sDQ1ibSo4/01NxwQ8to4bxgf3gmp7fb NWSqG/jDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSgqI-0000v4-E5; Sun, 26 Apr 2020 12:57:06 +0000 Received: from outils.crapouillou.net ([89.234.176.41] helo=crapouillou.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSgqF-0000u0-Ew for linux-arm-kernel@lists.infradead.org; Sun, 26 Apr 2020 12:57:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1587905821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VP/mAC4xwNDT9V91K8RLHYB6nE7AooWd1wTlk6uRfp4=; b=AbMvu2fRXjCFm6r4XAiK02os0W+/STwoQ44/jocLsIYNNVAtsKI7bA90aQ74cVvhs5lLan y4d+F5TbWTAuE/jofT7aZmiSn7uZjLRQedgWMMNrNJZDpCXraPxAcOa+Dvq1A+6VE+7OU/ EEEX6kOGv5zhpzoTKdy5z9BpNqSjfRo= Date: Sun, 26 Apr 2020 14:56:47 +0200 From: Paul Cercueil Subject: Re: [PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540 To: "H. Nikolaus Schaller" Message-Id: In-Reply-To: <3fd18c747426e15fd1f3500b9c4adce2db9ddd0c.1587760454.git.hns@goldelico.com> References: <3fd18c747426e15fd1f3500b9c4adce2db9ddd0c.1587760454.git.hns@goldelico.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200426_055703_865006_B9F34C40 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-samsung-soc@vger.kernel.org, letux-kernel@openphoenux.org, Paul Burton , Krzysztof Kozlowski , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?iso-8859-1?q?Beno=EEt?= Cousson , Maxime Ripard , Rob Herring , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, linux-kernel@vger.kernel.org, Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le ven. 24 avril 2020 =E0 22:34, H. Nikolaus Schaller = a =E9crit : > From: Jonathan Bakker > = > All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached. > = > There is no external regulator for it so it can be enabled by default. > = > Signed-off-by: Jonathan Bakker > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > = > diff --git a/arch/arm/boot/dts/s5pv210.dtsi = > b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..abbdda205c1b 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,19 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells =3D <1>; > }; > = > + gpu: gpu@f3000000 { > + compatible =3D "samsung,s5pv210-sgx540-120"; > + reg =3D <0xf3000000 0x10000>; > + interrupt-parent =3D <&vic2>; > + interrupts =3D <10>; > + clock-names =3D "core"; > + clocks =3D <&clocks CLK_G3D>; > + > + assigned-clocks =3D <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates =3D <0>, <66700000>; > + assigned-clock-parents =3D <&clocks MOUT_MPLL>; What are these clocks for, and why are they reparented / reclocked? Shouldn't they be passed to 'clocks' as well? -Paul > + }; > + > fimd: fimd@f8000000 { > compatible =3D "samsung,s5pv210-fimd"; > interrupt-parent =3D <&vic2>; > -- > 2.25.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel