From: g.liakhovetski@gmx.de (Guennadi Liakhovetski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] media: atmel-isi: setup YCC_SWAP correctly when using preview path
Date: Sun, 4 Oct 2015 18:50:15 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1510041849370.26834@axis700.grange> (raw)
In-Reply-To: <1442898875-7147-5-git-send-email-josh.wu@atmel.com>
On Tue, 22 Sep 2015, Josh Wu wrote:
> The preview path only can convert UYVY format to RGB data.
>
> To make preview path work correctly, we need to set up YCC_SWAP
> according to sensor output and convert them to UYVY.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>
> drivers/media/platform/soc_camera/atmel-isi.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
> index bbf6449..e87d354 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -127,6 +127,22 @@ static u32 setup_cfg2_yuv_swap(struct atmel_isi *isi,
> cfg2_yuv_swap = ISI_CFG2_YCC_SWAP_MODE_1;
> break;
> }
> + } else if (xlate->host_fmt->fourcc == V4L2_PIX_FMT_RGB565) {
> + /* Preview path is enabled, it will convert UYVY to RGB format.
> + * But if sensor output format is not UYVY, we need to set
> + * YCC_SWAP_MODE to convert it as UYVY.
> + */
Please, fix multiline comment style:
/*
* ...
* ...
*/
> + switch (xlate->code) {
> + case MEDIA_BUS_FMT_VYUY8_2X8:
> + cfg2_yuv_swap = ISI_CFG2_YCC_SWAP_MODE_1;
> + break;
> + case MEDIA_BUS_FMT_YUYV8_2X8:
> + cfg2_yuv_swap = ISI_CFG2_YCC_SWAP_MODE_2;
> + break;
> + case MEDIA_BUS_FMT_YVYU8_2X8:
> + cfg2_yuv_swap = ISI_CFG2_YCC_SWAP_MODE_3;
> + break;
> + }
> }
>
> return cfg2_yuv_swap;
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-10-04 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 5:14 [PATCH 0/5] media: atmel-isi: enable preview path to output RGB565 format Josh Wu
2015-09-22 5:14 ` [PATCH 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs Josh Wu
2015-10-04 16:43 ` Guennadi Liakhovetski
2015-10-04 17:04 ` Guennadi Liakhovetski
2015-10-14 6:46 ` Josh Wu
2015-10-14 6:43 ` Josh Wu
2015-10-19 1:48 ` Guennadi Liakhovetski
2015-10-19 2:45 ` Josh Wu
2015-09-22 5:14 ` [PATCH 2/5] media: atmel-isi: prepare for the support of preview path Josh Wu
2015-09-22 5:14 ` [PATCH 3/5] media: atmel-isi: add code to setup correct resolution for " Josh Wu
2015-09-22 5:14 ` [PATCH 4/5] media: atmel-isi: setup YCC_SWAP correctly when using " Josh Wu
2015-10-04 16:50 ` Guennadi Liakhovetski [this message]
2015-10-14 6:44 ` Josh Wu
2015-09-22 5:14 ` [PATCH 5/5] media: atmel-isi: support RGB565 output when sensor output YUV formats Josh Wu
2015-10-04 17:02 ` Guennadi Liakhovetski
2015-10-14 6:57 ` Josh Wu
2015-10-19 2:03 ` Guennadi Liakhovetski
2015-10-19 2:50 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1510041849370.26834@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox