From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B30AC433FE for ; Sat, 12 Nov 2022 15:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DxNKNPEFMmOLI0Xz51A42uamQptmc3HDVJEONc8QI3Q=; b=4F8uWa/1h0u+df yDOS8h5JD8ZP1Ku8O/akXPG/v0FHWprDY+/tmGavkaH93EU8OsIdhLFfi7WZ0jn9rYXkFuM6xVH0v j3FOuaMRJrzwhDC/56RktPvKo0I4rzpWy3Ul6mL2gQD7kL/Kf/gF38JHDHYDlVNpCs55lnn74mWDt 9QDxfLXfjkoB0eWszJYjTLvfanOcqtkNUNI/ky+Fn0acrq9Zsaza84DqLFeLnxJED37ZGiFvKzZOM hPLGN+T9Eje4Hyitj/7Ea7DS5BJOX+/B+aCADLyPEsxfXxFTxY8Oa9M3fSZTIDsINy7+e8eurSILQ YJv+tmkJjUSefx/I0Ogg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otscI-006T7q-V8; Sat, 12 Nov 2022 15:40:28 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otsUz-006Q16-G6; Sat, 12 Nov 2022 15:32:54 +0000 Received: by mail-wm1-x32b.google.com with SMTP id t1so4536711wmi.4; Sat, 12 Nov 2022 07:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :references:from:to:cc:subject:date:message-id:reply-to; bh=Lbz4g2YMYSuPD799i5WJED461h5UyiK8NmeMAuncHWI=; b=pLUuOI271qJDl6toNpbkD/sakufpMWz0Z1f6FUcNur+DNeXti+ouc0g2L8VvnDO8nQ uPgCPmENfqW+lVSkFzffR1WMnJkhDi3xx9CZlz+XVX3UyLX6IhimQ3tSyFK4q85V8vCM hpvfAT85kXOtJIJP49Dd87UrV33KnD3Q7AZkrJVmMAY+Gz5/vlbunaobuOv0PLbREMGj ABmR9C8h565egWw7Wn/X2J/QGfOn1yv1siwHC2xdn2Dif+8pNgPxiPCg8ohB2c4yu/8P uQZ7cw+hiDyOpvEob0yKHA/kfyZ7ntqsOp3zPQjpqYCQAcT+R19MEWtPqHY+U62ZyaSj D8Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :references:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lbz4g2YMYSuPD799i5WJED461h5UyiK8NmeMAuncHWI=; b=Zdvw6fU5B3IGfLX05eTDmChJxmBMgokMQ0WgJjFC/Yvd0K6la76OHsSouQqt87aRF2 SEs8h+QMSeCQl10kcCIqoXiM5LIyk+MMpSpf6RJQ3oStswtJT7u7BB4x/2f2vXMKU1EN iS9nzU0xxMEagQ/xGbJb0Lyo1FlF35KAe5TD4139f4GvJ8h4i+ReKY8iVYO6roJgGhK9 9pulzWMZzP8nIGs6NXxBfYxlmawBzvaCHqk5QSa+kmCNOQgZu18Ov9a+H+kfT+azivYu S7jX+Z2yg2k9wmCmDP0/uMDSfJq/C9B0dbRwPuW9vxXpAv/58ZEzakJKw5uqbTGiUlao GTog== X-Gm-Message-State: ANoB5plgo6salNC+ef28cXcYpV6bj8lb62xmfoaWvGTZEpt8vClfcCTr ToQhxoQqP3b5AmrQNYIIvcg= X-Google-Smtp-Source: AA0mqf52EnHFOEUA2r77lvJdUiGNdzE6jW6sJtL+eE1gnyV9rLtfZCgkbIORYBL8FsiWF1jou2n/7Q== X-Received: by 2002:a05:600c:448a:b0:3cf:894b:fe6a with SMTP id e10-20020a05600c448a00b003cf894bfe6amr4213547wmo.198.1668267166645; Sat, 12 Nov 2022 07:32:46 -0800 (PST) Received: from localhost (94.197.38.186.threembb.co.uk. [94.197.38.186]) by smtp.gmail.com with ESMTPSA id r11-20020a5d694b000000b0023691d62cffsm4563556wrw.70.2022.11.12.07.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Nov 2022 07:32:46 -0800 (PST) References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-19-aidanmacdonald.0x0@gmail.com> From: Aidan MacDonald To: lee@kernel.org Cc: mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, brgl@bgdev.pl, mazziesaccount@gmail.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 18/18] mfd: wcd934x: Convert irq chip to config regs Date: Sat, 12 Nov 2022 15:31:14 +0000 In-reply-to: <20221112151835.39059-19-aidanmacdonald.0x0@gmail.com> Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221112_073252_713055_436FF082 X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Type registers are deprecated and will eventually be removed from > regmap-irq. The same functionality can be replicated with config > registers. > > Signed-off-by: Aidan MacDonald > --- > drivers/mfd/wcd934x.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Forgot to include this here:-- One issue with WCD934x - after applying the patch, a bug in regmap-irq will cause a null pointer deref when setting the IRQ type, but a fix is already in the regmap tree. Link: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?id=84498d1fb35de6ab71bdfdb6270a464fb4a0951b > diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c > index 68e2fa2fda99..07e884087f2c 100644 > --- a/drivers/mfd/wcd934x.c > +++ b/drivers/mfd/wcd934x.c > @@ -55,17 +55,22 @@ static const struct regmap_irq wcd934x_irqs[] = { > WCD934X_REGMAP_IRQ_REG(WCD934X_IRQ_SOUNDWIRE, 2, BIT(4)), > }; > > +static const unsigned int wcd934x_config_regs[] = { > + WCD934X_INTR_LEVEL0, > +}; > + > static const struct regmap_irq_chip wcd934x_regmap_irq_chip = { > .name = "wcd934x_irq", > .status_base = WCD934X_INTR_PIN1_STATUS0, > .mask_base = WCD934X_INTR_PIN1_MASK0, > .ack_base = WCD934X_INTR_PIN1_CLEAR0, > - .type_base = WCD934X_INTR_LEVEL0, > - .num_type_reg = 4, > - .type_in_mask = false, > .num_regs = 4, > .irqs = wcd934x_irqs, > .num_irqs = ARRAY_SIZE(wcd934x_irqs), > + .config_base = wcd934x_config_regs, > + .num_config_bases = ARRAY_SIZE(wcd934x_config_regs), > + .num_config_regs = 4, > + .set_type_config = regmap_irq_set_type_config_simple, > }; > > static bool wcd934x_is_volatile_register(struct device *dev, unsigned int reg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel