From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3493DC433DB for ; Tue, 5 Jan 2021 09:41:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE09920757 for ; Tue, 5 Jan 2021 09:40:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE09920757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5y+/m0PHk3AbivbbIKDHDizupzi5MN40enEWC/28JE=; b=HEkPR0A8QXf5MZifSf97XaEBi Qcn5i6kiArce9JsIHUVn4OkGNWiihfQ24o3dgNJSfeBTW5UEAgCW/24XCA73F5uoezdw7JaeAX7ws d3GnAA/C+XO073P6xRPYnRRT+97o8QPbPVLngv2MX+bMj3VyRvzoyUsbCi7MCFisufq6M0mYK/nsG nF9eDXLHfvUeN3uG7FeObaIDs6Oumv/zeXdjiE3nerCmw1XqqgqpuCiMmKCm3dWe6YK9c3I7vbaiV I6aH/JsOjDZ7RLSyKVQ6349VpNJss8e2izdAIc1QhPmXTmaGjSKLoI0RLwXPvq0Rkq8iRJPi0tnOK 1e1Ttlfgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwinn-0001UN-U9; Tue, 05 Jan 2021 09:38:56 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwinl-0001U0-QB for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 09:38:55 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 25FB81BF217; Tue, 5 Jan 2021 09:38:47 +0000 (UTC) Date: Tue, 5 Jan 2021 10:38:47 +0100 From: Paul Kocialkowski To: Sakari Ailus Subject: Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Message-ID: References: <20201231142702.3095260-1-paul.kocialkowski@bootlin.com> <20201231142702.3095260-3-paul.kocialkowski@bootlin.com> <20210104120749.GK11878@paasikivi.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20210104120749.GK11878@paasikivi.fi.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_043853_958705_C954A584 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?B?S8OpdmluIEwnaMO0cGl0YWw=?= , devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Chen-Yu Tsai , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============4121536033449618310==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4121536033449618310== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6HcILEK8wBt0wF+8" Content-Disposition: inline --6HcILEK8wBt0wF+8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sakari, On Mon 04 Jan 21, 14:07, Sakari Ailus wrote: > Hi Paul, >=20 > On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote: > > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 fps. > > Other modes (including some with sub-sampling) are available too. > > It outputs 10-bit bayer CFA data through a MIPI CSI-2 interface with > > up to 4 lanes supported. >=20 > I've added the patches to a pull request to Mauro; there appear to still = be > some checkpatch.pl issues in both of the drivers. >=20 > I don't mind the warnings on the assignment or the mutex though. Could you > address these in additional patches, please? Sorry about that, I realized that I never run checkpatch with --strict so I completely missed those. I'll fix the cosmetic issues in a following patch. Just to clarify one thing: #define OV8865_PAD_PK_DRIVE_STRENGTH_2X (1 << 5) #define OV8865_BLC_CTRL1_COL_SHIFT_128 (1 << 4) these are not single-bit fields so even though it looks like they should use BIT(), this would be incoherent with other possible values, such as: #define OV8865_PAD_PK_DRIVE_STRENGTH_3X (2 << 5) #define OV8865_BLC_CTRL1_COL_SHIFT_64 (2 << 4) Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --6HcILEK8wBt0wF+8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl/0M6cACgkQ3cLmz3+f v9EUdQf8Da/wu2n8zvA1u+eNPTj7TvXm0mjCv4a+wrw36gN8Nvs+Diw7+/oqyRtB AqVH2MKZ6fEOScFyQZcmyW7rnNfGw3NyTAOu84gyb1pEx8CSR/HqkgWT3X9supyI GI6+t15MJ2IaIKn7v2MPbF17N+QodqcvqULzswPDWf1KEgNYUCFL5STdLwQLDIzS nIxkbbyNt3aYQAnOPi6jdan4LaeFNb8jQD2PD01CbcohdINFPxAHMWA5DMt4wFlp 6BJMlTuDCZOdylnpmSZmWuEbszHvjwNuFREHD967hC6AILvZfLx+shgIvlUIs02K DyoCaTT4g37U16GC4rmB3ydBBqjB9A== =vlVD -----END PGP SIGNATURE----- --6HcILEK8wBt0wF+8-- --===============4121536033449618310== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4121536033449618310==--