From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB1FC433E0 for ; Tue, 5 Jan 2021 14:51:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E7D322B49 for ; Tue, 5 Jan 2021 14:51:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E7D322B49 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WAyC+CXUaUizIsWF9oye7O81PIvWepYyg+MXiQ4Wan4=; b=1T6cG8nf4KjZcnFBCVtDKfznq 7rDVQ8cWE2qyQfjQoOaGVMfmYUB0qYQhSNSGKrfKNhDhn7Q+6NwMO6JDwqOkKqiCtEHS22rEDOCtm N3wKrM+2BWKsCJDnbxODB36lKw8Stt1wiDhwxGQ2ZokxJ7BFSttO6r8A08U1wapyqhwGQ3QVb2kiq SRlDnZ47VqrqiHF//X7oF5HsZDxuqOb9jH/YMaX5H2BnKjk8bwSkqmdVYiH2kmAPA+TJRZJOLvji2 Ne8Ht/u/Kpa5Wfw7Q9e1cxCjUCk8r9tkwBzoUJlLc9LM4NdbmIPpLjl7m4/5MXIGwRYxESeg5lXA7 ZzsbTd4FA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwnef-00031X-VT; Tue, 05 Jan 2021 14:49:50 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwnec-000306-VS for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 14:49:48 +0000 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id A24A110000A; Tue, 5 Jan 2021 14:49:41 +0000 (UTC) Date: Tue, 5 Jan 2021 15:49:41 +0100 From: Paul Kocialkowski To: Sakari Ailus Subject: Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Message-ID: References: <20201231142702.3095260-1-paul.kocialkowski@bootlin.com> <20201231142702.3095260-3-paul.kocialkowski@bootlin.com> <20210104120749.GK11878@paasikivi.fi.intel.com> <20210105144150.GS11878@paasikivi.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20210105144150.GS11878@paasikivi.fi.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_094947_200254_6E28EA49 X-CRM114-Status: GOOD ( 25.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?B?S8OpdmluIEwnaMO0cGl0YWw=?= , devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Chen-Yu Tsai , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============6756233287456076208==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6756233287456076208== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UmQFmlcrjB44pt9h" Content-Disposition: inline --UmQFmlcrjB44pt9h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Sakari, On Tue 05 Jan 21, 16:41, Sakari Ailus wrote: > Hi Paul, >=20 > On Tue, Jan 05, 2021 at 10:38:47AM +0100, Paul Kocialkowski wrote: > > Hi Sakari, > >=20 > > On Mon 04 Jan 21, 14:07, Sakari Ailus wrote: > > > Hi Paul, > > >=20 > > > On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote: > > > > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 f= ps. > > > > Other modes (including some with sub-sampling) are available too. > > > > It outputs 10-bit bayer CFA data through a MIPI CSI-2 interface with > > > > up to 4 lanes supported. > > >=20 > > > I've added the patches to a pull request to Mauro; there appear to st= ill be > > > some checkpatch.pl issues in both of the drivers. > > >=20 > > > I don't mind the warnings on the assignment or the mutex though. Coul= d you > > > address these in additional patches, please? > >=20 > > Sorry about that, I realized that I never run checkpatch with --strict > > so I completely missed those. > >=20 > > I'll fix the cosmetic issues in a following patch. > >=20 > > Just to clarify one thing: > > #define OV8865_PAD_PK_DRIVE_STRENGTH_2X (1 << 5) > > #define OV8865_BLC_CTRL1_COL_SHIFT_128 (1 << 4) > >=20 > > these are not single-bit fields so even though it looks like they should > > use BIT(), this would be incoherent with other possible values, such as: > > #define OV8865_PAD_PK_DRIVE_STRENGTH_3X (2 << 5) > > #define OV8865_BLC_CTRL1_COL_SHIFT_64 (2 << 4) >=20 > Agreed. >=20 > You might not assign the top bit, but if you did, the left operand would > have to be unsigned to guarantee the intended result (otherwise it's > undefined). Ah right, that's the issue with shifting signed constants up to the sign bi= t. I had a quick look and I think this driver's safe about it. Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --UmQFmlcrjB44pt9h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl/0fIUACgkQ3cLmz3+f v9GA3Qf+PbkUakvgTadm3DLLo6iY8bQ1j+VKKrmJHJ1f2qEjuje+B5oSFkNFtBSS Aq7A2ZvO9qa2c7UzJHN5ZVlsGhrRBs4q6dPXblJF/YFno6BcfY6JlJan9OB6G8pY zYWuYcM6mL8SDP8V9pctbp77492sBRRmFezOw+W1/JTQUuIz/4wUPrJ62Z+IQjSb u4oBIgGqtmSgowDC7NpRfXKhIPcSmcnGqsPcTxcQLMuHPFbKuL9vgRbDOUjBvyY/ qvtaRUp05zc/SU7GpqJ6E/dCW3Wm3Pyz+v/giDek3zZ/cc34GdABeAXOGbbn3W+R 1hLwnNIwbStljzlbDpVc6Pp9+JcWWQ== =VFPQ -----END PGP SIGNATURE----- --UmQFmlcrjB44pt9h-- --===============6756233287456076208== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6756233287456076208==--