From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21E5C433DB for ; Wed, 6 Jan 2021 10:12:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B5CB2311C for ; Wed, 6 Jan 2021 10:12:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B5CB2311C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UbG9++/TAAC5eCrhHJtU0U+hsULxEPlZ5ixMtVMuqdU=; b=eK7KEfLFDMqtFvoc6nYZgRK9E 6xeX21zucRN60UIN3ee0frkO3Wx82V3bhMkSvLMPTjVvsYZN0KFftWenRADvKMT/Ef15/VBadXCLb v5ppMHs6azzYkoIdWk+sYNxmNMUZ9mg2CmOQSACIwZLHzlopU2pRZVHs7m4Ud6PosmGS7tcXKS0Qi ESRHGPynZsXB23zsrL7/QXILjFC+SD1H5vKN4UNF2tlyuq4rYjX80Eq838ADaVHH+AC7NKFukPQ0w 1bL5inASbeT9bWQaNcIk1rsyXPkcOJVO/y6i16jH0Lqp7236CjSApI8yINW9DqgvaaDTOkgdmeHNl KFVImdUTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx5lY-0006Rp-4s; Wed, 06 Jan 2021 10:10:08 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx5lU-0006QQ-NG for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 10:10:06 +0000 Received: by mail-wm1-x32d.google.com with SMTP id g25so2838032wmh.1 for ; Wed, 06 Jan 2021 02:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYyg30QaTDPl/1SfAlH9RTsVh8+8mZmaYN21GkgmjzE=; b=dU+TthxcMGjTtNTHgAxVXU4RoesYX0+g99WP06hov8k5+rSF25PGYGQgv+pYLH9ckG cpOFnAM0PAAI7YejQrIJHu5grW+Yi0ZytOjyTDq/H1o74sD4vZRshf+L3csjqFLxW04I B1gNIOTJzvmEka1ljIVPJmu6F0U/alZBd99XxiQxOUphUvxWFEaAi8os+miAjfa1icSB 83os8+fz8W51CuiINLjCJmLG927DS2go5laF4PedUBdUlA1PKI1uIVChN1xY9eJjUpxV RSjEOgm+EiZVG/ijwACZGfwbxljK4OLRJoJucnkx1tAOEGGVIF9ylAwN+JLGXggtn/n+ UvNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYyg30QaTDPl/1SfAlH9RTsVh8+8mZmaYN21GkgmjzE=; b=doRG9RwBE0WOj0PXOY/EYZASbGKF37yTKwyM1d3ukilYhC/TnPbpf+F68ua/3/RUp0 1QUe4i8ozKG51JgAdKiHiuR9CoVdrOaul7mEZw2Dvz+gWMxRoFBtL34h3glfCUuDOne5 EZOJ9XIdo5GDmatIJ/p7kIvyzXHDsUgln8jfsAeVWwlEXWnxFjlgtMMEx6055/mMfGeC +5CT5oO16CV2i9Uyhi/xQ0Xi/bnCJ3HxwmciRE8ZCZKooOLsCIR5BP3KBxcTueupCiGD 2YU7DM4qhGJm1oDvcfaNaG+Ap1USU0EDL3ioe5ZGt7avGGf1gLZ2fROWeiLuhmNQxi34 WWTw== X-Gm-Message-State: AOAM531D/24cJX8+0H2D+fZXpXInXrUalWf1ZMqrrdB4xHIAnUe8mFKQ zk5q6ZwoTvyhWoq+ky0z7AdbrQ== X-Google-Smtp-Source: ABdhPJyYTgg3A5KVgYhik+U4iGyzXTzZ8PYLdEnALeRQjjVy1s7B3PnwykM8rNUrBWLGefy5aB2J7w== X-Received: by 2002:a1c:4c14:: with SMTP id z20mr3009430wmf.149.1609927801506; Wed, 06 Jan 2021 02:10:01 -0800 (PST) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id r7sm2394874wmh.2.2021.01.06.02.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 02:10:00 -0800 (PST) Date: Wed, 6 Jan 2021 11:09:42 +0100 From: Jean-Philippe Brucker To: Krishna Reddy Subject: Re: [PATCH v10 11/13] iommu/arm-smmu-v3: Add SVA device feature Message-ID: References: <20200918101852.582559-1-jean-philippe@linaro.org> <20200918101852.582559-12-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_051005_070869_89F84AF4 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sachin Nikam , "fenghua.yu@intel.com" , Terje Bergstrom , Nate Watterson , "will@kernel.org" , "catalin.marinas@arm.com" , Alistair Popple , Yu-Huan Hsu , Pritesh Raithatha , Vikram Sethi , "linux-mm@kvack.org" , "iommu@lists.linux-foundation.org" , Nicolin Chen , Jason Gunthorpe , "zhangfei.gao@linaro.org" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Dec 15, 2020 at 01:09:29AM +0000, Krishna Reddy wrote: > Hi Jean, > > > +bool arm_smmu_master_sva_supported(struct arm_smmu_master *master) { > > + if (!(master->smmu->features & ARM_SMMU_FEAT_SVA)) > > + return false; > + > > + /* SSID and IOPF support are mandatory for the moment */ > > + return master->ssid_bits && arm_smmu_iopf_supported(master); } > > + > > Tegra Next Gen SOC has arm-smmu-v3 and It doesn't have support for PRI interface. > However, PCIe client device has capability to handle the page faults on its own when the ATS translation fails. > The PCIe device needs SVA feature enable without PRI interface supported at arm-smmu-v3. > At present, the SVA feature enable is allowed only if the smmu/client device has PRI support. > There seem to be no functional reason to make pri_supported as a pre-requisite for SVA enable. The pri_supported check allows drivers to query whether the SMMU is compatible with their capability. It's pointless, for example, to enable SVA for a PRI-capable device if the SMMU doesn't support PRI. I agree that we should let a device driver enable SVA if it supports some form of IOPF. Perhaps we could extract the IOPF capability from IOMMU_DEV_FEAT_SVA, into a new IOMMU_DEV_FEAT_IOPF feature. Device drivers that rely on PRI or stall can first check FEAT_IOPF, then FEAT_SVA, and enable both separately. Enabling FEAT_SVA would require FEAT_IOPF enabled if supported. Let me try to write this up. Thanks, Jean > Can SVA enable be supported for pri_supported not set case as well? > Also, It is noticed that SVA enable on Intel doesn't need pri_supported set. > > -KR _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel