From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDB1C433DB for ; Fri, 8 Jan 2021 18:53:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA35823A5E for ; Fri, 8 Jan 2021 18:53:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA35823A5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2HpicckisUzIEhunYtC4i/kbjS9JmitjiVz4LhrJIZw=; b=oHwhNYT/L+GHXL0VcxnynCPmN EjAxKoYiNoPNmTF0K7oonpT1i/9p6QWHujA4YO7ser5lOygFLIg87Hli9Ll80QjdtJQV6XFepj3fd k0VNzfBG8UWKYzrhaTOASPMsLbBFDXV1QUOSqUXFItbmf5Loq84j6IQ0Aes5eyG/N9J4vbpyI1AHo ONUoQvdBwe4Xv5j+F+4/vA2N6Nrl89xunJ1bfu2r1Ar4KC9YIu1yyrmP2ynHr9GdpVeyWIWQ6QMel 4Ry0zl7Tiv5yObxj3KnGIjW5AyH5wtzDLKImMy/a0US8aEoTJ+uARKqmTWfs/vFsiPsbjPSbNZ/BM 6/lWcgs7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxwr8-0001K3-9T; Fri, 08 Jan 2021 18:51:26 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxwr5-0001Iy-HH for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 18:51:24 +0000 Received: by mail-oi1-x229.google.com with SMTP id 9so12438412oiq.3 for ; Fri, 08 Jan 2021 10:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yw5HNg0k9iL0QHuBnpeVEeXpmsT4zEnK0I09kWNg4VE=; b=spizBsCeh+YYB8W/IjGWwKrI/pXPx7LjOWGRXUcobQCpcJMuzvvYSXwo/EUa60JsKT xqqpQg4cjhZTH3RiJqykwYB5TPKMG3wEe0UkatR6OMwlSzLhFhWQ7C5dtU48nbJrSKuA i12Iez9VdRCHBrGjzjmgpQVRFfYvRqKSjMbLJJ0VzJpMcDzFPeXDsaOveDGSICugouUo Z+sIbi1pyYQzxa8XJBt2RvP06WF+GlIikHxSNNWOfi2IN9S8N9GIYZsKyBs/rk+OLHrS OWaqkXnzAY57hM6ps5KH9eaPJDojhSVPE7TJduuFCQ8KoUOUFfaqlRYYdoJZaO+x0q4B NzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yw5HNg0k9iL0QHuBnpeVEeXpmsT4zEnK0I09kWNg4VE=; b=GyVbj0iUa1l6eakjLyxya+oa+ZcSJAavTrdazvZ1gsrM9sJ/SfS9vaD01QdusyWHqF HcLicLEUY3LbKdeIeq95KTcBURBx6J0+zd7cD2KEfLn+r5negG2i3yTYy09fUJ7jfend pawkTRe95Qm8LFqnkfOgN8vPzRxMpfm70GKSnCIA1yRIUR57OnEj6Q/PgzzMRyHd/HV0 NqFYITH/gBMpcMuIWZAohavTkojM0aa9j2vN+Jg0t6WucbXTjAie3MKbxZZhzSaApYjH Bvc0rwf1VhadiGz6va+ZpcBqwVcqgVOA2hsibV8lfiATJAV9x4KP1gFpnFn9jm/8h77G ZQLg== X-Gm-Message-State: AOAM533ZEgOQdRFpt3pMfE+uV40JbgRdUvfZ+g1rq9RAXFaRmb64Wu1J va3dTJ+W5qpQjNX3iklVDyq2Ug== X-Google-Smtp-Source: ABdhPJxR70l+gieQE6A1jIIhmWfNLp4ron556Hy+l+ahoezA8S0Np6gHH+AXBp6x7HPJr+JKligh/g== X-Received: by 2002:aca:b657:: with SMTP id g84mr3289190oif.86.1610131880733; Fri, 08 Jan 2021 10:51:20 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h11sm1907017ooj.36.2021.01.08.10.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 10:51:19 -0800 (PST) Date: Fri, 8 Jan 2021 12:51:18 -0600 From: Bjorn Andersson To: Robert Foss Subject: Re: [PATCH v1 01/17] media: camss: Fix comment using wrong function name Message-ID: References: <20210108120429.895046-1-robert.foss@linaro.org> <20210108120429.895046-2-robert.foss@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108120429.895046-2-robert.foss@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_135123_674891_D9E74532 X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geert+renesas@glider.be, catalin.marinas@arm.com, agx@sigxcpu.org, todor.too@gmail.com, Laurent Pinchart , AngeloGioacchino Del Regno , will@kernel.org, Anson.Huang@nxp.com, agross@kernel.org, Andrey Konovalov , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tomasz Figa , arnd@arndb.de, linux-arm-msm@vger.kernel.org, robh+dt@kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, Sarvesh Sridutt , max.oss.09@gmail.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, michael@walle.cc, Azam Sadiq Pasha Kapatrala Syed , shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 08 Jan 06:04 CST 2021, Robert Foss wrote: > Function name is comment is wrong, and was changed to be > the same as the actual function name. > > Signed-off-by: Robert Foss > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index fae2b513b2f9..478be4f0cab5 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -1077,7 +1077,7 @@ static void vfe_isr_wm_done(struct vfe_device *vfe, u8 wm) > } > > /* > - * vfe_isr_wm_done - Process composite image done interrupt > + * vfe_isr_comp_done - Process composite image done interrupt It's a function, so it should be "vfe_isr_comp_done()", but unless the comment is denoted kerneldoc by starting with '/' followed by two '*' it "doesn't matter". As a matter of fact, none of the kerneldoc in this file has the proper '/**' start, so this file is "undocumented". So please add another '*' and some () throughout the file. Regards, Bjorn > * @vfe: VFE Device > * @comp: Composite image id > */ > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel