From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, Peng Fan <peng.fan@nxp.com>,
mathieu.poirier@linaro.org, festevam@gmail.com,
s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, patrice.chotard@st.com,
paul@crapouillou.net, o.rempel@pengutronix.de, agross@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/8] remoteproc: imx_rproc: correct err message
Date: Mon, 21 Dec 2020 18:26:41 -0600 [thread overview]
Message-ID: <X+E9QfqsMQEFkIPE@builder.lan> (raw)
In-Reply-To: <20201221100632.7197-4-peng.fan@oss.nxp.com>
On Mon 21 Dec 04:06 CST 2020, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> It is using devm_ioremap, so not devm_ioremap_resource. Correct
> the error message and print out sa/size.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V4:
> Drop the R-b tag
> Follow Bjorn's comments, correct/update the err msg.
>
> drivers/remoteproc/imx_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 6603e00bb6f4..fab772b02c9f 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> att->sa, att->size);
> if (!priv->mem[b].cpu_addr) {
> - dev_err(dev, "devm_ioremap_resource failed\n");
> + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa);
> return -ENOMEM;
> }
> priv->mem[b].sys_addr = att->sa;
> @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
>
> priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
> if (IS_ERR(priv->mem[b].cpu_addr)) {
> - dev_err(dev, "devm_ioremap_resource failed\n");
> + dev_err(dev, "failed to remap %pr\n", &res);
> err = PTR_ERR(priv->mem[b].cpu_addr);
> return err;
> }
> --
> 2.28.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-22 0:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 10:06 [PATCH 0/8] remoteproc: imx_rproc: support iMX8MQ/M Peng Fan (OSS)
2020-12-21 10:06 ` [PATCH 1/8] remoteproc: introduce is_iomem to rproc_mem_entry Peng Fan (OSS)
2020-12-22 0:26 ` Bjorn Andersson
2020-12-21 10:06 ` [PATCH 2/8] remoteproc: add is_iomem to da_to_va Peng Fan (OSS)
2020-12-22 0:25 ` Bjorn Andersson
2020-12-21 10:06 ` [PATCH 3/8] remoteproc: imx_rproc: correct err message Peng Fan (OSS)
2020-12-22 0:26 ` Bjorn Andersson [this message]
2020-12-21 10:06 ` [PATCH 4/8] remoteproc: imx_rproc: use devm_ioremap Peng Fan (OSS)
2020-12-21 10:06 ` [PATCH 5/8] remoteproc: imx_rproc: add i.MX specific parse fw hook Peng Fan (OSS)
2020-12-21 10:06 ` [PATCH 6/8] remoteproc: imx_rproc: support i.MX8MQ/M Peng Fan (OSS)
2020-12-21 10:06 ` [PATCH 7/8] remoteproc: imx_rproc: ignore mapping vdev regions Peng Fan (OSS)
2020-12-21 10:06 ` [PATCH 8/8] remoteproc: imx_proc: enable virtio/mailbox Peng Fan (OSS)
2020-12-22 7:54 ` [PATCH 0/8] remoteproc: imx_rproc: support iMX8MQ/M Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+E9QfqsMQEFkIPE@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=paul@crapouillou.net \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).