From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Syed Nayyar Waris <syednwaris@gmail.com>
Cc: linux-arch@vger.kernel.org, amit.kucheria@verdurent.com,
arnd@arndb.de, yamada.masahiro@socionext.com,
linus.walleij@linaro.org, daniel.lezcano@linaro.org,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
bgolaszewski@baylibre.com, rrichter@marvell.com,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
rui.zhang@intel.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] gpio: xilinx: Add extra check if sum of widths exceed 64
Date: Mon, 28 Dec 2020 06:58:02 -0500 [thread overview]
Message-ID: <X+nISkkcqyHf2fTE@shinobu> (raw)
In-Reply-To: <fd642c0843d59a0091931fcf9baa19a9dbb6e2e7.1608963095.git.syednwaris@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
On Sat, Dec 26, 2020 at 12:15:20PM +0530, Syed Nayyar Waris wrote:
> Add extra check to see if sum of widths does not exceed 64. If it
> exceeds then return -EINVAL alongwith appropriate error message.
>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
Hello Syed,
This change is independent from the rest of this patchset so I recommend
dropping this patch and instead resubmitting it separately as an
independent patch submission.
William Breathitt Gray
> ---
> drivers/gpio/gpio-xilinx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index d565fbf128b7..c9d740ac711b 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -319,6 +319,12 @@ static int xgpio_probe(struct platform_device *pdev)
>
> chip->gc.base = -1;
> chip->gc.ngpio = chip->gpio_width[0] + chip->gpio_width[1];
> +
> + if (chip->gc.ngpio > 64) {
> + dev_err(&pdev->dev, "invalid configuration: number of GPIO is greater than 64");
> + return -EINVAL;
> + }
> +
> chip->gc.parent = &pdev->dev;
> chip->gc.direction_input = xgpio_dir_in;
> chip->gc.direction_output = xgpio_dir_out;
> --
> 2.29.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-28 11:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 6:41 [PATCH 0/5] Introduce the for_each_set_clump macro Syed Nayyar Waris
2020-12-26 6:42 ` [PATCH 1/5] clump_bits: " Syed Nayyar Waris
2020-12-27 22:03 ` Arnd Bergmann
2020-12-28 12:10 ` William Breathitt Gray
2020-12-26 6:43 ` [PATCH 2/5] lib/test_bitmap.c: Add for_each_set_clump test cases Syed Nayyar Waris
[not found] ` <CAHp75VcSsfDKY3w4ufZktXzRB=GiObAV6voPfmeAHcbdwX0uqg@mail.gmail.com>
2021-02-04 8:55 ` Syed Nayyar Waris
2021-02-07 4:18 ` Syed Nayyar Waris
2020-12-26 6:43 ` [PATCH 3/5] gpio: thunderx: Utilize for_each_set_clump macro Syed Nayyar Waris
2020-12-26 6:44 ` [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2020-12-27 21:29 ` Linus Walleij
2021-01-05 11:04 ` Michal Simek
2020-12-26 6:45 ` [PATCH 5/5] gpio: xilinx: Add extra check if sum of widths exceed 64 Syed Nayyar Waris
2020-12-28 11:58 ` William Breathitt Gray [this message]
2021-01-05 11:01 ` Michal Simek
2020-12-27 21:26 ` [PATCH 0/5] Introduce the for_each_set_clump macro Linus Walleij
2021-01-05 14:19 ` Bartosz Golaszewski
2021-01-05 14:39 ` Andy Shevchenko
2021-01-06 7:27 ` Bartosz Golaszewski
2021-01-06 8:19 ` William Breathitt Gray
2021-01-05 11:09 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+nISkkcqyHf2fTE@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=rui.zhang@intel.com \
--cc=syednwaris@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).