Re: [PATCH v2] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET

From: Greg KH <greg@kroah.com>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	Christopher Swenson <swenson@swenson.io>,
	linux-kernel@vger.kernel.org, Macpaul Lin <macpaul@gmail.com>,
	Eddie Hung <eddie.hung@mediatek.com>,
	Takashi Iwai <tiwai@suse.com>,
	stable@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Alexander Tsoy <alexander@tsoy.me>,
	linux-mediatek@lists.infradead.org,
	Nick Kossifidis <mickflemm@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nicola Lunghi <nick83ola@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Ainge Hsu <ainge.hsu@mediatek.com>
Subject: Re: [PATCH v2] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Tue, 10 Nov 2020 09:50:49 +0100	[thread overview]
Message-ID: <X6pUaatZ7aML4sKq@kroah.com> (raw)
In-Reply-To: <1604997774-13593-1-git-send-email-macpaul.lin@mediatek.com>

On Tue, Nov 10, 2020 at 04:42:54PM +0800, Macpaul Lin wrote:
> The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> 96khz. However there will be some random issue under 96khz.
> Not sure if there is any alternate setting could be applied.
> Hence 48khz is suggested to be applied at this moment.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> Cc: stable@vger.kernel.org
> ---
> Changes for v2:
>   - Fix build error.
>   - Add Cc: stable@vger.kernel.org
> 
>  sound/usb/format.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/usb/format.c b/sound/usb/format.c
> index 1b28d01..7a4837b 100644
> --- a/sound/usb/format.c
> +++ b/sound/usb/format.c
> @@ -202,6 +202,7 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
>  		fp->rate_min = fp->rate_max = 0;
>  		for (r = 0, idx = offset + 1; r < nr_rates; r++, idx += 3) {
>  			unsigned int rate = combine_triple(&fmt[idx]);
> +			struct usb_device *udev = chip->dev;
>  			if (!rate)
>  				continue;
>  			/* C-Media CM6501 mislabels its 96 kHz altsetting */

Did you run this patch through checkpatch.pl?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel